Re: [PATCH v2 2/8] arm64: dts: qcom: pm8150: Add Base DTS file

2019-08-20 Thread Vinod Koul 
On 20-08-19, 14:27, Niklas Cassel wrote:
> On Tue, Aug 20, 2019 at 12:12:10PM +0530, Vinod Koul wrote:
> > Add base DTS file for pm8150 along with GPIOs, power-on, rtc and vadc
> > nodes
> > 
> > Signed-off-by: Vinod Koul 
> > ---
> >  arch/arm64/boot/dts/qcom/pm8150.dtsi | 95 
> >  1 file changed, 95 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/qcom/pm8150.dtsi
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi 
> > b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> > new file mode 100644
> > index ..4a678be46d37
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> > @@ -0,0 +1,95 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +// Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
> > +// Copyright (c) 2019, Linaro Limited
> > +
> > +#include 
> > +#include 
> > +#include 
> > +#include 
> > +
> > +_bus {
> > +   pm8150_0: pmic@0 {
> > +   compatible = "qcom,pm8150", "qcom,spmi-pmic";
> > +   reg = <0x0 SPMI_USID>;
> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +
> > +   pon: power-on@800 {
> > +   compatible = "qcom,pm8916-pon";
> > +   reg = <0x0800>;
> > +   pwrkey {
> > +   compatible = "qcom,pm8941-pwrkey";
> > +   interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
> 
> Here you use 0 for 3rd cell
> 
> > +   debounce = <15625>;
> > +   bias-pull-up;
> > +   linux,code = ;
> > +
> > +   status = "disabled";
> > +   };
> > +   };
> > +
> > +   pm8150_adc: adc@3100 {
> > +   compatible = "qcom,spmi-adc5";
> > +   reg = <0x3100>;
> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +   #io-channel-cells = <1>;
> > +   interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
> 
> Here you use 0x0 for 3rd cell, be consistent.

Will make it either at this and other places, thanks for pointing!

-- 
~Vinod

Re: [PATCH v2 2/8] arm64: dts: qcom: pm8150: Add Base DTS file

2019-08-20 Thread Niklas Cassel 
On Tue, Aug 20, 2019 at 12:12:10PM +0530, Vinod Koul wrote:
> Add base DTS file for pm8150 along with GPIOs, power-on, rtc and vadc
> nodes
> 
> Signed-off-by: Vinod Koul 
> ---
>  arch/arm64/boot/dts/qcom/pm8150.dtsi | 95 
>  1 file changed, 95 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/pm8150.dtsi
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi 
> b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> new file mode 100644
> index ..4a678be46d37
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> @@ -0,0 +1,95 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +// Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
> +// Copyright (c) 2019, Linaro Limited
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +
> +_bus {
> + pm8150_0: pmic@0 {
> + compatible = "qcom,pm8150", "qcom,spmi-pmic";
> + reg = <0x0 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pon: power-on@800 {
> + compatible = "qcom,pm8916-pon";
> + reg = <0x0800>;
> + pwrkey {
> + compatible = "qcom,pm8941-pwrkey";
> + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;

Here you use 0 for 3rd cell

> + debounce = <15625>;
> + bias-pull-up;
> + linux,code = ;
> +
> + status = "disabled";
> + };
> + };
> +
> + pm8150_adc: adc@3100 {
> + compatible = "qcom,spmi-adc5";
> + reg = <0x3100>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + #io-channel-cells = <1>;
> + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;

Here you use 0x0 for 3rd cell, be consistent.

> +
> + status = "disabled";
> +
> + ref-gnd@0 {
> + reg = ;
> + qcom,pre-scaling = <1 1>;
> + label = "ref_gnd";
> + };
> +
> + vref-1p25@1 {
> + reg = ;
> + qcom,pre-scaling = <1 1>;
> + label = "vref_1p25";
> + };
> +
> + die-temp@6 {
> + reg = ;
> + qcom,pre-scaling = <1 1>;
> + label = "die_temp";
> + };
> + };
> +
> + rtc@6000 {
> + compatible = "qcom,pm8941-rtc";
> + reg = <0x6000>;
> + reg-names = "rtc", "alarm";
> + interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
> +
> + status = "disabled";
> + };
> +
> + pm8150_gpios: gpio@c000 {
> + compatible = "qcom,pm8150-gpio";
> + reg = <0xc000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
> +  <0 0xc1 0 IRQ_TYPE_NONE>,
> +  <0 0xc2 0 IRQ_TYPE_NONE>,
> +  <0 0xc3 0 IRQ_TYPE_NONE>,
> +  <0 0xc4 0 IRQ_TYPE_NONE>,
> +  <0 0xc5 0 IRQ_TYPE_NONE>,
> +  <0 0xc6 0 IRQ_TYPE_NONE>,
> +  <0 0xc7 0 IRQ_TYPE_NONE>,
> +  <0 0xc8 0 IRQ_TYPE_NONE>,
> +  <0 0xc9 0 IRQ_TYPE_NONE>,
> +  <0 0xca 0 IRQ_TYPE_NONE>,
> +  <0 0xcb 0 IRQ_TYPE_NONE>;
> + };
> + };
> +
> + pmic@1 {
> + compatible = "qcom,pm8150", "qcom,spmi-pmic";
> + reg = <0x1 SPMI_USID>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> +};
> -- 
> 2.20.1
>

[PATCH v2 2/8] arm64: dts: qcom: pm8150: Add Base DTS file

2019-08-20 Thread Vinod Koul 
Add base DTS file for pm8150 along with GPIOs, power-on, rtc and vadc
nodes

Signed-off-by: Vinod Koul 
---
 arch/arm64/boot/dts/qcom/pm8150.dtsi | 95 
 1 file changed, 95 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm8150.dtsi

diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi 
b/arch/arm64/boot/dts/qcom/pm8150.dtsi
new file mode 100644
index ..4a678be46d37
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi
@@ -0,0 +1,95 @@
+// SPDX-License-Identifier: BSD-3-Clause
+// Copyright (c) 2017-2019, The Linux Foundation. All rights reserved.
+// Copyright (c) 2019, Linaro Limited
+
+#include 
+#include 
+#include 
+#include 
+
+_bus {
+   pm8150_0: pmic@0 {
+   compatible = "qcom,pm8150", "qcom,spmi-pmic";
+   reg = <0x0 SPMI_USID>;
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   pon: power-on@800 {
+   compatible = "qcom,pm8916-pon";
+   reg = <0x0800>;
+   pwrkey {
+   compatible = "qcom,pm8941-pwrkey";
+   interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>;
+   debounce = <15625>;
+   bias-pull-up;
+   linux,code = ;
+
+   status = "disabled";
+   };
+   };
+
+   pm8150_adc: adc@3100 {
+   compatible = "qcom,spmi-adc5";
+   reg = <0x3100>;
+   #address-cells = <1>;
+   #size-cells = <0>;
+   #io-channel-cells = <1>;
+   interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
+
+   status = "disabled";
+
+   ref-gnd@0 {
+   reg = ;
+   qcom,pre-scaling = <1 1>;
+   label = "ref_gnd";
+   };
+
+   vref-1p25@1 {
+   reg = ;
+   qcom,pre-scaling = <1 1>;
+   label = "vref_1p25";
+   };
+
+   die-temp@6 {
+   reg = ;
+   qcom,pre-scaling = <1 1>;
+   label = "die_temp";
+   };
+   };
+
+   rtc@6000 {
+   compatible = "qcom,pm8941-rtc";
+   reg = <0x6000>;
+   reg-names = "rtc", "alarm";
+   interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
+
+   status = "disabled";
+   };
+
+   pm8150_gpios: gpio@c000 {
+   compatible = "qcom,pm8150-gpio";
+   reg = <0xc000>;
+   gpio-controller;
+   #gpio-cells = <2>;
+   interrupts = <0 0xc0 0 IRQ_TYPE_NONE>,
+<0 0xc1 0 IRQ_TYPE_NONE>,
+<0 0xc2 0 IRQ_TYPE_NONE>,
+<0 0xc3 0 IRQ_TYPE_NONE>,
+<0 0xc4 0 IRQ_TYPE_NONE>,
+<0 0xc5 0 IRQ_TYPE_NONE>,
+<0 0xc6 0 IRQ_TYPE_NONE>,
+<0 0xc7 0 IRQ_TYPE_NONE>,
+<0 0xc8 0 IRQ_TYPE_NONE>,
+<0 0xc9 0 IRQ_TYPE_NONE>,
+<0 0xca 0 IRQ_TYPE_NONE>,
+<0 0xcb 0 IRQ_TYPE_NONE>;
+   };
+   };
+
+   pmic@1 {
+   compatible = "qcom,pm8150", "qcom,spmi-pmic";
+   reg = <0x1 SPMI_USID>;
+   #address-cells = <1>;
+   #size-cells = <0>;
+   };
+};
-- 
2.20.1