Re: [PATCH v2 22/24] scsi: aic7xxx: aic79xx_osm: Remove unused variables 'wait' and 'paused'

2020-07-14 Thread Hannes Reinecke
On 7/13/20 9:59 AM, Lee Jones wrote:
> It looks like they have never actually been used.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_dev_reset’:
>  drivers/scsi/aic7xxx/aic79xx_osm.c:782:9: warning: variable ‘wait’ set but 
> not used [-Wunused-but-set-variable]
>  drivers/scsi/aic7xxx/aic79xx_osm.c:781:9: warning: variable ‘paused’ set but 
> not used [-Wunused-but-set-variable]
> 
> Cc: Hannes Reinecke 
> Signed-off-by: Lee Jones 
> ---
>  drivers/scsi/aic7xxx/aic79xx_osm.c | 5 +
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c 
> b/drivers/scsi/aic7xxx/aic79xx_osm.c
> index 9235b6283c0b3..8e43ff86e0a60 100644
> --- a/drivers/scsi/aic7xxx/aic79xx_osm.c
> +++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
> @@ -775,16 +775,13 @@ ahd_linux_dev_reset(struct scsi_cmnd *cmd)
>   struct scb *reset_scb;
>   u_int  cdb_byte;
>   intretval = SUCCESS;
> - intpaused;
> - intwait;
>   struct  ahd_initiator_tinfo *tinfo;
>   struct  ahd_tmode_tstate *tstate;
>   unsigned long flags;
>   DECLARE_COMPLETION_ONSTACK(done);
>  
>   reset_scb = NULL;
> - paused = FALSE;
> - wait = FALSE;
> +
>   ahd = *(struct ahd_softc **)cmd->device->host->hostdata;
>  
>   scmd_printk(KERN_INFO, cmd,
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckeKernel Storage Architect
h...@suse.de  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer


[PATCH v2 22/24] scsi: aic7xxx: aic79xx_osm: Remove unused variables 'wait' and 'paused'

2020-07-13 Thread Lee Jones
It looks like they have never actually been used.

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/aic7xxx/aic79xx_osm.c: In function ‘ahd_linux_dev_reset’:
 drivers/scsi/aic7xxx/aic79xx_osm.c:782:9: warning: variable ‘wait’ set but not 
used [-Wunused-but-set-variable]
 drivers/scsi/aic7xxx/aic79xx_osm.c:781:9: warning: variable ‘paused’ set but 
not used [-Wunused-but-set-variable]

Cc: Hannes Reinecke 
Signed-off-by: Lee Jones 
---
 drivers/scsi/aic7xxx/aic79xx_osm.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c 
b/drivers/scsi/aic7xxx/aic79xx_osm.c
index 9235b6283c0b3..8e43ff86e0a60 100644
--- a/drivers/scsi/aic7xxx/aic79xx_osm.c
+++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
@@ -775,16 +775,13 @@ ahd_linux_dev_reset(struct scsi_cmnd *cmd)
struct scb *reset_scb;
u_int  cdb_byte;
intretval = SUCCESS;
-   intpaused;
-   intwait;
struct  ahd_initiator_tinfo *tinfo;
struct  ahd_tmode_tstate *tstate;
unsigned long flags;
DECLARE_COMPLETION_ONSTACK(done);
 
reset_scb = NULL;
-   paused = FALSE;
-   wait = FALSE;
+
ahd = *(struct ahd_softc **)cmd->device->host->hostdata;
 
scmd_printk(KERN_INFO, cmd,
-- 
2.25.1