Re: [PATCH v2 3/3] ARM: dts: mt8135: Add Reset Controller for MediaTek SoC

2014-11-03 Thread Philipp Zabel
Am Montag, den 03.11.2014, 17:02 +0800 schrieb Flora Fu:
> Add reset controller to MT8135 board dts.
> 
> Signed-off-by: Flora Fu 
> ---
>  arch/arm/boot/dts/mt8135.dtsi | 26 ++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi
> index 90a56ad..259a2b5 100644
> --- a/arch/arm/boot/dts/mt8135.dtsi
> +++ b/arch/arm/boot/dts/mt8135.dtsi
> @@ -102,6 +102,32 @@
>   clock-names = "system-clk", "rtc-clk";
>   };
>  
> + infracfg: syscon@10001000 {
> + #address-cells = <1>;
> + #size-cells = <0>;

Same as with patch 2, please use #size-cells = <1>.

> + compatible = "mediatek,mt8135-infracfg", "syscon";
> + reg = <0 0x10001000 0 0x1000>;
> +
> + infrarst: reset-controller@30 {
> + #reset-cells = <1>;
> + compatible = "mediatek,mt8135-infracfg-reset", 
> "mediatek,reset";
> + reg = <0x30 0x8>;
> + };
> + };
> +
> + pericfg: syscon@10003000 {
> + #address-cells = <1>;
> + #size-cells = <0>;

And here. Other than that,
Acked-by: Philipp Zabel 

> + compatible = "mediatek,mt8135-pericfg", "syscon";
> + reg = <0 0x10003000 0 0x1000>;
> +
> + perirst: reset-controller@00 {
> + #reset-cells = <1>;
> + compatible = "mediatek,mt8135-pericfg-reset", 
> "mediatek,reset";
> + reg = <0x00 0x8>;
> + };
> + };
> +
>   gic: interrupt-controller@10211000 {
>   compatible = "arm,cortex-a15-gic";
>   interrupt-controller;

regards
Philipp

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH v2 3/3] ARM: dts: mt8135: Add Reset Controller for MediaTek SoC

2014-11-03 Thread Flora Fu
Add reset controller to MT8135 board dts.

Signed-off-by: Flora Fu 
---
 arch/arm/boot/dts/mt8135.dtsi | 26 ++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi
index 90a56ad..259a2b5 100644
--- a/arch/arm/boot/dts/mt8135.dtsi
+++ b/arch/arm/boot/dts/mt8135.dtsi
@@ -102,6 +102,32 @@
clock-names = "system-clk", "rtc-clk";
};
 
+   infracfg: syscon@10001000 {
+   #address-cells = <1>;
+   #size-cells = <0>;
+   compatible = "mediatek,mt8135-infracfg", "syscon";
+   reg = <0 0x10001000 0 0x1000>;
+
+   infrarst: reset-controller@30 {
+   #reset-cells = <1>;
+   compatible = "mediatek,mt8135-infracfg-reset", 
"mediatek,reset";
+   reg = <0x30 0x8>;
+   };
+   };
+
+   pericfg: syscon@10003000 {
+   #address-cells = <1>;
+   #size-cells = <0>;
+   compatible = "mediatek,mt8135-pericfg", "syscon";
+   reg = <0 0x10003000 0 0x1000>;
+
+   perirst: reset-controller@00 {
+   #reset-cells = <1>;
+   compatible = "mediatek,mt8135-pericfg-reset", 
"mediatek,reset";
+   reg = <0x00 0x8>;
+   };
+   };
+
gic: interrupt-controller@10211000 {
compatible = "arm,cortex-a15-gic";
interrupt-controller;
-- 
1.8.1.1.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/