Re: [PATCH v2 3/3] dt-bindings: usb: fsa4480: Add compatible for OCP96011

2023-10-24 Thread Rob Herring 


On Fri, 20 Oct 2023 11:33:20 +0200, Luca Weiss wrote:
> The Orient-Chip OCP96011 is generally compatible with the FSA4480, add a
> compatible for it with the fallback on fsa4480.
> 
> However the AUX/SBU connections are expected to be swapped compared to
> FSA4480, so document this in the data-lanes description.
> 
> Signed-off-by: Luca Weiss 
> ---
>  Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml | 18 
> ++
>  1 file changed, 14 insertions(+), 4 deletions(-)
> 

Reviewed-by: Rob Herring

[PATCH v2 3/3] dt-bindings: usb: fsa4480: Add compatible for OCP96011

2023-10-20 Thread Luca Weiss 
The Orient-Chip OCP96011 is generally compatible with the FSA4480, add a
compatible for it with the fallback on fsa4480.

However the AUX/SBU connections are expected to be swapped compared to
FSA4480, so document this in the data-lanes description.

Signed-off-by: Luca Weiss 
---
 Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml | 18 ++
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml 
b/Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml
index 86f6d633c2fb..f9410eb76a62 100644
--- a/Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml
+++ b/Documentation/devicetree/bindings/usb/fcs,fsa4480.yaml
@@ -11,8 +11,12 @@ maintainers:
 
 properties:
   compatible:
-enum:
-  - fcs,fsa4480
+oneOf:
+  - const: fcs,fsa4480
+  - items:
+  - enum:
+  - ocs,ocp96011
+  - const: fcs,fsa4480
 
   reg:
 maxItems: 1
@@ -53,16 +57,22 @@ properties:
   - const: 0
   - const: 1
 description: |
-  Default AUX/SBU layout
+  Default AUX/SBU layout (FSA4480)
   - AUX+ connected to SBU2
   - AUX- connected to SBU1
+  Default AUX/SBU layout (OCP96011)
+  - AUX+ connected to SBU1
+  - AUX- connected to SBU2
   - items:
   - const: 1
   - const: 0
 description: |
-  Swapped AUX/SBU layout
+  Swapped AUX/SBU layout (FSA4480)
   - AUX+ connected to SBU1
   - AUX- connected to SBU2
+  Swapped AUX/SBU layout (OCP96011)
+  - AUX+ connected to SBU2
+  - AUX- connected to SBU1
 
 required:
   - compatible

-- 
2.42.0