Re: [PATCH v2 3/3] x86/hash: cleanup
On 02/27/2014 09:47 AM, Jan Beulich wrote: - simplify switch statement - add __init annotation to setup_arch_fast_hash() Signed-off-by: Jan Beulich Cc: Francesco Fusco Cc: Daniel Borkmann Cc: Thomas Graf Cc: David S. Miller Acked-by: Daniel Borkmann -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 3/3] x86/hash: cleanup
- simplify switch statement
- add __init annotation to setup_arch_fast_hash()
Signed-off-by: Jan Beulich
Cc: Francesco Fusco
Cc: Daniel Borkmann
Cc: Thomas Graf
Cc: David S. Miller
---
arch/x86/lib/hash.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
--- 3.14-rc4-x86-hash-crc32.orig/arch/x86/lib/hash.c
+++ 3.14-rc4-x86-hash-crc32/arch/x86/lib/hash.c
@@ -32,6 +32,7 @@
*/
#include
+#include
#include
#include
@@ -55,17 +56,16 @@ static u32 intel_crc4_2_hash(const void
for (i = 0; i < len / 4; i++)
seed = crc32_u32(seed, *p32++);
- switch (3 - (len & 0x03)) {
- case 0:
+ switch (len & 3) {
+ case 3:
tmp |= *((const u8 *) p32 + 2) << 16;
/* fallthrough */
- case 1:
+ case 2:
tmp |= *((const u8 *) p32 + 1) << 8;
/* fallthrough */
- case 2:
+ case 1:
tmp |= *((const u8 *) p32);
seed = crc32_u32(seed, tmp);
- default:
break;
}
@@ -83,7 +83,7 @@ static u32 intel_crc4_2_hash2(const u32
return seed;
}
-void setup_arch_fast_hash(struct fast_hash_ops *ops)
+void __init setup_arch_fast_hash(struct fast_hash_ops *ops)
{
if (cpu_has_xmm4_2) {
ops->hash = intel_crc4_2_hash;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 3/3] x86/hash: cleanup
- simplify switch statement
- add __init annotation to setup_arch_fast_hash()
Signed-off-by: Jan Beulich jbeul...@suse.com
Cc: Francesco Fusco ffu...@redhat.com
Cc: Daniel Borkmann dbork...@redhat.com
Cc: Thomas Graf tg...@redhat.com
Cc: David S. Miller da...@davemloft.net
---
arch/x86/lib/hash.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
--- 3.14-rc4-x86-hash-crc32.orig/arch/x86/lib/hash.c
+++ 3.14-rc4-x86-hash-crc32/arch/x86/lib/hash.c
@@ -32,6 +32,7 @@
*/
#include linux/hash.h
+#include linux/init.h
#include asm/processor.h
#include asm/cpufeature.h
@@ -55,17 +56,16 @@ static u32 intel_crc4_2_hash(const void
for (i = 0; i len / 4; i++)
seed = crc32_u32(seed, *p32++);
- switch (3 - (len 0x03)) {
- case 0:
+ switch (len 3) {
+ case 3:
tmp |= *((const u8 *) p32 + 2) 16;
/* fallthrough */
- case 1:
+ case 2:
tmp |= *((const u8 *) p32 + 1) 8;
/* fallthrough */
- case 2:
+ case 1:
tmp |= *((const u8 *) p32);
seed = crc32_u32(seed, tmp);
- default:
break;
}
@@ -83,7 +83,7 @@ static u32 intel_crc4_2_hash2(const u32
return seed;
}
-void setup_arch_fast_hash(struct fast_hash_ops *ops)
+void __init setup_arch_fast_hash(struct fast_hash_ops *ops)
{
if (cpu_has_xmm4_2) {
ops-hash = intel_crc4_2_hash;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 3/3] x86/hash: cleanup
On 02/27/2014 09:47 AM, Jan Beulich wrote: - simplify switch statement - add __init annotation to setup_arch_fast_hash() Signed-off-by: Jan Beulich jbeul...@suse.com Cc: Francesco Fusco ffu...@redhat.com Cc: Daniel Borkmann dbork...@redhat.com Cc: Thomas Graf tg...@redhat.com Cc: David S. Miller da...@davemloft.net Acked-by: Daniel Borkmann dbork...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
