Re: [PATCH v2 3/4] dt-bindings: usb: Add Microchip USB47xx/USB49xx support

2020-07-26 Thread Greg Kroah-Hartman
On Thu, Jul 23, 2020 at 09:29:01PM +0200, Christian Eggers wrote:
> Add DT bindings for Microchip USB47xx/USB49xx driver.
> 
> Signed-off-by: Christian Eggers 
> ---
> > My bot found errors running 'make dt_binding_check' on your patch:
> 
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb49xx.example.dt.yaml:
> >  usb4916i@2d: 'ocs-min-width-ms' does not match any of the regexes: 
> > 'pinctrl-[0-9]+'
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> The mistake was sitting in front of the computer. I simply overlooked this 
> message.
> 
> Changes in v2:
> - added property description for ocs-min-width-ms
> - fixed property description for oc-delay-ns

Please resend the whole series, not just a single patch, as it makes it
very difficult to pick the "correct" patches to be applied...

thanks,

greg k-h


[PATCH v2 3/4] dt-bindings: usb: Add Microchip USB47xx/USB49xx support

2020-07-23 Thread Christian Eggers
Add DT bindings for Microchip USB47xx/USB49xx driver.

Signed-off-by: Christian Eggers 
---
> My bot found errors running 'make dt_binding_check' on your patch:

> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/usb49xx.example.dt.yaml:
>  usb4916i@2d: 'ocs-min-width-ms' does not match any of the regexes: 
> 'pinctrl-[0-9]+'
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
The mistake was sitting in front of the computer. I simply overlooked this 
message.

Changes in v2:
- added property description for ocs-min-width-ms
- fixed property description for oc-delay-ns

 .../devicetree/bindings/usb/usb49xx.yaml  | 238 ++
 1 file changed, 238 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/usb/usb49xx.yaml

diff --git a/Documentation/devicetree/bindings/usb/usb49xx.yaml 
b/Documentation/devicetree/bindings/usb/usb49xx.yaml
new file mode 100644
index ..a4843f2cbefa
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/usb49xx.yaml
@@ -0,0 +1,238 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/usb49xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip USB47xx/USB49xx USB 2.0 Hi-Speed Hub Controller
+
+maintainers:
+  - Christian Eggers 
+
+description: |
+  
http://ww1.microchip.com/downloads/en/Appnotes/AN2651-Configuration-of-Microchip-USB47xx-USB49xx-Application-Note-2651B.pdf
+
+properties:
+  compatible:
+enum:
+  - microchip,usb4712
+  - microchip,usb4712i
+  - microchip,usb4715
+  - microchip,usb4715i
+  - microchip,usb4912
+  - microchip,usb4912i
+  - microchip,usb4914
+  - microchip,usb4914i
+  - microchip,usb4916
+  - microchip,usb4916i
+  - microchip,usb4925
+  - microchip,usb4925i
+  - microchip,usb4927
+  - microchip,usb4927i
+
+  reg:
+maxItems: 1
+description:
+  I2C address on the selected bus (usually <0x2D>).
+
+  reset-gpios:
+maxItems: 1
+description:
+  Specify the gpio for hub reset.
+
+  vdd-supply:
+$ref: /schemas/types.yaml#/definitions/phandle
+description:
+  Specify the regulator supplying vdd.
+
+  skip-config:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Skip Hub configuration, but only send the USB-Attach command.
+
+  vendor-id:
+$ref: /schemas/types.yaml#/definitions/uint32
+maximum: 65535
+description:
+  Set USB Vendor ID of the hub.
+
+  product-id:
+$ref: /schemas/types.yaml#/definitions/uint32
+maximum: 65535
+description:
+  Set USB Product ID of the hub.
+
+  device-id:
+$ref: /schemas/types.yaml#/definitions/uint32
+maximum: 65535
+description:
+  Set USB Device ID of the hub.
+
+  language-id:
+$ref: /schemas/types.yaml#/definitions/uint32
+maximum: 65535
+description:
+  Set USB Language ID.
+
+  manufacturer:
+$ref: /schemas/types.yaml#/definitions/string
+description:
+  Set USB Manufacturer string (max. 62 characters long).
+
+  product:
+$ref: /schemas/types.yaml#/definitions/string
+description:
+  Set USB Product string (max. 62 characters long).
+
+  bus-powered:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Selects bus powered operation.
+
+  self-powered:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Selects self powered operation (default).
+
+  disable-hi-speed:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Disable USB Hi-Speed support.
+
+  multi-tt:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Selects multi-transaction-translator (default).
+
+  single-tt:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Selects single-transaction-translator.
+
+  disable-eop:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Disable End of Packet generation in full-speed mode.
+
+  ganged-sensing:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Select ganged over-current sense type in self-powered mode.
+
+  individual-sensing:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Select individual over-current sense type in self-powered mode (default).
+
+  ganged-port-switching:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Select ganged port power switching mode.
+
+  individual-port-switching:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Select individual port power switching mode (default).
+
+  dynamic-power-switching:
+$ref: /schemas/types.yaml#/definitions/flag
+description:
+  Enable auto-switching from self- to bus-powered operation if the local
+  power source is removed or unavailable.
+
+  oc-delay-ns:
+enum:
+  -