Re: [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy

2020-05-12 Thread Asutosh Das (asd)

On 5/12/2020 9:21 AM, Martin K. Petersen wrote:


Hi Asutosh!


Patchset looks good to me.

Reviewed-by: Asutosh Das 


When you want to approve an entire series, please respond to the cover
letter email. Otherwise the kernel.org tooling will only record the tag
for the individual patch you are responding to. In this case only patch
4 got tagged as reviewed in patchwork.



Hi Martin
Sure - I'll keep this in mind.

Thanks,
Asutosh

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project


Re: [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy

2020-05-12 Thread Martin K. Petersen


Hi Asutosh!

> Patchset looks good to me.
>
> Reviewed-by: Asutosh Das 

When you want to approve an entire series, please respond to the cover
letter email. Otherwise the kernel.org tooling will only record the tag
for the individual patch you are responding to. In this case only patch
4 got tagged as reviewed in patchwork.

-- 
Martin K. Petersen  Oracle Linux Engineering


Re: [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy

2020-05-11 Thread Asutosh Das (asd)

On 5/9/2020 2:37 AM, Stanley Chu wrote:

Change the WriteBooster policy to keep VCC on during
runtime suspend if available WriteBooster buffer is less
than 80%.

Signed-off-by: Stanley Chu 
---
  drivers/scsi/ufs/ufs-mediatek.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 56620f7d88ce..94e97701f456 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -271,6 +271,7 @@ static int ufs_mtk_init(struct ufs_hba *hba)
  
  	/* Enable WriteBooster */

hba->caps |= UFSHCD_CAP_WB_EN;
+   hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80);
  
  	/*

 * ufshcd_vops_init() is invoked after



Patchset looks good to me.

Reviewed-by: Asutosh Das 


--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project


[PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy

2020-05-09 Thread Stanley Chu
Change the WriteBooster policy to keep VCC on during
runtime suspend if available WriteBooster buffer is less
than 80%.

Signed-off-by: Stanley Chu 
---
 drivers/scsi/ufs/ufs-mediatek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 56620f7d88ce..94e97701f456 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -271,6 +271,7 @@ static int ufs_mtk_init(struct ufs_hba *hba)
 
/* Enable WriteBooster */
hba->caps |= UFSHCD_CAP_WB_EN;
+   hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80);
 
/*
 * ufshcd_vops_init() is invoked after
-- 
2.18.0