Re: [PATCH v2 4/6] arm64: dts: meson: sei510: Add minimal thermal zone

2019-08-05 Thread guillaume La Roque 
Hi Martin,


On 8/3/19 8:29 PM, Martin Blumenstingl wrote:
> Hi Guillaume,
>
> On Wed, Jul 31, 2019 at 5:36 PM Guillaume La Roque
>  wrote:
>> Add minimal thermal zone for DDR and CPU sensor
> so high DDR (controller?) temperatures will throttle Mali and high PLL
> temperatures will throttle the CPU?
> to get things started I'm fine with this, but I think it should be
> mentioned here

i will add in commit description

>
>> Signed-off-by: Guillaume La Roque 
>> ---
>>  .../boot/dts/amlogic/meson-g12a-sei510.dts| 56 +++
>>  1 file changed, 56 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts 
>> b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
>> index 979449968a5f..2c16a2cba0a3 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
>> @@ -10,6 +10,7 @@
>>  #include 
>>  #include 
>>  #include 
>> +#include 
>>
>>  / {
>> compatible = "seirobotics,sei510", "amlogic,g12a";
>> @@ -33,6 +34,53 @@
>> ethernet0 = 
>> };
>>
>> +   thermal-zones {
>> +   cpu-thermal {
>> +   polling-delay = <1000>;
>> +   polling-delay-passive = <100>;
>> +   thermal-sensors = <_temp>;
>> +
>> +   trips {
>> +   cpu_critical: cpu-critical {
>> +   temperature = <11>; /* 
>> millicelsius */
>> +   hysteresis = <2000>; /* millicelsius 
>> */
>> +   type = "critical";
>> +   };
>> +   };
>> +
>> +   cooling-maps {
>> +   map {
>> +   trip = <_critical>;
>> +   cooling-device = < 
>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +< 
>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +< 
>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
>> +< 
>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>> +   };
>> +   };
>> +   };
>> +
>> +   ddr-thermal {
>> +   polling-delay = <1000>;
>> +   polling-delay-passive = <100>;
>> +   thermal-sensors = <_temp>;
>> +
>> +   trips {
>> +   ddr_critical: ddr-critical {
>> +   temperature = <11>; /* 
>> millicelsius */
>> +   hysteresis = <2000>; /* millicelsius 
>> */
>> +   type = "critical";
>> +   };
>> +   };
>> +
>> +   cooling-maps {
>> +   map {
>> +   trip = <_critical>;
>> +   cooling-device = < 
>> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>> +   };
>> +   };
>> +   };
>> +   };
>> +
>> mono_dac: audio-codec-0 {
>> compatible = "maxim,max98357a";
>> #sound-dai-cells = <0>;
>> @@ -321,6 +369,7 @@
>> operating-points-v2 = <_opp_table>;
>> clocks = < CLKID_CPU_CLK>;
>> clock-latency = <5>;
>> +   #cooling-cells = <2>;
>>  };
>>
>>   {
>> @@ -328,6 +377,7 @@
>> operating-points-v2 = <_opp_table>;
>> clocks = < CLKID_CPU_CLK>;
>> clock-latency = <5>;
>> +   #cooling-cells = <2>;
>>  };
>>
>>   {
>> @@ -335,6 +385,7 @@
>> operating-points-v2 = <_opp_table>;
>> clocks = < CLKID_CPU_CLK>;
>> clock-latency = <5>;
>> +   #cooling-cells = <2>;
>>  };
>>
>>   {
>> @@ -342,6 +393,7 @@
>> operating-points-v2 = <_opp_table>;
>> clocks = < CLKID_CPU_CLK>;
>> clock-latency = <5>;
>> +   #cooling-cells = <2>;
>>  };
>>
>>  _vdac_port {
>> @@ -368,6 +420,10 @@
>> status = "okay";
>>  };
>>
>> + {
>> +   #cooling-cells = <2>;
>> +};
> is there something device-specific in this patch? I'm wondering
> whether we can move all of this go g12a.dtsi to simplify maintenance
> in the future

this is depending of each board. actually it's same on all

but if a new one have a fan this value should be different or not.


>
>
> Martin


thanks,

Guillaume

Re: [PATCH v2 4/6] arm64: dts: meson: sei510: Add minimal thermal zone

2019-08-03 Thread Martin Blumenstingl 
Hi Guillaume,

On Wed, Jul 31, 2019 at 5:36 PM Guillaume La Roque
 wrote:
>
> Add minimal thermal zone for DDR and CPU sensor
so high DDR (controller?) temperatures will throttle Mali and high PLL
temperatures will throttle the CPU?
to get things started I'm fine with this, but I think it should be
mentioned here

> Signed-off-by: Guillaume La Roque 
> ---
>  .../boot/dts/amlogic/meson-g12a-sei510.dts| 56 +++
>  1 file changed, 56 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts 
> b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> index 979449968a5f..2c16a2cba0a3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
> @@ -10,6 +10,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>
>  / {
> compatible = "seirobotics,sei510", "amlogic,g12a";
> @@ -33,6 +34,53 @@
> ethernet0 = 
> };
>
> +   thermal-zones {
> +   cpu-thermal {
> +   polling-delay = <1000>;
> +   polling-delay-passive = <100>;
> +   thermal-sensors = <_temp>;
> +
> +   trips {
> +   cpu_critical: cpu-critical {
> +   temperature = <11>; /* 
> millicelsius */
> +   hysteresis = <2000>; /* millicelsius 
> */
> +   type = "critical";
> +   };
> +   };
> +
> +   cooling-maps {
> +   map {
> +   trip = <_critical>;
> +   cooling-device = < 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +< 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +< 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> +< 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +   };
> +   };
> +   };
> +
> +   ddr-thermal {
> +   polling-delay = <1000>;
> +   polling-delay-passive = <100>;
> +   thermal-sensors = <_temp>;
> +
> +   trips {
> +   ddr_critical: ddr-critical {
> +   temperature = <11>; /* 
> millicelsius */
> +   hysteresis = <2000>; /* millicelsius 
> */
> +   type = "critical";
> +   };
> +   };
> +
> +   cooling-maps {
> +   map {
> +   trip = <_critical>;
> +   cooling-device = < 
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> +   };
> +   };
> +   };
> +   };
> +
> mono_dac: audio-codec-0 {
> compatible = "maxim,max98357a";
> #sound-dai-cells = <0>;
> @@ -321,6 +369,7 @@
> operating-points-v2 = <_opp_table>;
> clocks = < CLKID_CPU_CLK>;
> clock-latency = <5>;
> +   #cooling-cells = <2>;
>  };
>
>   {
> @@ -328,6 +377,7 @@
> operating-points-v2 = <_opp_table>;
> clocks = < CLKID_CPU_CLK>;
> clock-latency = <5>;
> +   #cooling-cells = <2>;
>  };
>
>   {
> @@ -335,6 +385,7 @@
> operating-points-v2 = <_opp_table>;
> clocks = < CLKID_CPU_CLK>;
> clock-latency = <5>;
> +   #cooling-cells = <2>;
>  };
>
>   {
> @@ -342,6 +393,7 @@
> operating-points-v2 = <_opp_table>;
> clocks = < CLKID_CPU_CLK>;
> clock-latency = <5>;
> +   #cooling-cells = <2>;
>  };
>
>  _vdac_port {
> @@ -368,6 +420,10 @@
> status = "okay";
>  };
>
> + {
> +   #cooling-cells = <2>;
> +};
is there something device-specific in this patch? I'm wondering
whether we can move all of this go g12a.dtsi to simplify maintenance
in the future


Martin

[PATCH v2 4/6] arm64: dts: meson: sei510: Add minimal thermal zone

2019-07-31 Thread Guillaume La Roque 
Add minimal thermal zone for DDR and CPU sensor

Signed-off-by: Guillaume La Roque 
---
 .../boot/dts/amlogic/meson-g12a-sei510.dts| 56 +++
 1 file changed, 56 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts 
b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
index 979449968a5f..2c16a2cba0a3 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-g12a-sei510.dts
@@ -10,6 +10,7 @@
 #include 
 #include 
 #include 
+#include 
 
 / {
compatible = "seirobotics,sei510", "amlogic,g12a";
@@ -33,6 +34,53 @@
ethernet0 = 
};
 
+   thermal-zones {
+   cpu-thermal {
+   polling-delay = <1000>;
+   polling-delay-passive = <100>;
+   thermal-sensors = <_temp>;
+
+   trips {
+   cpu_critical: cpu-critical {
+   temperature = <11>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "critical";
+   };
+   };
+
+   cooling-maps {
+   map {
+   trip = <_critical>;
+   cooling-device = < 
THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+< 
THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+< 
THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
+< 
THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+   };
+   };
+   };
+
+   ddr-thermal {
+   polling-delay = <1000>;
+   polling-delay-passive = <100>;
+   thermal-sensors = <_temp>;
+
+   trips {
+   ddr_critical: ddr-critical {
+   temperature = <11>; /* millicelsius 
*/
+   hysteresis = <2000>; /* millicelsius */
+   type = "critical";
+   };
+   };
+
+   cooling-maps {
+   map {
+   trip = <_critical>;
+   cooling-device = < 
THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
+   };
+   };
+   };
+   };
+
mono_dac: audio-codec-0 {
compatible = "maxim,max98357a";
#sound-dai-cells = <0>;
@@ -321,6 +369,7 @@
operating-points-v2 = <_opp_table>;
clocks = < CLKID_CPU_CLK>;
clock-latency = <5>;
+   #cooling-cells = <2>;
 };
 
  {
@@ -328,6 +377,7 @@
operating-points-v2 = <_opp_table>;
clocks = < CLKID_CPU_CLK>;
clock-latency = <5>;
+   #cooling-cells = <2>;
 };
 
  {
@@ -335,6 +385,7 @@
operating-points-v2 = <_opp_table>;
clocks = < CLKID_CPU_CLK>;
clock-latency = <5>;
+   #cooling-cells = <2>;
 };
 
  {
@@ -342,6 +393,7 @@
operating-points-v2 = <_opp_table>;
clocks = < CLKID_CPU_CLK>;
clock-latency = <5>;
+   #cooling-cells = <2>;
 };
 
 _vdac_port {
@@ -368,6 +420,10 @@
status = "okay";
 };
 
+ {
+   #cooling-cells = <2>;
+};
+
 _tx {
status = "okay";
pinctrl-0 = <_hpd_pins>, <_ddc_pins>;
-- 
2.17.1