Re: [PATCH v2 5/6] gpu: host1x: Fix incorrect comment for channel_request
On 05.09.2017 11:10, Mikko Perttunen wrote: > This function actually doesn't sleep in the version that was merged. > > Signed-off-by: Mikko Perttunen > --- > drivers/gpu/host1x/channel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/host1x/channel.c b/drivers/gpu/host1x/channel.c > index db9b91d1384c..2fb93c27c1d9 100644 > --- a/drivers/gpu/host1x/channel.c > +++ b/drivers/gpu/host1x/channel.c > @@ -128,8 +128,7 @@ static struct host1x_channel > *acquire_unused_channel(struct host1x *host) > * host1x_channel_request() - Allocate a channel > * @device: Host1x unit this channel will be used to send commands to > * > - * Allocates a new host1x channel for @device. If there are no free channels, > - * this will sleep until one becomes available. May return NULL if CDMA > + * Allocates a new host1x channel for @device. May return NULL if CDMA > * initialization fails. > */ > struct host1x_channel *host1x_channel_request(struct device *dev) > Reviewed-by: Dmitry Osipenko -- Dmitry
[PATCH v2 5/6] gpu: host1x: Fix incorrect comment for channel_request
This function actually doesn't sleep in the version that was merged. Signed-off-by: Mikko Perttunen --- drivers/gpu/host1x/channel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/host1x/channel.c b/drivers/gpu/host1x/channel.c index db9b91d1384c..2fb93c27c1d9 100644 --- a/drivers/gpu/host1x/channel.c +++ b/drivers/gpu/host1x/channel.c @@ -128,8 +128,7 @@ static struct host1x_channel *acquire_unused_channel(struct host1x *host) * host1x_channel_request() - Allocate a channel * @device: Host1x unit this channel will be used to send commands to * - * Allocates a new host1x channel for @device. If there are no free channels, - * this will sleep until one becomes available. May return NULL if CDMA + * Allocates a new host1x channel for @device. May return NULL if CDMA * initialization fails. */ struct host1x_channel *host1x_channel_request(struct device *dev) -- 2.14.1
