Re: [PATCH v2 6/6] staging/fwserial: Drop suggestion for helper fn integration
> On Dec 15 Peter Hurley wrote: > > The firewire core does not require or want the suggested helper fns; > > drop suggestion from TODO file. PS, the patch and the other five look good to me. -- Stefan Richter -=-===-- ==-- - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 6/6] staging/fwserial: Drop suggestion for helper fn integration
On Dec 15 Peter Hurley wrote: > The firewire core does not require or want the suggested helper fns; > drop suggestion from TODO file. It's not about the core, but about what the highlevel drivers need. (I.e. protocol drivers and some higherlevel parts of the core, e.g. the userspace driver interface.) If it is something which two or more drivers use, it goes into the core. (Or into a library, as Clemens did with snd-firewire-lib.) If it is something which needs assistance by the lowlevel driver, it goes into the core or passes through the core, regardless whether one or more protocol drivers need it. (Example: Physical DMA filtering for the SBP-2 initiator driver.) If it is something very complicated and 1394 architecture specific, but still only needed by one highlevel driver, I for one am more comfortable with leaving this in the respective driver rather than moving this into the core. The packet payload calculation is a 1394 architecture arcanum and is needed in on form or another in more than one driver (firewire-net, -sbp2, and now fwserial). But as discussed, what they precisely need in the end differs to a degree that leaves nothing substantial to share. [That's too many words about a two- or three-line piece of code; but on the on the other hand it is a generally relevant consideration whenever new functionality is to be added somewhere in the driver stack.] -- Stefan Richter -=-===-- ==-- - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 6/6] staging/fwserial: Drop suggestion for helper fn integration
On Dec 15 Peter Hurley wrote: The firewire core does not require or want the suggested helper fns; drop suggestion from TODO file. It's not about the core, but about what the highlevel drivers need. (I.e. protocol drivers and some higherlevel parts of the core, e.g. the userspace driver interface.) If it is something which two or more drivers use, it goes into the core. (Or into a library, as Clemens did with snd-firewire-lib.) If it is something which needs assistance by the lowlevel driver, it goes into the core or passes through the core, regardless whether one or more protocol drivers need it. (Example: Physical DMA filtering for the SBP-2 initiator driver.) If it is something very complicated and 1394 architecture specific, but still only needed by one highlevel driver, I for one am more comfortable with leaving this in the respective driver rather than moving this into the core. The packet payload calculation is a 1394 architecture arcanum and is needed in on form or another in more than one driver (firewire-net, -sbp2, and now fwserial). But as discussed, what they precisely need in the end differs to a degree that leaves nothing substantial to share. [That's too many words about a two- or three-line piece of code; but on the on the other hand it is a generally relevant consideration whenever new functionality is to be added somewhere in the driver stack.] -- Stefan Richter -=-===-- ==-- - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 6/6] staging/fwserial: Drop suggestion for helper fn integration
On Dec 15 Peter Hurley wrote: The firewire core does not require or want the suggested helper fns; drop suggestion from TODO file. PS, the patch and the other five look good to me. -- Stefan Richter -=-===-- ==-- - http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 6/6] staging/fwserial: Drop suggestion for helper fn integration
The firewire core does not require or want the suggested helper fns; drop suggestion from TODO file. Signed-off-by: Peter Hurley --- drivers/staging/fwserial/TODO | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/fwserial/TODO b/drivers/staging/fwserial/TODO index 8dae8fb..dc61d97 100644 --- a/drivers/staging/fwserial/TODO +++ b/drivers/staging/fwserial/TODO @@ -12,8 +12,6 @@ TODOs prior to this driver moving out of staging 1. This driver uses the same unregistered vendor id that the firewire core does (0xd00d1e). Perhaps this could be exposed as a define in firewire.h? -3. Maybe device_max_receive() and link_speed_to_max_payload() should be - taken up by the firewire core? -- Issues with TTY core -- 1. Hack for alternate device name scheme -- 1.8.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 6/6] staging/fwserial: Drop suggestion for helper fn integration
The firewire core does not require or want the suggested helper fns; drop suggestion from TODO file. Signed-off-by: Peter Hurley pe...@hurleysoftware.com --- drivers/staging/fwserial/TODO | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/fwserial/TODO b/drivers/staging/fwserial/TODO index 8dae8fb..dc61d97 100644 --- a/drivers/staging/fwserial/TODO +++ b/drivers/staging/fwserial/TODO @@ -12,8 +12,6 @@ TODOs prior to this driver moving out of staging 1. This driver uses the same unregistered vendor id that the firewire core does (0xd00d1e). Perhaps this could be exposed as a define in firewire.h? -3. Maybe device_max_receive() and link_speed_to_max_payload() should be - taken up by the firewire core? -- Issues with TTY core -- 1. Hack for alternate device name scheme -- 1.8.0.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
