Re: [PATCH v2 7/7] arm64: dts: mt8183: Add krane-sku176 board

[Hsin-Yi Wang]

On Thu, Jun 25, 2020 at 6:18 PM Enric Balletbo i Serra
 wrote:
>
> Also known as the Lenovo IdeaPad Duet Chromebook.
>
> There are different krane boards with shared resources, hence a
> mt8183-kukui-krane.dtsi was created for easily introduce future new
> boards. The same happens with the baseboard codenamed kukui where
> different variants, apart from kukui variant can take advantage of the
> shared resources.
>
> Signed-off-by: Ben Ho 
> [originally created by Ben Ho but adapted and ported to mainline]
> Signed-off-by: Enric Balletbo i Serra 
Tested-by: Hsin-Yi Wang 
> ---
>
> Changes in v2:
> - Move adding #phy-cells out of this patch. (Matthias Brugger)
>
>  arch/arm64/boot/dts/mediatek/Makefile |   1 +
>  .../mediatek/mt8183-kukui-krane-sku176.dts|  18 +
>  .../boot/dts/mediatek/mt8183-kukui-krane.dtsi | 343 
>  .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 788 ++
>  4 files changed, 1150 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
>  create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
> b/arch/arm64/boot/dts/mediatek/Makefile
> index 848218f55bc1d..708fc60fa589a 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -12,4 +12,5 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb
>  dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts 
> b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
> new file mode 100644
> index 0..47113e275cb52
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2019 Google LLC
> + *
> + * Device-tree for Krane sku176.
> + *
> + * SKU is a 8-bit value (0xb0 == 176):
> + *  - Bits 7..4: Panel ID: 0xb (BOE)
> + *  - Bits 3..0: SKU ID:   0x0 (default)
> + */
> +
> +/dts-v1/;
> +#include "mt8183-kukui-krane.dtsi"
> +
> +/ {
> +   model = "MediaTek krane sku176 board";
> +   compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183";
> +};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> new file mode 100644
> index 0..fbc471ccf805f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> @@ -0,0 +1,343 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2019 Google LLC
> + */
> +
> +#include "mt8183-kukui.dtsi"
> +
> +/ {
> +   ppvarn_lcd: ppvarn-lcd {
> +   compatible = "regulator-fixed";
> +   regulator-name = "ppvarn_lcd";
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_lcd_en>;
> +
> +   enable-active-high;
> +
> +   gpio = < 66 GPIO_ACTIVE_HIGH>;
> +   };
> +
> +   ppvarp_lcd: ppvarp-lcd {
> +   compatible = "regulator-fixed";
> +   regulator-name = "ppvarp_lcd";
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_lcd_en>;
> +
> +   enable-active-high;
> +
> +   gpio = < 166 GPIO_ACTIVE_HIGH>;
> +   };
> +
> +   pp1800_lcd: pp1800-lcd {
> +   compatible = "regulator-fixed";
> +   regulator-name = "pp1800_lcd";
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_lcd_en>;
> +
> +   enable-active-high;
> +
> +   gpio = < 36 GPIO_ACTIVE_HIGH>;
> +   };
> +};
> +
> + {
> +   firmware-name = "nvm_00440302_i2s_eu.bin";
> +};
> +
> + {
> +   status = "okay";
> +
> +   touchscreen4: touchscreen@5d {
> +   compatible = "hid-over-i2c";
> +   reg = <0x5d>;
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_touch>;
> +
> +   interrupt-parent = <>;
> +   interrupts = <155 IRQ_TYPE_EDGE_FALLING>;
> +
> +   post-power-on-delay-ms = <10>;
> +   hid-descr-addr = <0x0001>;
> +   };
> +};
> +
> +_vcama2_reg {
> +   regulator-min-microvolt = <280>;
> +   regulator-max-microvolt = <280>;
> +};
> +
> + {
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_pins>;
> +   status = "okay";
> +   clock-frequency = <40>;
> +
> +   eeprom@58 {
> +   compatible = "atmel,24c32";
> +   reg = <0x58>;
> +   pagesize = <32>;
> +   };
> +};
> +
> + {
> +   pinctrl-names = "default";
> +   pinctrl-0 = <_pins>;
> +

[PATCH v2 7/7] arm64: dts: mt8183: Add krane-sku176 board

[Enric Balletbo i Serra]

Also known as the Lenovo IdeaPad Duet Chromebook.

There are different krane boards with shared resources, hence a
mt8183-kukui-krane.dtsi was created for easily introduce future new
boards. The same happens with the baseboard codenamed kukui where
different variants, apart from kukui variant can take advantage of the
shared resources.

Signed-off-by: Ben Ho 
[originally created by Ben Ho but adapted and ported to mainline]
Signed-off-by: Enric Balletbo i Serra 
---

Changes in v2:
- Move adding #phy-cells out of this patch. (Matthias Brugger)

 arch/arm64/boot/dts/mediatek/Makefile |   1 +
 .../mediatek/mt8183-kukui-krane-sku176.dts|  18 +
 .../boot/dts/mediatek/mt8183-kukui-krane.dtsi | 343 
 .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 788 ++
 4 files changed, 1150 insertions(+)
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
 create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi

diff --git a/arch/arm64/boot/dts/mediatek/Makefile 
b/arch/arm64/boot/dts/mediatek/Makefile
index 848218f55bc1d..708fc60fa589a 100644
--- a/arch/arm64/boot/dts/mediatek/Makefile
+++ b/arch/arm64/boot/dts/mediatek/Makefile
@@ -12,4 +12,5 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-elm-hana-rev7.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8173-evb.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-evb.dtb
+dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb
 dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts 
b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
new file mode 100644
index 0..47113e275cb52
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane-sku176.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2019 Google LLC
+ *
+ * Device-tree for Krane sku176.
+ *
+ * SKU is a 8-bit value (0xb0 == 176):
+ *  - Bits 7..4: Panel ID: 0xb (BOE)
+ *  - Bits 3..0: SKU ID:   0x0 (default)
+ */
+
+/dts-v1/;
+#include "mt8183-kukui-krane.dtsi"
+
+/ {
+   model = "MediaTek krane sku176 board";
+   compatible = "google,krane-sku176", "google,krane", "mediatek,mt8183";
+};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi 
b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
new file mode 100644
index 0..fbc471ccf805f
--- /dev/null
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
@@ -0,0 +1,343 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+/*
+ * Copyright 2019 Google LLC
+ */
+
+#include "mt8183-kukui.dtsi"
+
+/ {
+   ppvarn_lcd: ppvarn-lcd {
+   compatible = "regulator-fixed";
+   regulator-name = "ppvarn_lcd";
+   pinctrl-names = "default";
+   pinctrl-0 = <_lcd_en>;
+
+   enable-active-high;
+
+   gpio = < 66 GPIO_ACTIVE_HIGH>;
+   };
+
+   ppvarp_lcd: ppvarp-lcd {
+   compatible = "regulator-fixed";
+   regulator-name = "ppvarp_lcd";
+   pinctrl-names = "default";
+   pinctrl-0 = <_lcd_en>;
+
+   enable-active-high;
+
+   gpio = < 166 GPIO_ACTIVE_HIGH>;
+   };
+
+   pp1800_lcd: pp1800-lcd {
+   compatible = "regulator-fixed";
+   regulator-name = "pp1800_lcd";
+   pinctrl-names = "default";
+   pinctrl-0 = <_lcd_en>;
+
+   enable-active-high;
+
+   gpio = < 36 GPIO_ACTIVE_HIGH>;
+   };
+};
+
+ {
+   firmware-name = "nvm_00440302_i2s_eu.bin";
+};
+
+ {
+   status = "okay";
+
+   touchscreen4: touchscreen@5d {
+   compatible = "hid-over-i2c";
+   reg = <0x5d>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_touch>;
+
+   interrupt-parent = <>;
+   interrupts = <155 IRQ_TYPE_EDGE_FALLING>;
+
+   post-power-on-delay-ms = <10>;
+   hid-descr-addr = <0x0001>;
+   };
+};
+
+_vcama2_reg {
+   regulator-min-microvolt = <280>;
+   regulator-max-microvolt = <280>;
+};
+
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins>;
+   status = "okay";
+   clock-frequency = <40>;
+
+   eeprom@58 {
+   compatible = "atmel,24c32";
+   reg = <0x58>;
+   pagesize = <32>;
+   };
+};
+
+ {
+   pinctrl-names = "default";
+   pinctrl-0 = <_pins>;
+   status = "okay";
+   clock-frequency = <40>;
+
+   eeprom@54 {
+   compatible = "atmel,24c32";
+   reg = <0x54>;
+   pagesize = <32>;
+   };
+};
+
+ {
+   /* 192 lines */
+   gpio-line-names =
+   "SPI_AP_EC_CS_L",
+   "SPI_AP_EC_MOSI",
+   "SPI_AP_EC_CLK",
+   "I2S3_DO",
+