Re: [PATCH v2 7/8] cpufreq: schedutil: Replace default_attrs field with groups

[Peter Zijlstra]

On Mon, Apr 01, 2019 at 10:51:53PM -0400, Kimberly Brown wrote:
> The kobj_type default_attrs field is being replaced by the
> default_groups field. Replace sugov_tunables_ktype's default_attrs field
> with default groups. Change "sugov_attributes" to "sugov_attrs" and use
> the ATTRIBUTE_GROUPS macro to create sugov_groups.
> 
> This patch was tested by setting the scaling governor to schedutil and
> verifying that the sysfs files for the attributes in the default groups
> were created.
> 
> Signed-off-by: Kimberly Brown 

Acked-by: Peter Zijlstra (Intel) 

Please route the patch as is most convenient.

> ---
>  kernel/sched/cpufreq_schedutil.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/sched/cpufreq_schedutil.c 
> b/kernel/sched/cpufreq_schedutil.c
> index 5c41ea367422..148b60c8993d 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -598,13 +598,14 @@ rate_limit_us_store(struct gov_attr_set *attr_set, 
> const char *buf, size_t count
>  
>  static struct governor_attr rate_limit_us = __ATTR_RW(rate_limit_us);
>  
> -static struct attribute *sugov_attributes[] = {
> +static struct attribute *sugov_attrs[] = {
>   &rate_limit_us.attr,
>   NULL
>  };
> +ATTRIBUTE_GROUPS(sugov);
>  
>  static struct kobj_type sugov_tunables_ktype = {
> - .default_attrs = sugov_attributes,
> + .default_groups = sugov_groups,
>   .sysfs_ops = &governor_sysfs_ops,
>  };
>  
> -- 
> 2.17.1
> 

Re: [PATCH v2 7/8] cpufreq: schedutil: Replace default_attrs field with groups

[Rafael J. Wysocki]

On Tue, Apr 2, 2019 at 4:51 AM Kimberly Brown  wrote:
>
> The kobj_type default_attrs field is being replaced by the
> default_groups field. Replace sugov_tunables_ktype's default_attrs field
> with default groups. Change "sugov_attributes" to "sugov_attrs" and use
> the ATTRIBUTE_GROUPS macro to create sugov_groups.
>
> This patch was tested by setting the scaling governor to schedutil and
> verifying that the sysfs files for the attributes in the default groups
> were created.
>
> Signed-off-by: Kimberly Brown 

Ackedy-by: Rafael J. Wysocki 

> ---
>  kernel/sched/cpufreq_schedutil.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/cpufreq_schedutil.c 
> b/kernel/sched/cpufreq_schedutil.c
> index 5c41ea367422..148b60c8993d 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -598,13 +598,14 @@ rate_limit_us_store(struct gov_attr_set *attr_set, 
> const char *buf, size_t count
>
>  static struct governor_attr rate_limit_us = __ATTR_RW(rate_limit_us);
>
> -static struct attribute *sugov_attributes[] = {
> +static struct attribute *sugov_attrs[] = {
> &rate_limit_us.attr,
> NULL
>  };
> +ATTRIBUTE_GROUPS(sugov);
>
>  static struct kobj_type sugov_tunables_ktype = {
> -   .default_attrs = sugov_attributes,
> +   .default_groups = sugov_groups,
> .sysfs_ops = &governor_sysfs_ops,
>  };
>
> --
> 2.17.1
>

[PATCH v2 7/8] cpufreq: schedutil: Replace default_attrs field with groups

[Kimberly Brown]

The kobj_type default_attrs field is being replaced by the
default_groups field. Replace sugov_tunables_ktype's default_attrs field
with default groups. Change "sugov_attributes" to "sugov_attrs" and use
the ATTRIBUTE_GROUPS macro to create sugov_groups.

This patch was tested by setting the scaling governor to schedutil and
verifying that the sysfs files for the attributes in the default groups
were created.

Signed-off-by: Kimberly Brown 
---
 kernel/sched/cpufreq_schedutil.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 5c41ea367422..148b60c8993d 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -598,13 +598,14 @@ rate_limit_us_store(struct gov_attr_set *attr_set, const 
char *buf, size_t count
 
 static struct governor_attr rate_limit_us = __ATTR_RW(rate_limit_us);
 
-static struct attribute *sugov_attributes[] = {
+static struct attribute *sugov_attrs[] = {
&rate_limit_us.attr,
NULL
 };
+ATTRIBUTE_GROUPS(sugov);
 
 static struct kobj_type sugov_tunables_ktype = {
-   .default_attrs = sugov_attributes,
+   .default_groups = sugov_groups,
.sysfs_ops = &governor_sysfs_ops,
 };
 
-- 
2.17.1