Re: [PATCH v3] clk: shmobile: mstp: Fix the is_enabled() operation
Hi Magnus,
On Tue, May 27, 2014 at 3:02 AM, Magnus Damm wrote:
> On Fri, May 23, 2014 at 3:02 AM, Geert Uytterhoeven
> wrote:
>> From: Laurent Pinchart
>>
>> The MSTP[SC]R registers have clock stop bits, not clock enable bits. The
>> bit value should thus be inverted in the is_enabled() operation.
>>
>> Signed-off-by: Laurent Pinchart
>> Signed-off-by: Geert Uytterhoeven
>> Cc: Mike Turquette
>> ---
>> v3:
>> - This depends on commit 3c90c55dcde745bed81f6447f24ba96bda43d984
>> ("drivers: sh: compile drivers/sh/pm_runtime.c if
>> ARCH_SHMOBILE_MULTI"), which has entered mainline in v3.15-rc6.
>
> Thanks for resubmitting this fix. Do you intend to get this included
> in v3.15 (seems unlikely) or is your target v3.16?
3.16 is OK. The only ill effect is that some clocks may be enabled,
while they're
not needed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] clk: shmobile: mstp: Fix the is_enabled() operation
Hi Magnus,
On Tue, May 27, 2014 at 3:02 AM, Magnus Damm magnus.d...@gmail.com wrote:
On Fri, May 23, 2014 at 3:02 AM, Geert Uytterhoeven
geert+rene...@glider.be wrote:
From: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
The MSTP[SC]R registers have clock stop bits, not clock enable bits. The
bit value should thus be inverted in the is_enabled() operation.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be
Cc: Mike Turquette mturque...@linaro.org
---
v3:
- This depends on commit 3c90c55dcde745bed81f6447f24ba96bda43d984
(drivers: sh: compile drivers/sh/pm_runtime.c if
ARCH_SHMOBILE_MULTI), which has entered mainline in v3.15-rc6.
Thanks for resubmitting this fix. Do you intend to get this included
in v3.15 (seems unlikely) or is your target v3.16?
3.16 is OK. The only ill effect is that some clocks may be enabled,
while they're
not needed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] clk: shmobile: mstp: Fix the is_enabled() operation
On Fri, May 23, 2014 at 3:02 AM, Geert Uytterhoeven
wrote:
> From: Laurent Pinchart
>
> The MSTP[SC]R registers have clock stop bits, not clock enable bits. The
> bit value should thus be inverted in the is_enabled() operation.
>
> Signed-off-by: Laurent Pinchart
> Signed-off-by: Geert Uytterhoeven
> Cc: Mike Turquette
> ---
> v3:
> - This depends on commit 3c90c55dcde745bed81f6447f24ba96bda43d984
> ("drivers: sh: compile drivers/sh/pm_runtime.c if
> ARCH_SHMOBILE_MULTI"), which has entered mainline in v3.15-rc6.
Hi Geert,
Thanks for resubmitting this fix. Do you intend to get this included
in v3.15 (seems unlikely) or is your target v3.16?
Cheers,
/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3] clk: shmobile: mstp: Fix the is_enabled() operation
On Fri, May 23, 2014 at 3:02 AM, Geert Uytterhoeven geert+rene...@glider.be wrote: From: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com The MSTP[SC]R registers have clock stop bits, not clock enable bits. The bit value should thus be inverted in the is_enabled() operation. Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Cc: Mike Turquette mturque...@linaro.org --- v3: - This depends on commit 3c90c55dcde745bed81f6447f24ba96bda43d984 (drivers: sh: compile drivers/sh/pm_runtime.c if ARCH_SHMOBILE_MULTI), which has entered mainline in v3.15-rc6. Hi Geert, Thanks for resubmitting this fix. Do you intend to get this included in v3.15 (seems unlikely) or is your target v3.16? Cheers, / magnus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3] clk: shmobile: mstp: Fix the is_enabled() operation
From: Laurent Pinchart
The MSTP[SC]R registers have clock stop bits, not clock enable bits. The
bit value should thus be inverted in the is_enabled() operation.
Signed-off-by: Laurent Pinchart
Signed-off-by: Geert Uytterhoeven
Cc: Mike Turquette
---
v3:
- This depends on commit 3c90c55dcde745bed81f6447f24ba96bda43d984
("drivers: sh: compile drivers/sh/pm_runtime.c if
ARCH_SHMOBILE_MULTI"), which has entered mainline in v3.15-rc6.
v2:
- New
---
drivers/clk/shmobile/clk-mstp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/shmobile/clk-mstp.c b/drivers/clk/shmobile/clk-mstp.c
index 1f6324e29a80..2d2fe773ac81 100644
--- a/drivers/clk/shmobile/clk-mstp.c
+++ b/drivers/clk/shmobile/clk-mstp.c
@@ -112,7 +112,7 @@ static int cpg_mstp_clock_is_enabled(struct clk_hw *hw)
else
value = clk_readl(group->smstpcr);
- return !!(value & BIT(clock->bit_index));
+ return !(value & BIT(clock->bit_index));
}
static const struct clk_ops cpg_mstp_clock_ops = {
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3] clk: shmobile: mstp: Fix the is_enabled() operation
From: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
The MSTP[SC]R registers have clock stop bits, not clock enable bits. The
bit value should thus be inverted in the is_enabled() operation.
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be
Cc: Mike Turquette mturque...@linaro.org
---
v3:
- This depends on commit 3c90c55dcde745bed81f6447f24ba96bda43d984
(drivers: sh: compile drivers/sh/pm_runtime.c if
ARCH_SHMOBILE_MULTI), which has entered mainline in v3.15-rc6.
v2:
- New
---
drivers/clk/shmobile/clk-mstp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/shmobile/clk-mstp.c b/drivers/clk/shmobile/clk-mstp.c
index 1f6324e29a80..2d2fe773ac81 100644
--- a/drivers/clk/shmobile/clk-mstp.c
+++ b/drivers/clk/shmobile/clk-mstp.c
@@ -112,7 +112,7 @@ static int cpg_mstp_clock_is_enabled(struct clk_hw *hw)
else
value = clk_readl(group-smstpcr);
- return !!(value BIT(clock-bit_index));
+ return !(value BIT(clock-bit_index));
}
static const struct clk_ops cpg_mstp_clock_ops = {
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
