Re: [PATCH v3] tools: iio: Send error messages to stderr
Cristina Opriceana schrieb am 13.07.2015 um 15:33:
> This patch intends to make some cleanup and send printf
> error messages to stderr. The changes were performed with coccinelle
> for failure messages and manual for other cases, such as wrong usage
> messages.
>
Looking very good so far. Two off-by-one indentation issues spotted however
(checkpatch didn't spot at least the first one), but after fixing you can
add my
Reviewed-by: Hartmut Knaack
> Signed-off-by: Cristina Opriceana
> ---
> Changes since v2:
> - merge all replacements in one commit
>
> tools/iio/generic_buffer.c| 23 +++-
> tools/iio/iio_event_monitor.c | 14 ++---
> tools/iio/iio_utils.c | 49
> +--
> tools/iio/lsiio.c | 2 +-
> 4 files changed, 50 insertions(+), 38 deletions(-)
>
> diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
> index 9535c2d..249858a 100644
> --- a/tools/iio/generic_buffer.c
> +++ b/tools/iio/generic_buffer.c
> @@ -193,7 +193,7 @@ void process_scan(char *data,
>
> void print_usage(void)
> {
> - printf("Usage: generic_buffer [options]...\n"
> + fprintf(stderr, "Usage: generic_buffer [options]...\n"
> "Capture, convert and output data from IIO device buffer\n"
> " -c Do n conversions\n"
> " -e Disable wait for event (new data)\n"
These lines should be moved one space to the right, as well.
<...>
> diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c
> index e177f40..15bd663 100644
> --- a/tools/iio/iio_utils.c
> +++ b/tools/iio/iio_utils.c
<...>
> @@ -800,8 +808,9 @@ static int _write_sysfs_string(const char *filename,
> const char *basedir,
> }
>
> if (strcmp(temp, val) != 0) {
> - printf("Possible failure in string write of %s "
> -"Should be %s written to %s/%s\n", temp, val,
> + fprintf(stderr,
> + "Possible failure in string write of %s "
> + "Should be %s written to %s/%s\n", temp, val,
> basedir, filename);
And this is the other instance.
> ret = -1;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3] tools: iio: Send error messages to stderr
This patch intends to make some cleanup and send printf
error messages to stderr. The changes were performed with coccinelle
for failure messages and manual for other cases, such as wrong usage
messages.
Signed-off-by: Cristina Opriceana
---
Changes since v2:
- merge all replacements in one commit
tools/iio/generic_buffer.c| 23 +++-
tools/iio/iio_event_monitor.c | 14 ++---
tools/iio/iio_utils.c | 49 +--
tools/iio/lsiio.c | 2 +-
4 files changed, 50 insertions(+), 38 deletions(-)
diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
index 9535c2d..249858a 100644
--- a/tools/iio/generic_buffer.c
+++ b/tools/iio/generic_buffer.c
@@ -193,7 +193,7 @@ void process_scan(char *data,
void print_usage(void)
{
- printf("Usage: generic_buffer [options]...\n"
+ fprintf(stderr, "Usage: generic_buffer [options]...\n"
"Capture, convert and output data from IIO device buffer\n"
" -c Do n conversions\n"
" -e Disable wait for event (new data)\n"
@@ -271,7 +271,7 @@ int main(int argc, char **argv)
}
if (!device_name) {
- printf("Device name not set\n");
+ fprintf(stderr, "Device name not set\n");
print_usage();
return -1;
}
@@ -279,7 +279,7 @@ int main(int argc, char **argv)
/* Find the device requested */
dev_num = find_type_by_name(device_name, "iio:device");
if (dev_num < 0) {
- printf("Failed to find the %s\n", device_name);
+ fprintf(stderr, "Failed to find the %s\n", device_name);
return dev_num;
}
@@ -307,7 +307,8 @@ int main(int argc, char **argv)
/* Verify the trigger exists */
trig_num = find_type_by_name(trigger_name, "trigger");
if (trig_num < 0) {
- printf("Failed to find the trigger %s\n", trigger_name);
+ fprintf(stderr, "Failed to find the trigger %s\n",
+ trigger_name);
ret = trig_num;
goto error_free_triggername;
}
@@ -323,8 +324,8 @@ int main(int argc, char **argv)
*/
ret = build_channel_array(dev_dir_name, , _channels);
if (ret) {
- printf("Problem reading scan element information\n");
- printf("diag %s\n", dev_dir_name);
+ fprintf(stderr, "Problem reading scan element information\n"
+ "diag %s\n", dev_dir_name);
goto error_free_triggername;
}
@@ -350,7 +351,8 @@ int main(int argc, char **argv)
dev_dir_name,
trigger_name);
if (ret < 0) {
- printf("Failed to write current_trigger file\n");
+ fprintf(stderr,
+ "Failed to write current_trigger file\n");
goto error_free_buf_dir_name;
}
}
@@ -382,7 +384,7 @@ int main(int argc, char **argv)
fp = open(buffer_access, O_RDONLY | O_NONBLOCK);
if (fp == -1) { /* TODO: If it isn't there make the node */
ret = -errno;
- printf("Failed to open %s\n", buffer_access);
+ fprintf(stderr, "Failed to open %s\n", buffer_access);
goto error_free_buffer_access;
}
@@ -410,7 +412,7 @@ int main(int argc, char **argv)
read_size = read(fp, data, toread * scan_size);
if (read_size < 0) {
if (errno == EAGAIN) {
- printf("nothing available\n");
+ fprintf(stderr, "nothing available\n");
continue;
} else {
break;
@@ -431,7 +433,8 @@ int main(int argc, char **argv)
ret = write_sysfs_string("trigger/current_trigger",
dev_dir_name, "NULL");
if (ret < 0)
- printf("Failed to write to %s\n", dev_dir_name);
+ fprintf(stderr, "Failed to write to %s\n",
+ dev_dir_name);
error_close_buffer_access:
if (close(fp) == -1)
diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
index 9ee1959..cd3fd41 100644
--- a/tools/iio/iio_event_monitor.c
+++ b/tools/iio/iio_event_monitor.c
@@ -215,8 +215,8 @@ static void print_event(struct iio_event_data *event)
bool diff = IIO_EVENT_CODE_EXTRACT_DIFF(event->id);
if (!event_is_known(event)) {
- printf("Unknown event: time: %lld, id: %llx\n",
- event->timestamp, event->id);
+
[PATCH v3] tools: iio: Send error messages to stderr
This patch intends to make some cleanup and send printf
error messages to stderr. The changes were performed with coccinelle
for failure messages and manual for other cases, such as wrong usage
messages.
Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com
---
Changes since v2:
- merge all replacements in one commit
tools/iio/generic_buffer.c| 23 +++-
tools/iio/iio_event_monitor.c | 14 ++---
tools/iio/iio_utils.c | 49 +--
tools/iio/lsiio.c | 2 +-
4 files changed, 50 insertions(+), 38 deletions(-)
diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
index 9535c2d..249858a 100644
--- a/tools/iio/generic_buffer.c
+++ b/tools/iio/generic_buffer.c
@@ -193,7 +193,7 @@ void process_scan(char *data,
void print_usage(void)
{
- printf(Usage: generic_buffer [options]...\n
+ fprintf(stderr, Usage: generic_buffer [options]...\n
Capture, convert and output data from IIO device buffer\n
-c n Do n conversions\n
-e Disable wait for event (new data)\n
@@ -271,7 +271,7 @@ int main(int argc, char **argv)
}
if (!device_name) {
- printf(Device name not set\n);
+ fprintf(stderr, Device name not set\n);
print_usage();
return -1;
}
@@ -279,7 +279,7 @@ int main(int argc, char **argv)
/* Find the device requested */
dev_num = find_type_by_name(device_name, iio:device);
if (dev_num 0) {
- printf(Failed to find the %s\n, device_name);
+ fprintf(stderr, Failed to find the %s\n, device_name);
return dev_num;
}
@@ -307,7 +307,8 @@ int main(int argc, char **argv)
/* Verify the trigger exists */
trig_num = find_type_by_name(trigger_name, trigger);
if (trig_num 0) {
- printf(Failed to find the trigger %s\n, trigger_name);
+ fprintf(stderr, Failed to find the trigger %s\n,
+ trigger_name);
ret = trig_num;
goto error_free_triggername;
}
@@ -323,8 +324,8 @@ int main(int argc, char **argv)
*/
ret = build_channel_array(dev_dir_name, channels, num_channels);
if (ret) {
- printf(Problem reading scan element information\n);
- printf(diag %s\n, dev_dir_name);
+ fprintf(stderr, Problem reading scan element information\n
+ diag %s\n, dev_dir_name);
goto error_free_triggername;
}
@@ -350,7 +351,8 @@ int main(int argc, char **argv)
dev_dir_name,
trigger_name);
if (ret 0) {
- printf(Failed to write current_trigger file\n);
+ fprintf(stderr,
+ Failed to write current_trigger file\n);
goto error_free_buf_dir_name;
}
}
@@ -382,7 +384,7 @@ int main(int argc, char **argv)
fp = open(buffer_access, O_RDONLY | O_NONBLOCK);
if (fp == -1) { /* TODO: If it isn't there make the node */
ret = -errno;
- printf(Failed to open %s\n, buffer_access);
+ fprintf(stderr, Failed to open %s\n, buffer_access);
goto error_free_buffer_access;
}
@@ -410,7 +412,7 @@ int main(int argc, char **argv)
read_size = read(fp, data, toread * scan_size);
if (read_size 0) {
if (errno == EAGAIN) {
- printf(nothing available\n);
+ fprintf(stderr, nothing available\n);
continue;
} else {
break;
@@ -431,7 +433,8 @@ int main(int argc, char **argv)
ret = write_sysfs_string(trigger/current_trigger,
dev_dir_name, NULL);
if (ret 0)
- printf(Failed to write to %s\n, dev_dir_name);
+ fprintf(stderr, Failed to write to %s\n,
+ dev_dir_name);
error_close_buffer_access:
if (close(fp) == -1)
diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
index 9ee1959..cd3fd41 100644
--- a/tools/iio/iio_event_monitor.c
+++ b/tools/iio/iio_event_monitor.c
@@ -215,8 +215,8 @@ static void print_event(struct iio_event_data *event)
bool diff = IIO_EVENT_CODE_EXTRACT_DIFF(event-id);
if (!event_is_known(event)) {
- printf(Unknown event: time: %lld, id: %llx\n,
- event-timestamp, event-id);
+
Re: [PATCH v3] tools: iio: Send error messages to stderr
Cristina Opriceana schrieb am 13.07.2015 um 15:33:
This patch intends to make some cleanup and send printf
error messages to stderr. The changes were performed with coccinelle
for failure messages and manual for other cases, such as wrong usage
messages.
Looking very good so far. Two off-by-one indentation issues spotted however
(checkpatch didn't spot at least the first one), but after fixing you can
add my
Reviewed-by: Hartmut Knaack knaac...@gmx.de
Signed-off-by: Cristina Opriceana cristina.oprice...@gmail.com
---
Changes since v2:
- merge all replacements in one commit
tools/iio/generic_buffer.c| 23 +++-
tools/iio/iio_event_monitor.c | 14 ++---
tools/iio/iio_utils.c | 49
+--
tools/iio/lsiio.c | 2 +-
4 files changed, 50 insertions(+), 38 deletions(-)
diff --git a/tools/iio/generic_buffer.c b/tools/iio/generic_buffer.c
index 9535c2d..249858a 100644
--- a/tools/iio/generic_buffer.c
+++ b/tools/iio/generic_buffer.c
@@ -193,7 +193,7 @@ void process_scan(char *data,
void print_usage(void)
{
- printf(Usage: generic_buffer [options]...\n
+ fprintf(stderr, Usage: generic_buffer [options]...\n
Capture, convert and output data from IIO device buffer\n
-c n Do n conversions\n
-e Disable wait for event (new data)\n
These lines should be moved one space to the right, as well.
...
diff --git a/tools/iio/iio_utils.c b/tools/iio/iio_utils.c
index e177f40..15bd663 100644
--- a/tools/iio/iio_utils.c
+++ b/tools/iio/iio_utils.c
...
@@ -800,8 +808,9 @@ static int _write_sysfs_string(const char *filename,
const char *basedir,
}
if (strcmp(temp, val) != 0) {
- printf(Possible failure in string write of %s
-Should be %s written to %s/%s\n, temp, val,
+ fprintf(stderr,
+ Possible failure in string write of %s
+ Should be %s written to %s/%s\n, temp, val,
basedir, filename);
And this is the other instance.
ret = -1;
}
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
