Re: [PATCH v3 0/3] Improve eye-diagram & single-ended test for rk3288 hdmi
Hi Russell, 在 2015/4/1 0:25, Russell King - ARM Linux 写道: On Mon, Mar 09, 2015 at 05:42:21PM +0800, Yakir Yang wrote: RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz, and single-ended test would failed when display mode is 74.25MHz. Has anyone reviewed these changes yet? I don't see any replies, nor are they in David's git tree. To me, they look mostly fine - the only issue I get is that the final patch doesn't apply cleanly to dw_hdmi.h since they're generated against a tree which has audio support merged. I also see no regressions on iMX6, so I think they can be merged. Unless anyone has any objections, I'll add these to my queue for David. Thanks. Wooh, thanks, I will send v4 now to improve the "drm: dw_hdmi/dw_hdmi-rockchip". Best regards, Yakir Yang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 0/3] Improve eye-diagram & single-ended test for rk3288 hdmi
On Mon, Mar 09, 2015 at 05:42:21PM +0800, Yakir Yang wrote: > RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz, > and single-ended test would failed when display mode is 74.25MHz. Has anyone reviewed these changes yet? I don't see any replies, nor are they in David's git tree. To me, they look mostly fine - the only issue I get is that the final patch doesn't apply cleanly to dw_hdmi.h since they're generated against a tree which has audio support merged. I also see no regressions on iMX6, so I think they can be merged. Unless anyone has any objections, I'll add these to my queue for David. Thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 0/3] Improve eye-diagram single-ended test for rk3288 hdmi
Hi Russell, 在 2015/4/1 0:25, Russell King - ARM Linux 写道: On Mon, Mar 09, 2015 at 05:42:21PM +0800, Yakir Yang wrote: RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz, and single-ended test would failed when display mode is 74.25MHz. Has anyone reviewed these changes yet? I don't see any replies, nor are they in David's git tree. To me, they look mostly fine - the only issue I get is that the final patch doesn't apply cleanly to dw_hdmi.h since they're generated against a tree which has audio support merged. I also see no regressions on iMX6, so I think they can be merged. Unless anyone has any objections, I'll add these to my queue for David. Thanks. Wooh, thanks, I will send v4 now to improve the drm: dw_hdmi/dw_hdmi-rockchip. Best regards, Yakir Yang -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 0/3] Improve eye-diagram single-ended test for rk3288 hdmi
On Mon, Mar 09, 2015 at 05:42:21PM +0800, Yakir Yang wrote: RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz, and single-ended test would failed when display mode is 74.25MHz. Has anyone reviewed these changes yet? I don't see any replies, nor are they in David's git tree. To me, they look mostly fine - the only issue I get is that the final patch doesn't apply cleanly to dw_hdmi.h since they're generated against a tree which has audio support merged. I also see no regressions on iMX6, so I think they can be merged. Unless anyone has any objections, I'll add these to my queue for David. Thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 0/3] Improve eye-diagram & single-ended test for rk3288 hdmi
RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz, and single-ended test would failed when display mode is 74.25MHz. To fix such problems, we make those patch set: - Fix some code style, leave space for next patches. - For hdmi eye-diagram test, we turn on the Transmitter Trailer-B and improve slopeboost to 10%-20% decrease. - For hdmi single-ended test, set CKLVL to 18 and TXLVL to 19 when pixel clock is 74.25MHz. set CKLVL to 13 and TXLVL to 13 when pixel clock is 148.5MHz. Changes in v3: - make commit message more readable - For pixel clock less than 148.5MHz, set txlvl to 20. Changes in v2: - Set slopeboost back to 10%-20%, then rasing/falling time would pass. - For pixel clock less than 74.25MHz, set txlvl to 19 and set cklvl to 18. Yakir Yang (3): drm: bridge/dw_hdmi: fixed codec style drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test drm: bridge/dw_hdmi: improve hdmi single-end test drivers/gpu/drm/bridge/dw_hdmi.c| 20 ++-- drivers/gpu/drm/imx/dw_hdmi-imx.c | 12 ++-- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 14 +++--- include/drm/bridge/dw_hdmi.h| 5 +++-- 4 files changed, 26 insertions(+), 25 deletions(-) -- 2.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 0/3] Improve eye-diagram single-ended test for rk3288 hdmi
RK3288 hdmi eye-diagram test would fail when pixel clock is 148.5MHz, and single-ended test would failed when display mode is 74.25MHz. To fix such problems, we make those patch set: - Fix some code style, leave space for next patches. - For hdmi eye-diagram test, we turn on the Transmitter Trailer-B and improve slopeboost to 10%-20% decrease. - For hdmi single-ended test, set CKLVL to 18 and TXLVL to 19 when pixel clock is 74.25MHz. set CKLVL to 13 and TXLVL to 13 when pixel clock is 148.5MHz. Changes in v3: - make commit message more readable - For pixel clock less than 148.5MHz, set txlvl to 20. Changes in v2: - Set slopeboost back to 10%-20%, then rasing/falling time would pass. - For pixel clock less than 74.25MHz, set txlvl to 19 and set cklvl to 18. Yakir Yang (3): drm: bridge/dw_hdmi: fixed codec style drm: bridge/dw_hdmi_rockchip: improve hdmi eye-diagram test drm: bridge/dw_hdmi: improve hdmi single-end test drivers/gpu/drm/bridge/dw_hdmi.c| 20 ++-- drivers/gpu/drm/imx/dw_hdmi-imx.c | 12 ++-- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 14 +++--- include/drm/bridge/dw_hdmi.h| 5 +++-- 4 files changed, 26 insertions(+), 25 deletions(-) -- 2.1.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
