Re: [PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

On Tue, Mar 07, 2017 at 04:41:04PM +, Wei, Gang wrote:
> On Mon, Mar 06, 2017 at 11:35 PM +0800, Jarkko Sakkinen wrote:
> > On Fri, Mar 03, 2017 at 06:27:19PM -0700, Jerry Snitselaar wrote:
> > >
> > > Jarkko Sakkinen @ 2017-02-08 11:11 GMT:
> > >
> > > > The tpm_crb driver should follow the policy of reserving and
> > > > relinquishing the locality it uses when multiple localities are
> > used,
> > > > like when TXT is another locality.
> > > >
> > > > [This is a resend of v3 as this has been asked from me for a few
> > times
> > > >  now and there wasn't anything obvious to fix.]
> > > >
> > > > Jarkko Sakkinen (3):
> > > >   tpm_crb: map locality registers
> > > >   tpm_crb: encapsulate crb_wait_for_reg_32
> > > >   tpm_crb: request and relinquish locality 0
> > > >
> > > >  drivers/char/tpm/tpm_crb.c | 185
> > +
> > > >  1 file changed, 137 insertions(+), 48 deletions(-)
> > >
> > > Reviewed-by: Jerry Snitselaar 
> > 
> > Jimmy, can you give these patches Tested-by? I remember that
> > you said that they are working for you.
> 
> Sure. They did work for me.
> 
> Jimmy

Thank you!

/Jarkko

Re: [PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

On Tue, Mar 07, 2017 at 04:41:04PM +, Wei, Gang wrote:
> On Mon, Mar 06, 2017 at 11:35 PM +0800, Jarkko Sakkinen wrote:
> > On Fri, Mar 03, 2017 at 06:27:19PM -0700, Jerry Snitselaar wrote:
> > >
> > > Jarkko Sakkinen @ 2017-02-08 11:11 GMT:
> > >
> > > > The tpm_crb driver should follow the policy of reserving and
> > > > relinquishing the locality it uses when multiple localities are
> > used,
> > > > like when TXT is another locality.
> > > >
> > > > [This is a resend of v3 as this has been asked from me for a few
> > times
> > > >  now and there wasn't anything obvious to fix.]
> > > >
> > > > Jarkko Sakkinen (3):
> > > >   tpm_crb: map locality registers
> > > >   tpm_crb: encapsulate crb_wait_for_reg_32
> > > >   tpm_crb: request and relinquish locality 0
> > > >
> > > >  drivers/char/tpm/tpm_crb.c | 185
> > +
> > > >  1 file changed, 137 insertions(+), 48 deletions(-)
> > >
> > > Reviewed-by: Jerry Snitselaar 
> > 
> > Jimmy, can you give these patches Tested-by? I remember that
> > you said that they are working for you.
> 
> Sure. They did work for me.
> 
> Jimmy

Thank you!

/Jarkko

RE: [PATCH v3 0/3] Locality support for tpm_crb

[Wei, Gang]

On Mon, Mar 06, 2017 at 11:35 PM +0800, Jarkko Sakkinen wrote:
> On Fri, Mar 03, 2017 at 06:27:19PM -0700, Jerry Snitselaar wrote:
> >
> > Jarkko Sakkinen @ 2017-02-08 11:11 GMT:
> >
> > > The tpm_crb driver should follow the policy of reserving and
> > > relinquishing the locality it uses when multiple localities are
> used,
> > > like when TXT is another locality.
> > >
> > > [This is a resend of v3 as this has been asked from me for a few
> times
> > >  now and there wasn't anything obvious to fix.]
> > >
> > > Jarkko Sakkinen (3):
> > >   tpm_crb: map locality registers
> > >   tpm_crb: encapsulate crb_wait_for_reg_32
> > >   tpm_crb: request and relinquish locality 0
> > >
> > >  drivers/char/tpm/tpm_crb.c | 185
> +
> > >  1 file changed, 137 insertions(+), 48 deletions(-)
> >
> > Reviewed-by: Jerry Snitselaar 
> 
> Jimmy, can you give these patches Tested-by? I remember that
> you said that they are working for you.

Sure. They did work for me.

Jimmy

RE: [PATCH v3 0/3] Locality support for tpm_crb

[Wei, Gang]

On Mon, Mar 06, 2017 at 11:35 PM +0800, Jarkko Sakkinen wrote:
> On Fri, Mar 03, 2017 at 06:27:19PM -0700, Jerry Snitselaar wrote:
> >
> > Jarkko Sakkinen @ 2017-02-08 11:11 GMT:
> >
> > > The tpm_crb driver should follow the policy of reserving and
> > > relinquishing the locality it uses when multiple localities are
> used,
> > > like when TXT is another locality.
> > >
> > > [This is a resend of v3 as this has been asked from me for a few
> times
> > >  now and there wasn't anything obvious to fix.]
> > >
> > > Jarkko Sakkinen (3):
> > >   tpm_crb: map locality registers
> > >   tpm_crb: encapsulate crb_wait_for_reg_32
> > >   tpm_crb: request and relinquish locality 0
> > >
> > >  drivers/char/tpm/tpm_crb.c | 185
> +
> > >  1 file changed, 137 insertions(+), 48 deletions(-)
> >
> > Reviewed-by: Jerry Snitselaar 
> 
> Jimmy, can you give these patches Tested-by? I remember that
> you said that they are working for you.

Sure. They did work for me.

Jimmy

Re: [PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

On Fri, Mar 03, 2017 at 06:27:19PM -0700, Jerry Snitselaar wrote:
> 
> Jarkko Sakkinen @ 2017-02-08 11:11 GMT:
> 
> > The tpm_crb driver should follow the policy of reserving and
> > relinquishing the locality it uses when multiple localities are used,
> > like when TXT is another locality.
> >
> > [This is a resend of v3 as this has been asked from me for a few times
> >  now and there wasn't anything obvious to fix.]
> >
> > Jarkko Sakkinen (3):
> >   tpm_crb: map locality registers
> >   tpm_crb: encapsulate crb_wait_for_reg_32
> >   tpm_crb: request and relinquish locality 0
> >
> >  drivers/char/tpm/tpm_crb.c | 185 
> > +
> >  1 file changed, 137 insertions(+), 48 deletions(-)
> 
> Reviewed-by: Jerry Snitselaar 

I decided to push these to my tree and linux-next as I've fixed
reported issues from v2 to get coverage.

/Jarkko

Re: [PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

On Fri, Mar 03, 2017 at 06:27:19PM -0700, Jerry Snitselaar wrote:
> 
> Jarkko Sakkinen @ 2017-02-08 11:11 GMT:
> 
> > The tpm_crb driver should follow the policy of reserving and
> > relinquishing the locality it uses when multiple localities are used,
> > like when TXT is another locality.
> >
> > [This is a resend of v3 as this has been asked from me for a few times
> >  now and there wasn't anything obvious to fix.]
> >
> > Jarkko Sakkinen (3):
> >   tpm_crb: map locality registers
> >   tpm_crb: encapsulate crb_wait_for_reg_32
> >   tpm_crb: request and relinquish locality 0
> >
> >  drivers/char/tpm/tpm_crb.c | 185 
> > +
> >  1 file changed, 137 insertions(+), 48 deletions(-)
> 
> Reviewed-by: Jerry Snitselaar 

I decided to push these to my tree and linux-next as I've fixed
reported issues from v2 to get coverage.

/Jarkko

Re: [PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

On Fri, Mar 03, 2017 at 06:27:19PM -0700, Jerry Snitselaar wrote:
> 
> Jarkko Sakkinen @ 2017-02-08 11:11 GMT:
> 
> > The tpm_crb driver should follow the policy of reserving and
> > relinquishing the locality it uses when multiple localities are used,
> > like when TXT is another locality.
> >
> > [This is a resend of v3 as this has been asked from me for a few times
> >  now and there wasn't anything obvious to fix.]
> >
> > Jarkko Sakkinen (3):
> >   tpm_crb: map locality registers
> >   tpm_crb: encapsulate crb_wait_for_reg_32
> >   tpm_crb: request and relinquish locality 0
> >
> >  drivers/char/tpm/tpm_crb.c | 185 
> > +
> >  1 file changed, 137 insertions(+), 48 deletions(-)
> 
> Reviewed-by: Jerry Snitselaar 

Jimmy, can you give these patches Tested-by? I remember that
you said that they are working for you.

/Jarkko

Re: [PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

On Fri, Mar 03, 2017 at 06:27:19PM -0700, Jerry Snitselaar wrote:
> 
> Jarkko Sakkinen @ 2017-02-08 11:11 GMT:
> 
> > The tpm_crb driver should follow the policy of reserving and
> > relinquishing the locality it uses when multiple localities are used,
> > like when TXT is another locality.
> >
> > [This is a resend of v3 as this has been asked from me for a few times
> >  now and there wasn't anything obvious to fix.]
> >
> > Jarkko Sakkinen (3):
> >   tpm_crb: map locality registers
> >   tpm_crb: encapsulate crb_wait_for_reg_32
> >   tpm_crb: request and relinquish locality 0
> >
> >  drivers/char/tpm/tpm_crb.c | 185 
> > +
> >  1 file changed, 137 insertions(+), 48 deletions(-)
> 
> Reviewed-by: Jerry Snitselaar 

Jimmy, can you give these patches Tested-by? I remember that
you said that they are working for you.

/Jarkko

Re: [PATCH v3 0/3] Locality support for tpm_crb

[Jerry Snitselaar]

Jarkko Sakkinen @ 2017-02-08 11:11 GMT:

> The tpm_crb driver should follow the policy of reserving and
> relinquishing the locality it uses when multiple localities are used,
> like when TXT is another locality.
>
> [This is a resend of v3 as this has been asked from me for a few times
>  now and there wasn't anything obvious to fix.]
>
> Jarkko Sakkinen (3):
>   tpm_crb: map locality registers
>   tpm_crb: encapsulate crb_wait_for_reg_32
>   tpm_crb: request and relinquish locality 0
>
>  drivers/char/tpm/tpm_crb.c | 185 
> +
>  1 file changed, 137 insertions(+), 48 deletions(-)

Reviewed-by: Jerry Snitselaar 

Re: [PATCH v3 0/3] Locality support for tpm_crb

[Jerry Snitselaar]

Jarkko Sakkinen @ 2017-02-08 11:11 GMT:

> The tpm_crb driver should follow the policy of reserving and
> relinquishing the locality it uses when multiple localities are used,
> like when TXT is another locality.
>
> [This is a resend of v3 as this has been asked from me for a few times
>  now and there wasn't anything obvious to fix.]
>
> Jarkko Sakkinen (3):
>   tpm_crb: map locality registers
>   tpm_crb: encapsulate crb_wait_for_reg_32
>   tpm_crb: request and relinquish locality 0
>
>  drivers/char/tpm/tpm_crb.c | 185 
> +
>  1 file changed, 137 insertions(+), 48 deletions(-)

Reviewed-by: Jerry Snitselaar 

[PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

The tpm_crb driver should follow the policy of reserving and
relinquishing the locality it uses when multiple localities are used,
like when TXT is another locality.

[This is a resend of v3 as this has been asked from me for a few times
 now and there wasn't anything obvious to fix.]

Jarkko Sakkinen (3):
  tpm_crb: map locality registers
  tpm_crb: encapsulate crb_wait_for_reg_32
  tpm_crb: request and relinquish locality 0

 drivers/char/tpm/tpm_crb.c | 185 +
 1 file changed, 137 insertions(+), 48 deletions(-)

-- 
v2: 
added sanity check for start address of the control area
v3:
do locality request/relinquish as part of send/recv
check priv->regs_h before using it
just assing the base address to regs_h instead of using crb_map_res
2.9.3

[PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

The tpm_crb driver should follow the policy of reserving and
relinquishing the locality it uses when multiple localities are used,
like when TXT is another locality.

[This is a resend of v3 as this has been asked from me for a few times
 now and there wasn't anything obvious to fix.]

Jarkko Sakkinen (3):
  tpm_crb: map locality registers
  tpm_crb: encapsulate crb_wait_for_reg_32
  tpm_crb: request and relinquish locality 0

 drivers/char/tpm/tpm_crb.c | 185 +
 1 file changed, 137 insertions(+), 48 deletions(-)

-- 
v2: 
added sanity check for start address of the control area
v3:
do locality request/relinquish as part of send/recv
check priv->regs_h before using it
just assing the base address to regs_h instead of using crb_map_res
2.9.3

[PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

The tpm_crb driver should follow the policy of reserving and
relinquishing the locality it uses when multiple localities are used,
like when TXT is another locality.

Jarkko Sakkinen (3):
  tpm_crb: map locality registers
  tpm_crb: encapsulate crb_wait_for_reg_32
  tpm_crb: request and relinquish locality 0

 drivers/char/tpm/tpm_crb.c | 185 +
 1 file changed, 137 insertions(+), 48 deletions(-)

-- 
v2: 
added sanity check for start address of the control area
v3:
do locality request/relinquish as part of send/recv
check priv->regs_h before using it
just assing the base address to regs_h instead of using crb_map_res
2.9.3

[PATCH v3 0/3] Locality support for tpm_crb

[Jarkko Sakkinen]

The tpm_crb driver should follow the policy of reserving and
relinquishing the locality it uses when multiple localities are used,
like when TXT is another locality.

Jarkko Sakkinen (3):
  tpm_crb: map locality registers
  tpm_crb: encapsulate crb_wait_for_reg_32
  tpm_crb: request and relinquish locality 0

 drivers/char/tpm/tpm_crb.c | 185 +
 1 file changed, 137 insertions(+), 48 deletions(-)

-- 
v2: 
added sanity check for start address of the control area
v3:
do locality request/relinquish as part of send/recv
check priv->regs_h before using it
just assing the base address to regs_h instead of using crb_map_res
2.9.3