Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Paolo Pisati]

On Wed, Aug 24, 2016 at 10:21:17PM -0500, Andy Gross wrote:
> 
> Yeah this appears to be the case.  So I guess the response is 'don't
> do that'.  At least don't cat or od the file.  You need to seek and
> read.

True, but the dev file is user readable and any user can trigger it (or
any regression test that rummage among dev files looking for bugs).
-- 
bye,
p.

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Paolo Pisati]

On Wed, Aug 24, 2016 at 10:21:17PM -0500, Andy Gross wrote:
> 
> Yeah this appears to be the case.  So I guess the response is 'don't
> do that'.  At least don't cat or od the file.  You need to seek and
> read.

True, but the dev file is user readable and any user can trigger it (or
any regression test that rummage among dev files looking for bugs).
-- 
bye,
p.

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Andy Gross]

On 24 August 2016 at 22:13, Bjorn Andersson  wrote:
> On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote:
>
>> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>> > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
>> > > Hey Andy,
>> > >
>> > > This is a respin of v2 with some minor fixes pointed out by Rob.
>> > > Please pull these in for 4.9
>> > >
>> > > Thanks,
>> > > Rajendra
>> >
>> > I pulled these in.
>>
>> Did you try to read the content of the qfprom from userspace?
>>
>> $ uname -a
>> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 
>> aarch64
>> aarch64 aarch64 GNU/Linux
>> $ lsmod
>> Module  Size  Used by
>> nvmem_qfprom   16384  0
>> nvmem_core 24576  1 nvmem_qfprom
>> $ ls -la /sys/bus/nvmem/devices/
>> total 0
>> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
>> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
>> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
>> ../../../devices/platform/soc/5c000.qfprom/qfprom0
>> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>>
>> [spontaneous reboot]
>>
>> This using agross's for-next tree as of today ("54ba896 Merge branch
>> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>
> This was reported in some other forum as well, after some investigation
> we concluded that it looks like one of the entries are locked down -
> probably from some security reason.
>
> I'm not aware of any way to query this configuration. But the main use
> case for the qfprom is in-kernel access to certain elements and that we
> do get from the driver as is...

Yeah this appears to be the case.  So I guess the response is 'don't
do that'.  At least don't cat or od the file.  You need to seek and
read.

Andy

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Andy Gross]

On 24 August 2016 at 22:13, Bjorn Andersson  wrote:
> On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote:
>
>> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>> > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
>> > > Hey Andy,
>> > >
>> > > This is a respin of v2 with some minor fixes pointed out by Rob.
>> > > Please pull these in for 4.9
>> > >
>> > > Thanks,
>> > > Rajendra
>> >
>> > I pulled these in.
>>
>> Did you try to read the content of the qfprom from userspace?
>>
>> $ uname -a
>> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 
>> aarch64
>> aarch64 aarch64 GNU/Linux
>> $ lsmod
>> Module  Size  Used by
>> nvmem_qfprom   16384  0
>> nvmem_core 24576  1 nvmem_qfprom
>> $ ls -la /sys/bus/nvmem/devices/
>> total 0
>> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
>> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
>> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
>> ../../../devices/platform/soc/5c000.qfprom/qfprom0
>> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>>
>> [spontaneous reboot]
>>
>> This using agross's for-next tree as of today ("54ba896 Merge branch
>> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>
> This was reported in some other forum as well, after some investigation
> we concluded that it looks like one of the entries are locked down -
> probably from some security reason.
>
> I'm not aware of any way to query this configuration. But the main use
> case for the qfprom is in-kernel access to certain elements and that we
> do get from the driver as is...

Yeah this appears to be the case.  So I guess the response is 'don't
do that'.  At least don't cat or od the file.  You need to seek and
read.

Andy

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Bjorn Andersson]

On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote:

> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
> > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> > > Hey Andy,
> > > 
> > > This is a respin of v2 with some minor fixes pointed out by Rob.
> > > Please pull these in for 4.9
> > > 
> > > Thanks,
> > > Rajendra
> > 
> > I pulled these in.
> 
> Did you try to read the content of the qfprom from userspace?
> 
> $ uname -a
> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 
> aarch64
> aarch64 aarch64 GNU/Linux
> $ lsmod 
> Module  Size  Used by
> nvmem_qfprom   16384  0
> nvmem_core 24576  1 nvmem_qfprom
> $ ls -la /sys/bus/nvmem/devices/  
>
> total 0
> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
> ../../../devices/platform/soc/5c000.qfprom/qfprom0
> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem 
> 
> [spontaneous reboot]
> 
> This using agross's for-next tree as of today ("54ba896 Merge branch
> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.

This was reported in some other forum as well, after some investigation
we concluded that it looks like one of the entries are locked down -
probably from some security reason.

I'm not aware of any way to query this configuration. But the main use
case for the qfprom is in-kernel access to certain elements and that we
do get from the driver as is...

Regards,
Bjorn

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Bjorn Andersson]

On Wed 24 Aug 03:22 PDT 2016, Paolo Pisati wrote:

> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
> > On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> > > Hey Andy,
> > > 
> > > This is a respin of v2 with some minor fixes pointed out by Rob.
> > > Please pull these in for 4.9
> > > 
> > > Thanks,
> > > Rajendra
> > 
> > I pulled these in.
> 
> Did you try to read the content of the qfprom from userspace?
> 
> $ uname -a
> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 
> aarch64
> aarch64 aarch64 GNU/Linux
> $ lsmod 
> Module  Size  Used by
> nvmem_qfprom   16384  0
> nvmem_core 24576  1 nvmem_qfprom
> $ ls -la /sys/bus/nvmem/devices/  
>
> total 0
> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
> ../../../devices/platform/soc/5c000.qfprom/qfprom0
> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem 
> 
> [spontaneous reboot]
> 
> This using agross's for-next tree as of today ("54ba896 Merge branch
> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.

This was reported in some other forum as well, after some investigation
we concluded that it looks like one of the entries are locked down -
probably from some security reason.

I'm not aware of any way to query this configuration. But the main use
case for the qfprom is in-kernel access to certain elements and that we
do get from the driver as is...

Regards,
Bjorn

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Andy Gross]

On 24 August 2016 at 07:18, Nayak, Rajendra  wrote:
>
> On 8/24/2016 3:52 PM, Paolo Pisati wrote:
>>
>> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>>>
>>> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:

 Hey Andy,

 This is a respin of v2 with some minor fixes pointed out by Rob.
 Please pull these in for 4.9

 Thanks,
 Rajendra
>>>
>>>
>>> I pulled these in.
>>
>>
>> Did you try to read the content of the qfprom from userspace?
>
>
> Hi, no I haven't tried it, I can give it a try tomorrow when I
> have access to my board and see whats going wrong, but I did
> look at Andys for-next and the defconfig still does not have
> either nvmem or qcom-qfprom drivers enabled.
> Did you manually enable them? or are you seeing this with the drivers still
> disabled?

I merged my for-next with the current next and enabled the options.  I
reproduced Paolo's problem.  It feels like either an access issue,
alignment issue (i tried ioread32 which didnt work).  It fails
regardless of the TSENS being enabled.

>
>
>>
>> $ uname -a
>> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016
>> aarch64
>> aarch64 aarch64 GNU/Linux
>> $ lsmod
>> Module  Size  Used by
>> nvmem_qfprom   16384  0
>> nvmem_core 24576  1 nvmem_qfprom
>> $ ls -la /sys/bus/nvmem/devices/
>> total 0
>> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
>> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
>> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
>> ../../../devices/platform/soc/5c000.qfprom/qfprom0
>> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>>
>> [spontaneous reboot]
>>
>> This using agross's for-next tree as of today ("54ba896 Merge branch
>> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>>
>

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Andy Gross]

On 24 August 2016 at 07:18, Nayak, Rajendra  wrote:
>
> On 8/24/2016 3:52 PM, Paolo Pisati wrote:
>>
>> On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
>>>
>>> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:

 Hey Andy,

 This is a respin of v2 with some minor fixes pointed out by Rob.
 Please pull these in for 4.9

 Thanks,
 Rajendra
>>>
>>>
>>> I pulled these in.
>>
>>
>> Did you try to read the content of the qfprom from userspace?
>
>
> Hi, no I haven't tried it, I can give it a try tomorrow when I
> have access to my board and see whats going wrong, but I did
> look at Andys for-next and the defconfig still does not have
> either nvmem or qcom-qfprom drivers enabled.
> Did you manually enable them? or are you seeing this with the drivers still
> disabled?

I merged my for-next with the current next and enabled the options.  I
reproduced Paolo's problem.  It feels like either an access issue,
alignment issue (i tried ioread32 which didnt work).  It fails
regardless of the TSENS being enabled.

>
>
>>
>> $ uname -a
>> Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016
>> aarch64
>> aarch64 aarch64 GNU/Linux
>> $ lsmod
>> Module  Size  Used by
>> nvmem_qfprom   16384  0
>> nvmem_core 24576  1 nvmem_qfprom
>> $ ls -la /sys/bus/nvmem/devices/
>> total 0
>> drwxr-xr-x 2 root root 0 Aug 24 10:17 .
>> drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
>> lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
>> ../../../devices/platform/soc/5c000.qfprom/qfprom0
>> $ cat /sys/bus/nvmem/devices/qfprom0/nvmem
>>
>> [spontaneous reboot]
>>
>> This using agross's for-next tree as of today ("54ba896 Merge branch
>> 'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
>>
>

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Nayak, Rajendra]

On 8/24/2016 3:52 PM, Paolo Pisati wrote:

On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:

On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:

Hey Andy,

This is a respin of v2 with some minor fixes pointed out by Rob.
Please pull these in for 4.9

Thanks,
Rajendra


I pulled these in.


Did you try to read the content of the qfprom from userspace?


Hi, no I haven't tried it, I can give it a try tomorrow when I
have access to my board and see whats going wrong, but I did
look at Andys for-next and the defconfig still does not have
either nvmem or qcom-qfprom drivers enabled.
Did you manually enable them? or are you seeing this with the drivers 
still disabled?




$ uname -a
Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
aarch64 aarch64 GNU/Linux
$ lsmod
Module  Size  Used by
nvmem_qfprom   16384  0
nvmem_core 24576  1 nvmem_qfprom
$ ls -la /sys/bus/nvmem/devices/
total 0
drwxr-xr-x 2 root root 0 Aug 24 10:17 .
drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
../../../devices/platform/soc/5c000.qfprom/qfprom0
$ cat /sys/bus/nvmem/devices/qfprom0/nvmem

[spontaneous reboot]

This using agross's for-next tree as of today ("54ba896 Merge branch
'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Nayak, Rajendra]

On 8/24/2016 3:52 PM, Paolo Pisati wrote:

On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:

On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:

Hey Andy,

This is a respin of v2 with some minor fixes pointed out by Rob.
Please pull these in for 4.9

Thanks,
Rajendra


I pulled these in.


Did you try to read the content of the qfprom from userspace?


Hi, no I haven't tried it, I can give it a try tomorrow when I
have access to my board and see whats going wrong, but I did
look at Andys for-next and the defconfig still does not have
either nvmem or qcom-qfprom drivers enabled.
Did you manually enable them? or are you seeing this with the drivers 
still disabled?




$ uname -a
Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
aarch64 aarch64 GNU/Linux
$ lsmod
Module  Size  Used by
nvmem_qfprom   16384  0
nvmem_core 24576  1 nvmem_qfprom
$ ls -la /sys/bus/nvmem/devices/
total 0
drwxr-xr-x 2 root root 0 Aug 24 10:17 .
drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
../../../devices/platform/soc/5c000.qfprom/qfprom0
$ cat /sys/bus/nvmem/devices/qfprom0/nvmem

[spontaneous reboot]

This using agross's for-next tree as of today ("54ba896 Merge branch
'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Paolo Pisati]

On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> > Hey Andy,
> > 
> > This is a respin of v2 with some minor fixes pointed out by Rob.
> > Please pull these in for 4.9
> > 
> > Thanks,
> > Rajendra
> 
> I pulled these in.

Did you try to read the content of the qfprom from userspace?

$ uname -a
Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
aarch64 aarch64 GNU/Linux
$ lsmod 
Module  Size  Used by
nvmem_qfprom   16384  0
nvmem_core 24576  1 nvmem_qfprom
$ ls -la /sys/bus/nvmem/devices/
 
total 0
drwxr-xr-x 2 root root 0 Aug 24 10:17 .
drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
../../../devices/platform/soc/5c000.qfprom/qfprom0
$ cat /sys/bus/nvmem/devices/qfprom0/nvmem 

[spontaneous reboot]

This using agross's for-next tree as of today ("54ba896 Merge branch
'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
-- 
bye,
p.

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Paolo Pisati]

On Wed, Aug 17, 2016 at 02:33:40PM -0500, Andy Gross wrote:
> On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> > Hey Andy,
> > 
> > This is a respin of v2 with some minor fixes pointed out by Rob.
> > Please pull these in for 4.9
> > 
> > Thanks,
> > Rajendra
> 
> I pulled these in.

Did you try to read the content of the qfprom from userspace?

$ uname -a
Linux dragon410c 4.8.0-rc1+ #6 SMP PREEMPT Wed Aug 24 11:11:02 CEST 2016 aarch64
aarch64 aarch64 GNU/Linux
$ lsmod 
Module  Size  Used by
nvmem_qfprom   16384  0
nvmem_core 24576  1 nvmem_qfprom
$ ls -la /sys/bus/nvmem/devices/
 
total 0
drwxr-xr-x 2 root root 0 Aug 24 10:17 .
drwxr-xr-x 4 root root 0 Aug 24 10:15 ..
lrwxrwxrwx 1 root root 0 Aug 24 10:17 qfprom0 ->
../../../devices/platform/soc/5c000.qfprom/qfprom0
$ cat /sys/bus/nvmem/devices/qfprom0/nvmem 

[spontaneous reboot]

This using agross's for-next tree as of today ("54ba896 Merge branch
'arm64-defconfig-for-4.9' into all-for-4.8") and defconfig.
-- 
bye,
p.

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Andy Gross]

On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> Hey Andy,
> 
> This is a respin of v2 with some minor fixes pointed out by Rob.
> Please pull these in for 4.9
> 
> Thanks,
> Rajendra

I pulled these in.

Andy

Re: [PATCH v3 0/5] dts patches for qcom tsens support

[Andy Gross]

On Wed, Aug 17, 2016 at 10:48:43AM +0530, Rajendra Nayak wrote:
> Hey Andy,
> 
> This is a respin of v2 with some minor fixes pointed out by Rob.
> Please pull these in for 4.9
> 
> Thanks,
> Rajendra

I pulled these in.

Andy

[PATCH v3 0/5] dts patches for qcom tsens support

[Rajendra Nayak]

Hey Andy,

This is a respin of v2 with some minor fixes pointed out by Rob.
Please pull these in for 4.9

Thanks,
Rajendra

Rajendra Nayak (5):
  arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes
  arm: dts: apq8064: Add thermal zones, tsens and qfprom nodes
  arm: dts: apq8084: Add thermal zones, tsens and qfprom nodes
  arm64: dts: msm8916: Add thermal zones, tsens and qfprom nodes
  arm64: dts: msm8996: Add thermal zones, tsens and qfprom nodes

 .../devicetree/bindings/clock/qcom,gcc.txt |  16 
 arch/arm/boot/dts/qcom-apq8064.dtsi| 103 +
 arch/arm/boot/dts/qcom-apq8084.dtsi| 103 +
 arch/arm/boot/dts/qcom-msm8974.dtsi| 103 +
 arch/arm64/boot/dts/qcom/msm8916.dtsi  |  64 +
 arch/arm64/boot/dts/qcom/msm8996.dtsi  |  92 ++
 6 files changed, 481 insertions(+)

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

[PATCH v3 0/5] dts patches for qcom tsens support

[Rajendra Nayak]

Hey Andy,

This is a respin of v2 with some minor fixes pointed out by Rob.
Please pull these in for 4.9

Thanks,
Rajendra

Rajendra Nayak (5):
  arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes
  arm: dts: apq8064: Add thermal zones, tsens and qfprom nodes
  arm: dts: apq8084: Add thermal zones, tsens and qfprom nodes
  arm64: dts: msm8916: Add thermal zones, tsens and qfprom nodes
  arm64: dts: msm8996: Add thermal zones, tsens and qfprom nodes

 .../devicetree/bindings/clock/qcom,gcc.txt |  16 
 arch/arm/boot/dts/qcom-apq8064.dtsi| 103 +
 arch/arm/boot/dts/qcom-apq8084.dtsi| 103 +
 arch/arm/boot/dts/qcom-msm8974.dtsi| 103 +
 arch/arm64/boot/dts/qcom/msm8916.dtsi  |  64 +
 arch/arm64/boot/dts/qcom/msm8996.dtsi  |  92 ++
 6 files changed, 481 insertions(+)

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation