Re: [alsa-devel] [PATCH v3 0/5] soundwire: code cleanup
On 4/15/19 7:57 AM, Pierre-Louis Bossart wrote: On 4/14/19 5:04 AM, Vinod Koul wrote: On 10-04-19, 22:16, Pierre-Louis Bossart wrote: SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up. Applied, 1, 3 and 4 (5 looked good but didnt apply) this applies on top of Mark Brown's for-next tree. This should be the reference really for SoundWire work, if we start having another tree with deltas it's really counter productive. I already have dependencies on acpi... Vinod, can you please double-check why patch 5 didn't work for you. I tried on Mark and Linus' trees and no issues, see below. $ git reset --hard v5.1-rc5 HEAD is now at dc4060a5dc25 Linux 5.1-rc5 $ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml Applying: soundwire: intel: fix inversion in devm_kcalloc parameters Applying: soundwire: fix style issues Applying: soundwire: bus: remove useless initializations Applying: soundwire: stream: remove useless initialization of local variable Applying: soundwire: add missing newlines in dynamic debug logs $ git reset --hard broonie/for-next HEAD is now at 84fdefca04a7 Merge branch 'asoc-5.2' into asoc-next $ git am ~/Downloads/alsa/39/\[PATCH\ v3\ *.eml Applying: soundwire: intel: fix inversion in devm_kcalloc parameters Applying: soundwire: fix style issues Applying: soundwire: bus: remove useless initializations Applying: soundwire: stream: remove useless initialization of local variable Applying: soundwire: add missing newlines in dynamic debug logs
Re: [alsa-devel] [PATCH v3 0/5] soundwire: code cleanup
On 4/14/19 5:04 AM, Vinod Koul wrote: On 10-04-19, 22:16, Pierre-Louis Bossart wrote: SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up. Applied, 1, 3 and 4 (5 looked good but didnt apply) this applies on top of Mark Brown's for-next tree. This should be the reference really for SoundWire work, if we start having another tree with deltas it's really counter productive. I already have dependencies on acpi...
Re: [PATCH v3 0/5] soundwire: code cleanup
On 10-04-19, 22:16, Pierre-Louis Bossart wrote: > SoundWire support will be provided in Linux with the Sound Open > Firmware (SOF) on Intel platforms. Before we start adding the missing > pieces, there are a number of warnings and style issues reported by > checkpatch, cppcheck and Coccinelle that need to be cleaned-up. Applied, 1, 3 and 4 (5 looked good but didnt apply) Thanks > > Changes since v2: > fixed inversion of devm_kcalloc parameters, detected while rebasing > additional patches. > > Changes since v1: > added missing newlines in new patch (suggested by Joe Perches) > > Pierre-Louis Bossart (5): > soundwire: intel: fix inversion in devm_kcalloc parameters > soundwire: fix style issues > soundwire: bus: remove useless initializations > soundwire: stream: remove useless initialization of local variable > soundwire: add missing newlines in dynamic debug logs > > drivers/soundwire/Kconfig | 2 +- > drivers/soundwire/bus.c| 137 --- > drivers/soundwire/bus.h| 16 +- > drivers/soundwire/bus_type.c | 4 +- > drivers/soundwire/cadence_master.c | 99 +-- > drivers/soundwire/cadence_master.h | 22 +-- > drivers/soundwire/intel.c | 103 ++- > drivers/soundwire/intel.h | 4 +- > drivers/soundwire/intel_init.c | 12 +- > drivers/soundwire/mipi_disco.c | 116 +++-- > drivers/soundwire/slave.c | 10 +- > drivers/soundwire/stream.c | 267 +++-- > 12 files changed, 404 insertions(+), 388 deletions(-) > > -- > 2.17.1 -- ~Vinod
Re: [PATCH v3 0/5] soundwire: code cleanup
On Thu, 11 Apr 2019 05:16:56 +0200, Pierre-Louis Bossart wrote: > > SoundWire support will be provided in Linux with the Sound Open > Firmware (SOF) on Intel platforms. Before we start adding the missing > pieces, there are a number of warnings and style issues reported by > checkpatch, cppcheck and Coccinelle that need to be cleaned-up. > > Changes since v2: > fixed inversion of devm_kcalloc parameters, detected while rebasing > additional patches. > > Changes since v1: > added missing newlines in new patch (suggested by Joe Perches) > > Pierre-Louis Bossart (5): > soundwire: intel: fix inversion in devm_kcalloc parameters > soundwire: fix style issues > soundwire: bus: remove useless initializations > soundwire: stream: remove useless initialization of local variable > soundwire: add missing newlines in dynamic debug logs All looked fine, for the series: Reviewed-by: Takashi Iwai thanks, Takashi
[PATCH v3 0/5] soundwire: code cleanup
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up. Changes since v2: fixed inversion of devm_kcalloc parameters, detected while rebasing additional patches. Changes since v1: added missing newlines in new patch (suggested by Joe Perches) Pierre-Louis Bossart (5): soundwire: intel: fix inversion in devm_kcalloc parameters soundwire: fix style issues soundwire: bus: remove useless initializations soundwire: stream: remove useless initialization of local variable soundwire: add missing newlines in dynamic debug logs drivers/soundwire/Kconfig | 2 +- drivers/soundwire/bus.c| 137 --- drivers/soundwire/bus.h| 16 +- drivers/soundwire/bus_type.c | 4 +- drivers/soundwire/cadence_master.c | 99 +-- drivers/soundwire/cadence_master.h | 22 +-- drivers/soundwire/intel.c | 103 ++- drivers/soundwire/intel.h | 4 +- drivers/soundwire/intel_init.c | 12 +- drivers/soundwire/mipi_disco.c | 116 +++-- drivers/soundwire/slave.c | 10 +- drivers/soundwire/stream.c | 267 +++-- 12 files changed, 404 insertions(+), 388 deletions(-) -- 2.17.1
