Re: [PATCH v3 0/8] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling

2019-10-21 Thread Ulf Hansson
On Thu, 17 Oct 2019 at 08:22, Manish Narani  wrote:
>
> This patch series does the following:
>  - Reorganize the Clock Handling in Arasan SD driver
>  - Adds new sampling clock in Arasan SD driver
>  - Adds support to set Clock Delays in SD Arasan Driver
>  - Add SDIO Tap Delay handling in ZynqMP firmware driver
>  - Add support for ZynqMP Tap Delays setting in Arasan SD driver
>
> Changes in v2:
> - Replaced the deprecated calls to clock framework APIs
> - Added support for dev_clk_get() call to work for SD card clock
> - Separated the clock data struct
> - Fragmented the patch series in smaller patches to make it more
>   readable
>
> Changes in v3:
> - Reverted "Replaced the deprecated calls to clock framework APIs"
> - Removed devm_clk_get() call which was added in v2
>
> Manish Narani (8):
>   mmc: sdhci-of-arasan: Separate out clk related data to another
> structure
>   dt-bindings: mmc: arasan: Update Documentation for the input clock
>   mmc: sdhci-of-arasan: Add sampling clock for a phy to use
>   dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI
>   mmc: sdhci-of-arasan: Add support to set clock phase delays for SD
>   firmware: xilinx: Add SDIO Tap Delay nodes
>   dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller
>   mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup
>
>  .../devicetree/bindings/mmc/arasan,sdhci.txt  |  40 +-
>  drivers/mmc/host/sdhci-of-arasan.c| 477 +-
>  include/linux/firmware/xlnx-zynqmp.h  |  13 +-
>  3 files changed, 498 insertions(+), 32 deletions(-)
>
> --
> 2.17.1
>

Manish, the series looks good to me. However, I expect you to post a
re-spin, to move some of the new DT bindings into common mmc DT
bindings, as Rob suggested.

So waiting for another version, before I apply it.

Kind regards
Uffe


[PATCH v3 0/8] Arasan SDHCI enhancements and ZynqMP Tap Delays Handling

2019-10-16 Thread Manish Narani
This patch series does the following:
 - Reorganize the Clock Handling in Arasan SD driver
 - Adds new sampling clock in Arasan SD driver
 - Adds support to set Clock Delays in SD Arasan Driver
 - Add SDIO Tap Delay handling in ZynqMP firmware driver
 - Add support for ZynqMP Tap Delays setting in Arasan SD driver

Changes in v2:
- Replaced the deprecated calls to clock framework APIs
- Added support for dev_clk_get() call to work for SD card clock
- Separated the clock data struct
- Fragmented the patch series in smaller patches to make it more
  readable

Changes in v3:
- Reverted "Replaced the deprecated calls to clock framework APIs"
- Removed devm_clk_get() call which was added in v2

Manish Narani (8):
  mmc: sdhci-of-arasan: Separate out clk related data to another
structure
  dt-bindings: mmc: arasan: Update Documentation for the input clock
  mmc: sdhci-of-arasan: Add sampling clock for a phy to use
  dt-bindings: mmc: arasan: Add optional properties for Arasan SDHCI
  mmc: sdhci-of-arasan: Add support to set clock phase delays for SD
  firmware: xilinx: Add SDIO Tap Delay nodes
  dt-bindings: mmc: arasan: Document 'xlnx,zynqmp-8.9a' controller
  mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

 .../devicetree/bindings/mmc/arasan,sdhci.txt  |  40 +-
 drivers/mmc/host/sdhci-of-arasan.c| 477 +-
 include/linux/firmware/xlnx-zynqmp.h  |  13 +-
 3 files changed, 498 insertions(+), 32 deletions(-)

-- 
2.17.1