Re: [PATCH v3 0/9] perf: support enable and disable commands in stat and record modes
On Mon, May 18, 2020 at 11:08:43AM +0300, Alexey Budankov wrote: > Hi, > > Is there anything else that could be done from my side to move this forward? sorry I did not get to this yet.. will check jirka
Re: [PATCH v3 0/9] perf: support enable and disable commands in stat and record modes
Hi, Is there anything else that could be done from my side to move this forward? Thanks, Alexey On 13.05.2020 10:53, Alexey Budankov wrote: > > Changes in v3: > - renamed functions and types from perf_evlist_ to evlist_ to avoid > clash with libperf code; > - extended commands to be strings of variable length consisting of > command name and also possibly including command specific data; > - merged docs update with the code changes; > - updated docs for -D,--delay=-1 option for stat and record modes; > > v2: > https://lore.kernel.org/lkml/d582cc3d-2302-c7e2-70d3-bc7ab6f62...@linux.intel.com/ > > Changes in v2: > - renamed resume and pause commands to enable and disable ones, renamed > CTL_CMD_RESUME and CTL_CMD_PAUSE to CTL_CMD_ENABLE and CTL_CMD_DISABLE > to fit to the appropriate ioctls and avoid mixing up with PAUSE_OUTPUT > ioctl; > - factored out event handling loop into a handle_events() for stat mode; > - separated -D,--delay=-1 into separate patches for stat and record modes; > > v1: > https://lore.kernel.org/lkml/825a5132-b58d-c0b6-b050-5a6040386...@linux.intel.com/ > > repo: tip of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > perf/core > > The patch set implements handling of 'start disabled', 'enable' and 'disable' > external control commands which can be provided for stat and record modes > of the tool from an external controlling process. 'start disabled' command > can be used to postpone enabling of events in the beginning of a monitoring > session. 'enable' and 'disable' commands can be used to enable and disable > events correspondingly any time after the start of the session. > > The 'start disabled', 'enable' and 'disable' external control commands can be > used to focus measurement on specially selected time intervals of workload > execution. Focused measurement reduces tool intrusion and influence on > workload behavior, reduces distortion and amount of collected and stored > data, mitigates data accuracy loss because measurement and data capturing > happen only during intervals of interest. > > A controlling process can be a bash shell script [1], native executable or > any other language program that can directly work with file descriptors, > e.g. pipes [2], and spawn a process, specially the tool one. > > -D,--delay option is extended with -1 value to skip events enabling > in the beginning of a monitoring session ('start disabled' command). > --ctl-fd and --ctl-fd-ack command line options are introduced to provide the > tool with a pair of file descriptors to listen to control commands and reply > to the controlling process on the completion of received commands. > > The tool reads control command message from ctl-fd descriptor, handles the > command and optionally replies acknowledgement message to fd-ack descriptor, > if it is specified on the command line. 'enable' command is recognized as > 'enable' string message and 'disable' command is recognized as 'disable' > string message both received from ctl-fd descriptor. Completion message is > 'ack\n' and sent to fd-ack descriptor. > > Example bash script demonstrating simple use case follows: > > #!/bin/bash > > ctl_dir=/tmp/ > > ctl_fifo=${ctl_dir}perf_ctl.fifo > test -p ${ctl_fifo} && unlink ${ctl_fifo} > mkfifo ${ctl_fifo} && exec {ctl_fd}<>${ctl_fifo} > > ctl_ack_fifo=${ctl_dir}perf_ctl_ack.fifo > test -p ${ctl_ack_fifo} && unlink ${ctl_ack_fifo} > mkfifo ${ctl_ack_fifo} && exec {ctl_fd_ack}<>${ctl_ack_fifo} > > perf stat -D -1 -e cpu-cycles -a -I 1000\ > --ctl-fd ${ctl_fd} --ctl-fd-ack ${ctl_fd_ack} \ > -- sleep 40 & > perf_pid=$! > > sleep 5 && echo 'enable' >&${ctl_fd} && read -u ${ctl_fd_ack} e1 && echo > "enabled(${e1})" > sleep 10 && echo 'disable' >&${ctl_fd} && read -u ${ctl_fd_ack} d1 && echo > "disabled(${d1})" > sleep 5 && echo 'enable' >&${ctl_fd} && read -u ${ctl_fd_ack} e2 && echo > "enabled(${e2})" > sleep 10 && echo 'disable' >&${ctl_fd} && read -u ${ctl_fd_ack} d2 && echo > "disabled(${d2})" > > exec {ctl_fd_ack}>&- && unlink ${ctl_ack_fifo} > exec {ctl_fd}>&- && unlink ${ctl_fifo} > > wait -n ${perf_pid} > exit $? > > > Script output: > > [root@host dir] example > Events disabled > # time counts unit events > 1.001101062cpu-cycles > > 2.002994944cpu-cycles > > 3.004864340cpu-cycles > > 4.006727177cpu-cycles > > Events enabled > enabled(ack) > 4.993808464 3,124,246 cpu-cycles > > 5.008597004 3,325,624 cpu-cycles > > 6.010387483 83,472,992 cpu-cycles
[PATCH v3 0/9] perf: support enable and disable commands in stat and record modes
Changes in v3: - renamed functions and types from perf_evlist_ to evlist_ to avoid clash with libperf code; - extended commands to be strings of variable length consisting of command name and also possibly including command specific data; - merged docs update with the code changes; - updated docs for -D,--delay=-1 option for stat and record modes; v2: https://lore.kernel.org/lkml/d582cc3d-2302-c7e2-70d3-bc7ab6f62...@linux.intel.com/ Changes in v2: - renamed resume and pause commands to enable and disable ones, renamed CTL_CMD_RESUME and CTL_CMD_PAUSE to CTL_CMD_ENABLE and CTL_CMD_DISABLE to fit to the appropriate ioctls and avoid mixing up with PAUSE_OUTPUT ioctl; - factored out event handling loop into a handle_events() for stat mode; - separated -D,--delay=-1 into separate patches for stat and record modes; v1: https://lore.kernel.org/lkml/825a5132-b58d-c0b6-b050-5a6040386...@linux.intel.com/ repo: tip of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core The patch set implements handling of 'start disabled', 'enable' and 'disable' external control commands which can be provided for stat and record modes of the tool from an external controlling process. 'start disabled' command can be used to postpone enabling of events in the beginning of a monitoring session. 'enable' and 'disable' commands can be used to enable and disable events correspondingly any time after the start of the session. The 'start disabled', 'enable' and 'disable' external control commands can be used to focus measurement on specially selected time intervals of workload execution. Focused measurement reduces tool intrusion and influence on workload behavior, reduces distortion and amount of collected and stored data, mitigates data accuracy loss because measurement and data capturing happen only during intervals of interest. A controlling process can be a bash shell script [1], native executable or any other language program that can directly work with file descriptors, e.g. pipes [2], and spawn a process, specially the tool one. -D,--delay option is extended with -1 value to skip events enabling in the beginning of a monitoring session ('start disabled' command). --ctl-fd and --ctl-fd-ack command line options are introduced to provide the tool with a pair of file descriptors to listen to control commands and reply to the controlling process on the completion of received commands. The tool reads control command message from ctl-fd descriptor, handles the command and optionally replies acknowledgement message to fd-ack descriptor, if it is specified on the command line. 'enable' command is recognized as 'enable' string message and 'disable' command is recognized as 'disable' string message both received from ctl-fd descriptor. Completion message is 'ack\n' and sent to fd-ack descriptor. Example bash script demonstrating simple use case follows: #!/bin/bash ctl_dir=/tmp/ ctl_fifo=${ctl_dir}perf_ctl.fifo test -p ${ctl_fifo} && unlink ${ctl_fifo} mkfifo ${ctl_fifo} && exec {ctl_fd}<>${ctl_fifo} ctl_ack_fifo=${ctl_dir}perf_ctl_ack.fifo test -p ${ctl_ack_fifo} && unlink ${ctl_ack_fifo} mkfifo ${ctl_ack_fifo} && exec {ctl_fd_ack}<>${ctl_ack_fifo} perf stat -D -1 -e cpu-cycles -a -I 1000\ --ctl-fd ${ctl_fd} --ctl-fd-ack ${ctl_fd_ack} \ -- sleep 40 & perf_pid=$! sleep 5 && echo 'enable' >&${ctl_fd} && read -u ${ctl_fd_ack} e1 && echo "enabled(${e1})" sleep 10 && echo 'disable' >&${ctl_fd} && read -u ${ctl_fd_ack} d1 && echo "disabled(${d1})" sleep 5 && echo 'enable' >&${ctl_fd} && read -u ${ctl_fd_ack} e2 && echo "enabled(${e2})" sleep 10 && echo 'disable' >&${ctl_fd} && read -u ${ctl_fd_ack} d2 && echo "disabled(${d2})" exec {ctl_fd_ack}>&- && unlink ${ctl_ack_fifo} exec {ctl_fd}>&- && unlink ${ctl_fifo} wait -n ${perf_pid} exit $? Script output: [root@host dir] example Events disabled # time counts unit events 1.001101062cpu-cycles 2.002994944cpu-cycles 3.004864340cpu-cycles 4.006727177cpu-cycles Events enabled enabled(ack) 4.993808464 3,124,246 cpu-cycles 5.008597004 3,325,624 cpu-cycles 6.010387483 83,472,992 cpu-cycles 7.012266598 55,877,621 cpu-cycles 8.014175695 97,892,729 cpu-cycles 9.016056093 68,461,242 cpu-cycles 10.017937507 55
[PATCH v3 0/9] perf: support enable and disable commands in stat and record modes
Changes in v3: - renamed functions and types from perf_evlist_ to evlist_ to avoid clash with libperf code; - supported commands to be strings of variable length consisting of command name and also possibly including command specific data; - merged docs update with the code changes; - updated docs for -D,--delay=-1 option for stat and record modes; v2: https://lore.kernel.org/lkml/d582cc3d-2302-c7e2-70d3-bc7ab6f62...@linux.intel.com/ Changes in v2: - renamed resume and pause commands to enable and disable ones, renamed CTL_CMD_RESUME and CTL_CMD_PAUSE to CTL_CMD_ENABLE and CTL_CMD_DISABLE to fit to the appropriate ioctls and avoid mixing up with PAUSE_OUTPUT ioctl; - factored out event handling loop into a handle_events() for stat mode; - separated -D,--delay=-1 into separate patches for stat and record modes; v1: https://lore.kernel.org/lkml/825a5132-b58d-c0b6-b050-5a6040386...@linux.intel.com/ repo: tip of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core The patch set implements handling of 'start disabled', 'enable' and 'disable' external control commands which can be provided for stat and record modes of the tool from an external controlling process. 'start disabled' command can be used to postpone enabling of events in the beginning of a monitoring session. 'enable' and 'disable' commands can be used to enable and disable events correspondingly any time after the start of the session. The 'start disabled', 'enable' and 'disable' external control commands can be used to focus measurement on specially selected time intervals of workload execution. Focused measurement reduces tool intrusion and influence on workload behavior, reduces distortion and amount of collected and stored data, mitigates data accuracy loss because measurement and data capturing happen only during intervals of interest. A controlling process can be a bash shell script [1], native executable or any other language program that can directly work with file descriptors, e.g. pipes [2], and spawn a process, specially the tool one. -D,--delay option is extended with -1 value to skip events enabling in the beginning of a monitoring session ('start disabled' command). --ctl-fd and --ctl-fd-ack command line options are introduced to provide the tool with a pair of file descriptors to listen to control commands and reply to the controlling process on the completion of received commands. The tool reads control command message from ctl-fd descriptor, handles the command and optionally replies acknowledgement message to fd-ack descriptor, if it is specified on the command line. 'enable' command is recognized as 'enable' string message and 'disable' command is recognized as 'disable' string message both received from ctl-fd descriptor. Completion message is 'ack\n' and sent to fd-ack descriptor. example bash script demonstrating simple use case: #!/bin/bash ctl_dir=/tmp/ ctl_fifo=${ctl_dir}perf_ctl.fifo test -p ${ctl_fifo} && unlink ${ctl_fifo} mkfifo ${ctl_fifo} && exec {ctl_fd}<>${ctl_fifo} ctl_ack_fifo=${ctl_dir}perf_ctl_ack.fifo test -p ${ctl_ack_fifo} && unlink ${ctl_ack_fifo} mkfifo ${ctl_ack_fifo} && exec {ctl_fd_ack}<>${ctl_ack_fifo} perf stat -D -1 -e cpu-cycles -a -I 1000\ --ctl-fd ${ctl_fd} --ctl-fd-ack ${ctl_fd_ack} \ -- sleep 40 & perf_pid=$! sleep 5 && echo 'enable' >&${ctl_fd} && read -u ${ctl_fd_ack} e1 && echo "enabled(${e1})" sleep 10 && echo 'disable' >&${ctl_fd} && read -u ${ctl_fd_ack} d1 && echo "disabled(${d1})" sleep 5 && echo 'enable' >&${ctl_fd} && read -u ${ctl_fd_ack} e2 && echo "enabled(${e2})" sleep 10 && echo 'disable' >&${ctl_fd} && read -u ${ctl_fd_ack} d2 && echo "disabled(${d2})" exec {ctl_fd_ack}>&- && unlink ${ctl_ack_fifo} exec {ctl_fd}>&- && unlink ${ctl_fifo} wait -n ${perf_pid} exit $? Script output: [root@host acme] example Events disabled # time counts unit events 1.001101062cpu-cycles 2.002994944cpu-cycles 3.004864340cpu-cycles 4.006727177cpu-cycles Events enabled enabled(ack) 4.993808464 3,124,246 cpu-cycles 5.008597004 3,325,624 cpu-cycles 6.010387483 83,472,992 cpu-cycles 7.012266598 55,877,621 cpu-cycles 8.014175695 97,892,729 cpu-cycles 9.016056093 68,461,242 cpu-cycles 10.017937507 55,449,