Re: [PATCH v3 00/12] acpi: fix some coding style issues

2021-04-08 Thread Rafael J. Wysocki
On Sat, Mar 27, 2021 at 1:11 PM Xiaofei Tan  wrote:
>
> Fix some coding style issues reported by checkpatch.pl.
> Only cleanup and no function changes.
>
> Differences from v2 to v3:
> - Remove the modifications that may cause function change.
>
> Differences from v1 to v2:
> - Add subsystem and module name in the name of patch 05/15.
> - Change to use more proper module name for some patch names.
>
> Xiaofei Tan (12):
>   ACPI: APD: fix a block comment align issue
>   ACPI: processor: fix some coding style issues
>   ACPI: ipmi: remove useless return statement for void function
>   ACPI: LPSS: add a missed blank line after declarations
>   ACPI: acpi_pad: add a missed blank line after declarations
>   ACPI: battery: fix some coding style issues
>   ACPI: button: fix some coding style issues
>   ACPI: CPPC: fix some coding style issues
>   ACPI: custom_method: fix a coding style issue
>   ACPI: PM: add a missed blank line after declarations
>   ACPI: sysfs: fix some coding style issues
>   ACPI: dock: fix some coding style issues

All applied as 5.13 material, thanks!


Re: [Linuxarm] Re: [PATCH v3 00/12] acpi: fix some coding style issues

2021-03-29 Thread Xiaofei Tan

Hi Rafael,

On 2021/3/29 20:50, Rafael J. Wysocki wrote:

On Sat, Mar 27, 2021 at 1:11 PM Xiaofei Tan  wrote:


Fix some coding style issues reported by checkpatch.pl.
Only cleanup and no function changes.

Differences from v2 to v3:
- Remove the modifications that may cause function change.

Differences from v1 to v2:
- Add subsystem and module name in the name of patch 05/15.
- Change to use more proper module name for some patch names.

Xiaofei Tan (12):
  ACPI: APD: fix a block comment align issue
  ACPI: processor: fix some coding style issues
  ACPI: ipmi: remove useless return statement for void function
  ACPI: LPSS: add a missed blank line after declarations
  ACPI: acpi_pad: add a missed blank line after declarations
  ACPI: battery: fix some coding style issues
  ACPI: button: fix some coding style issues
  ACPI: CPPC: fix some coding style issues
  ACPI: custom_method: fix a coding style issue
  ACPI: PM: add a missed blank line after declarations
  ACPI: sysfs: fix some coding style issues
  ACPI: dock: fix some coding style issues

 drivers/acpi/acpi_apd.c   |  8 ++---
 drivers/acpi/acpi_ipmi.c  |  1 -
 drivers/acpi/acpi_lpss.c  |  2 ++
 drivers/acpi/acpi_pad.c   |  4 +++
 drivers/acpi/acpi_processor.c | 18 +++
 drivers/acpi/battery.c| 63 --
 drivers/acpi/button.c |  9 ++
 drivers/acpi/cppc_acpi.c  | 71 ++-
 drivers/acpi/custom_method.c  |  2 +-
 drivers/acpi/device_pm.c  |  3 ++
 drivers/acpi/device_sysfs.c   | 15 ++---
 drivers/acpi/dock.c   |  7 +++--
 12 files changed, 106 insertions(+), 97 deletions(-)

--


Can you please stop sending new versions of this for a while?



OK.



You've sent three of them over the last weekend and honestly I haven't
had a chance to look at the first one even.



I tried to fix a low-level mistake as quickly as possible. I'm sorry for 
that





___
Linuxarm mailing list -- linux...@openeuler.org
To unsubscribe send an email to linuxarm-le...@openeuler.org





Re: [PATCH v3 00/12] acpi: fix some coding style issues

2021-03-29 Thread Rafael J. Wysocki
On Sat, Mar 27, 2021 at 1:11 PM Xiaofei Tan  wrote:
>
> Fix some coding style issues reported by checkpatch.pl.
> Only cleanup and no function changes.
>
> Differences from v2 to v3:
> - Remove the modifications that may cause function change.
>
> Differences from v1 to v2:
> - Add subsystem and module name in the name of patch 05/15.
> - Change to use more proper module name for some patch names.
>
> Xiaofei Tan (12):
>   ACPI: APD: fix a block comment align issue
>   ACPI: processor: fix some coding style issues
>   ACPI: ipmi: remove useless return statement for void function
>   ACPI: LPSS: add a missed blank line after declarations
>   ACPI: acpi_pad: add a missed blank line after declarations
>   ACPI: battery: fix some coding style issues
>   ACPI: button: fix some coding style issues
>   ACPI: CPPC: fix some coding style issues
>   ACPI: custom_method: fix a coding style issue
>   ACPI: PM: add a missed blank line after declarations
>   ACPI: sysfs: fix some coding style issues
>   ACPI: dock: fix some coding style issues
>
>  drivers/acpi/acpi_apd.c   |  8 ++---
>  drivers/acpi/acpi_ipmi.c  |  1 -
>  drivers/acpi/acpi_lpss.c  |  2 ++
>  drivers/acpi/acpi_pad.c   |  4 +++
>  drivers/acpi/acpi_processor.c | 18 +++
>  drivers/acpi/battery.c| 63 --
>  drivers/acpi/button.c |  9 ++
>  drivers/acpi/cppc_acpi.c  | 71 
> ++-
>  drivers/acpi/custom_method.c  |  2 +-
>  drivers/acpi/device_pm.c  |  3 ++
>  drivers/acpi/device_sysfs.c   | 15 ++---
>  drivers/acpi/dock.c   |  7 +++--
>  12 files changed, 106 insertions(+), 97 deletions(-)
>
> --

Can you please stop sending new versions of this for a while?

You've sent three of them over the last weekend and honestly I haven't
had a chance to look at the first one even.


[PATCH v3 00/12] acpi: fix some coding style issues

2021-03-27 Thread Xiaofei Tan
Fix some coding style issues reported by checkpatch.pl.
Only cleanup and no function changes.

Differences from v2 to v3:
- Remove the modifications that may cause function change.

Differences from v1 to v2:
- Add subsystem and module name in the name of patch 05/15.
- Change to use more proper module name for some patch names.

Xiaofei Tan (12):
  ACPI: APD: fix a block comment align issue
  ACPI: processor: fix some coding style issues
  ACPI: ipmi: remove useless return statement for void function
  ACPI: LPSS: add a missed blank line after declarations
  ACPI: acpi_pad: add a missed blank line after declarations
  ACPI: battery: fix some coding style issues
  ACPI: button: fix some coding style issues
  ACPI: CPPC: fix some coding style issues
  ACPI: custom_method: fix a coding style issue
  ACPI: PM: add a missed blank line after declarations
  ACPI: sysfs: fix some coding style issues
  ACPI: dock: fix some coding style issues

 drivers/acpi/acpi_apd.c   |  8 ++---
 drivers/acpi/acpi_ipmi.c  |  1 -
 drivers/acpi/acpi_lpss.c  |  2 ++
 drivers/acpi/acpi_pad.c   |  4 +++
 drivers/acpi/acpi_processor.c | 18 +++
 drivers/acpi/battery.c| 63 --
 drivers/acpi/button.c |  9 ++
 drivers/acpi/cppc_acpi.c  | 71 ++-
 drivers/acpi/custom_method.c  |  2 +-
 drivers/acpi/device_pm.c  |  3 ++
 drivers/acpi/device_sysfs.c   | 15 ++---
 drivers/acpi/dock.c   |  7 +++--
 12 files changed, 106 insertions(+), 97 deletions(-)

-- 
2.8.1