Re: [PATCH v3 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs
On Fri, Mar 9, 2018 at 1:33 PM, Lina Iyer wrote: > Hi Stephen, > > I will address all the comments in the next spin of the patch. Here are > some responses to the questions. > > On Tue, Mar 06 2018 at 12:45 -0700, Stephen Boyd wrote: >> >> Quoting Lina Iyer (2018-03-02 08:43:08) > > [...] >> >> +#include >> >> If the driver doesn't become tristate, this should become export.h >> instead of module.h >> > MODULE_DEVICE_TABLE seems to need this. > If you don't have tristate then MODULE_DEVICE_TABLE isn't needed.
Re: [PATCH v3 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs
Hi Stephen,
I will address all the comments in the next spin of the patch. Here are
some responses to the questions.
On Tue, Mar 06 2018 at 12:45 -0700, Stephen Boyd wrote:
Quoting Lina Iyer (2018-03-02 08:43:08)
[...]
+#include
If the driver doesn't become tristate, this should become export.h
instead of module.h
MODULE_DEVICE_TABLE seems to need this.
[...]
+
+static void write_tcs_reg_sync(struct rsc_drv *drv, int reg, int m, int n,
+ u32 data)
+{
+ write_tcs_reg(drv, reg, m, n, data);
+ for (;;) {
+ if (data == read_tcs_reg(drv, reg, m, n))
+ break;
+ udelay(1);
Hopefully this never gets stuck. Add a timeout?
No, it wont. The read is to make sure that the write went through before
we exit this call.
[...]
+ list_del(&resp->list);
+ spin_unlock_irqrestore(&drv->drv_lock, flags);
+ free_response(resp);
But all this function does is free the structure? Will it do more later?
Hopefully, I would like to use a pre-allocateed pool instead of alloc
and free.
+ for_each_set_bit(j, &curr_enabled, MAX_CMDS_PER_TCS) {
+ addr = read_tcs_reg(drv, RSC_DRV_CMD_ADDR, m, j);
+ for (k = 0; k < msg->num_payload; k++) {
+ if (addr == msg->payload[k].addr)
+ return -EBUSY;
+ }
+ }
+ }
There isn't any way to do this in software only? Hopefully this isn't
costly to read the TCS to see if something matches.
It is, but not too expensive. The alternatives involves more locking..
Thanks,
Lina
Re: [PATCH v3 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs
Quoting Lina Iyer (2018-03-02 08:43:08) > Add controller driver for QCOM SoCs that have hardware based shared > resource management. The hardware IP known as RSC (Resource State > Coordinator) houses multiple Direct Resource Voter (DRV) for different > execution levels. A DRV is a unique voter on the state of a shared > resource. A Trigger Control Set (TCS) is a bunch of slots that can house > multiple resource state requests, that when triggered will issue those > requests through an internal bus to the Resource Power Manager Hardened > (RPMH) blocks. These hardware blocks are capable of adjusting clocks, > voltages etc. The resource state request from a DRV are aggregated along s/voltages etc/voltages, etc/ > with state requests from other processors in the SoC and the aggregate > value is applied on the resource. > > Some important aspects of the RPMH communication - > - Requests are with some header information > - Multiple requests (upto 16) may be sent through a TCS, at a time > - Requests in a TCS are sent in sequence > - Requests may be fire-n-forget or completion (response expected) > - Multiple TCS from the same DRV may be triggered simultaneously > - Cannot send a request if another reques for the same addr is in s/reques /request/ ? > progress from the same DRV > - When all the requests from a TCS are complete, an IRQ is raised > - The IRQ handler needs to clear the TCS before it is available for > reuse > - TCS configuration is specific to a DRV > - Platform drivers may use DRV from different RSCs to make requests > > Resource state requests made when CPUs are active are called 'active' > state requests. Requests made when all the CPUs are powered down (idle > state) are called 'sleep' state requests. They are matched by a > corresponding 'wake' state requests which puts the resources back in to > previously requested active state before resuming any CPU. TCSes are > dedicated for each type of requests. Control TCS are used to provide > specific information to the controller. > > Signed-off-by: Lina Iyer > --- > drivers/soc/qcom/Kconfig| 10 + > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/rpmh-internal.h| 87 + > drivers/soc/qcom/rpmh-rsc.c | 593 > > include/dt-bindings/soc/qcom,rpmh-rsc.h | 14 + > include/soc/qcom/tcs.h | 56 +++ > 6 files changed, 761 insertions(+) > create mode 100644 drivers/soc/qcom/rpmh-internal.h > create mode 100644 drivers/soc/qcom/rpmh-rsc.c > create mode 100644 include/dt-bindings/soc/qcom,rpmh-rsc.h > create mode 100644 include/soc/qcom/tcs.h > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index e050eb83341d..779f0d14748d 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -55,6 +55,16 @@ config QCOM_RMTFS_MEM > > Say y here if you intend to boot the modem remoteproc. > > +config QCOM_RPMH > + bool "Qualcomm RPM-Hardened (RPMH) Communication" No module? > + depends on ARCH_QCOM && ARM64 && OF Add support for compile test? > + help > + Support for communication with the hardened-RPM blocks in > + Qualcomm Technologies Inc (QTI) SoCs. RPMH communication uses an > + internal bus to transmit state requests for shared resources. A set > + of hardware components aggregate requests for these resources and > + help apply the aggregated state on the resource. > + > config QCOM_SMEM > tristate "Qualcomm Shared Memory Manager (SMEM)" > depends on ARCH_QCOM > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index dcebf2814e6d..e7d04f0e3616 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -12,3 +12,4 @@ obj-$(CONFIG_QCOM_SMEM_STATE) += smem_state.o > obj-$(CONFIG_QCOM_SMP2P) += smp2p.o > obj-$(CONFIG_QCOM_SMSM)+= smsm.o > obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o > +obj-$(CONFIG_QCOM_RPMH)+= rpmh-rsc.o Keep alphabetically sorted? > diff --git a/drivers/soc/qcom/rpmh-internal.h > b/drivers/soc/qcom/rpmh-internal.h > new file mode 100644 > index ..12faec77c4f3 > --- /dev/null > +++ b/drivers/soc/qcom/rpmh-internal.h > @@ -0,0 +1,87 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2016-2018, The Linux Foundation. All rights reserved. > + */ > + > + > +#ifndef __RPM_INTERNAL_H__ > +#define __RPM_INTERNAL_H__ > + > +#include > + > +#define TCS_TYPE_NR4 > +#define MAX_CMDS_PER_TCS 16 > +#define MAX_TCS_PER_TYPE 3 > +#define MAX_TCS_NR (MAX_TCS_PER_TYPE * TCS_TYPE_NR) > + > +struct rsc_drv; > + > +/** > + * tcs_response: Response object for a request struct tcs_response - > + * > + * @drv: the controller > + * @msg: the request for this response > + * @m: the tcs identifier > + * @err: error reported in the response >
[PATCH v3 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs
Add controller driver for QCOM SoCs that have hardware based shared
resource management. The hardware IP known as RSC (Resource State
Coordinator) houses multiple Direct Resource Voter (DRV) for different
execution levels. A DRV is a unique voter on the state of a shared
resource. A Trigger Control Set (TCS) is a bunch of slots that can house
multiple resource state requests, that when triggered will issue those
requests through an internal bus to the Resource Power Manager Hardened
(RPMH) blocks. These hardware blocks are capable of adjusting clocks,
voltages etc. The resource state request from a DRV are aggregated along
with state requests from other processors in the SoC and the aggregate
value is applied on the resource.
Some important aspects of the RPMH communication -
- Requests are with some header information
- Multiple requests (upto 16) may be sent through a TCS, at a time
- Requests in a TCS are sent in sequence
- Requests may be fire-n-forget or completion (response expected)
- Multiple TCS from the same DRV may be triggered simultaneously
- Cannot send a request if another reques for the same addr is in
progress from the same DRV
- When all the requests from a TCS are complete, an IRQ is raised
- The IRQ handler needs to clear the TCS before it is available for
reuse
- TCS configuration is specific to a DRV
- Platform drivers may use DRV from different RSCs to make requests
Resource state requests made when CPUs are active are called 'active'
state requests. Requests made when all the CPUs are powered down (idle
state) are called 'sleep' state requests. They are matched by a
corresponding 'wake' state requests which puts the resources back in to
previously requested active state before resuming any CPU. TCSes are
dedicated for each type of requests. Control TCS are used to provide
specific information to the controller.
Signed-off-by: Lina Iyer
---
drivers/soc/qcom/Kconfig| 10 +
drivers/soc/qcom/Makefile | 1 +
drivers/soc/qcom/rpmh-internal.h| 87 +
drivers/soc/qcom/rpmh-rsc.c | 593
include/dt-bindings/soc/qcom,rpmh-rsc.h | 14 +
include/soc/qcom/tcs.h | 56 +++
6 files changed, 761 insertions(+)
create mode 100644 drivers/soc/qcom/rpmh-internal.h
create mode 100644 drivers/soc/qcom/rpmh-rsc.c
create mode 100644 include/dt-bindings/soc/qcom,rpmh-rsc.h
create mode 100644 include/soc/qcom/tcs.h
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index e050eb83341d..779f0d14748d 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -55,6 +55,16 @@ config QCOM_RMTFS_MEM
Say y here if you intend to boot the modem remoteproc.
+config QCOM_RPMH
+ bool "Qualcomm RPM-Hardened (RPMH) Communication"
+ depends on ARCH_QCOM && ARM64 && OF
+ help
+ Support for communication with the hardened-RPM blocks in
+ Qualcomm Technologies Inc (QTI) SoCs. RPMH communication uses an
+ internal bus to transmit state requests for shared resources. A set
+ of hardware components aggregate requests for these resources and
+ help apply the aggregated state on the resource.
+
config QCOM_SMEM
tristate "Qualcomm Shared Memory Manager (SMEM)"
depends on ARCH_QCOM
diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile
index dcebf2814e6d..e7d04f0e3616 100644
--- a/drivers/soc/qcom/Makefile
+++ b/drivers/soc/qcom/Makefile
@@ -12,3 +12,4 @@ obj-$(CONFIG_QCOM_SMEM_STATE) += smem_state.o
obj-$(CONFIG_QCOM_SMP2P) += smp2p.o
obj-$(CONFIG_QCOM_SMSM)+= smsm.o
obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o
+obj-$(CONFIG_QCOM_RPMH)+= rpmh-rsc.o
diff --git a/drivers/soc/qcom/rpmh-internal.h b/drivers/soc/qcom/rpmh-internal.h
new file mode 100644
index ..12faec77c4f3
--- /dev/null
+++ b/drivers/soc/qcom/rpmh-internal.h
@@ -0,0 +1,87 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2016-2018, The Linux Foundation. All rights reserved.
+ */
+
+
+#ifndef __RPM_INTERNAL_H__
+#define __RPM_INTERNAL_H__
+
+#include
+
+#define TCS_TYPE_NR4
+#define MAX_CMDS_PER_TCS 16
+#define MAX_TCS_PER_TYPE 3
+#define MAX_TCS_NR (MAX_TCS_PER_TYPE * TCS_TYPE_NR)
+
+struct rsc_drv;
+
+/**
+ * tcs_response: Response object for a request
+ *
+ * @drv: the controller
+ * @msg: the request for this response
+ * @m: the tcs identifier
+ * @err: error reported in the response
+ * @list: link list object.
+ */
+struct tcs_response {
+ struct rsc_drv *drv;
+ struct tcs_request *msg;
+ u32 m;
+ int err;
+ struct list_head list;
+};
+
+/**
+ * tcs_group: group of Trigger Command Sets for a request state
+ *
+ * @drv: the controller
+ * @type: type of the TCS in this group - active, sleep, wake
+ * @tcs_mask: mask of the TCSes relative to all the TCSes in the RSC
