Re: [PATCH v3 03/12] irqchip: mtk-sysirq: prevent unnecessary visibility when set_type

2017-03-23 Thread Marc Zyngier 
On 19/03/17 15:26, Mars Cheng wrote:
> This prevent unnecessary visibility when configuring trigger type
> 
> Signed-off-by: Mars Cheng 

Acked-by: Marc Zyngier 

M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH v3 03/12] irqchip: mtk-sysirq: prevent unnecessary visibility when set_type

2017-03-23 Thread Marc Zyngier 
On 19/03/17 15:26, Mars Cheng wrote:
> This prevent unnecessary visibility when configuring trigger type
> 
> Signed-off-by: Mars Cheng 

Acked-by: Marc Zyngier 

M.
-- 
Jazz is not dead. It just smells funny...

[PATCH v3 03/12] irqchip: mtk-sysirq: prevent unnecessary visibility when set_type

2017-03-19 Thread Mars Cheng 
This prevent unnecessary visibility when configuring trigger type

Signed-off-by: Mars Cheng 
---
 drivers/irqchip/irq-mtk-sysirq.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c
index 9ba969c..eeac512 100644
--- a/drivers/irqchip/irq-mtk-sysirq.c
+++ b/drivers/irqchip/irq-mtk-sysirq.c
@@ -57,7 +57,7 @@ static int mtk_sysirq_set_type(struct irq_data *data, 
unsigned int type)
value &= ~(1 << offset);
}
 
-   writel(value, base + reg_index * 4);
+   writel_relaxed(value, base + reg_index * 4);
 
data = data->parent_data;
ret = data->chip->irq_set_type(data, type);
-- 
1.7.9.5

[PATCH v3 03/12] irqchip: mtk-sysirq: prevent unnecessary visibility when set_type

2017-03-19 Thread Mars Cheng 
This prevent unnecessary visibility when configuring trigger type

Signed-off-by: Mars Cheng 
---
 drivers/irqchip/irq-mtk-sysirq.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c
index 9ba969c..eeac512 100644
--- a/drivers/irqchip/irq-mtk-sysirq.c
+++ b/drivers/irqchip/irq-mtk-sysirq.c
@@ -57,7 +57,7 @@ static int mtk_sysirq_set_type(struct irq_data *data, 
unsigned int type)
value &= ~(1 << offset);
}
 
-   writel(value, base + reg_index * 4);
+   writel_relaxed(value, base + reg_index * 4);
 
data = data->parent_data;
ret = data->chip->irq_set_type(data, type);
-- 
1.7.9.5