Re: [PATCH v3 04/21] ARM: dts: imx7-colibri: Add sleep mode to ethernet

2019-08-09 Thread Marcel Ziswiler 
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote:
> Add sleep pinmux to the fec so it can properly sleep.
> 
> Signed-off-by: Philippe Schenker 

Acked-by: Marcel Ziswiler 

> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/boot/dts/imx7-colibri.dtsi | 19 ++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi
> b/arch/arm/boot/dts/imx7-colibri.dtsi
> index 52046085ce6f..a8d992f3e897 100644
> --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> @@ -101,8 +101,9 @@
>  };
>  
>  &fec1 {
> - pinctrl-names = "default";
> + pinctrl-names = "default", "sleep";
>   pinctrl-0 = <&pinctrl_enet1>;
> + pinctrl-1 = <&pinctrl_enet1_sleep>;
>   clocks = <&clks IMX7D_ENET_AXI_ROOT_CLK>,
>   <&clks IMX7D_ENET_AXI_ROOT_CLK>,
>   <&clks IMX7D_ENET1_TIME_ROOT_CLK>,
> @@ -463,6 +464,22 @@
>   >;
>   };
>  
> + pinctrl_enet1_sleep: enet1sleepgrp {
> + fsl,pins = <
> + MX7D_PAD_ENET1_RGMII_RX_CTL__GPIO7_IO4  
> 0x0
> + MX7D_PAD_ENET1_RGMII_RD0__GPIO7_IO0 
> 0x0
> + MX7D_PAD_ENET1_RGMII_RD1__GPIO7_IO1 
> 0x0
> + MX7D_PAD_ENET1_RGMII_RXC__GPIO7_IO5 
> 0x0
> +
> + MX7D_PAD_ENET1_RGMII_TX_CTL__GPIO7_IO10 
> 0x0
> + MX7D_PAD_ENET1_RGMII_TD0__GPIO7_IO6 
> 0x0
> + MX7D_PAD_ENET1_RGMII_TD1__GPIO7_IO7 
> 0x0
> + MX7D_PAD_GPIO1_IO12__GPIO1_IO12 
> 0x0
> + MX7D_PAD_SD2_CD_B__GPIO5_IO9
> 0x0
> + MX7D_PAD_SD2_WP__GPIO5_IO10 
> 0x0
> + >;
> + };
> +
>   pinctrl_ecspi3_cs: ecspi3-cs-grp {
>   fsl,pins = <
>   MX7D_PAD_I2C2_SDA__GPIO4_IO11   0x14

[PATCH v3 04/21] ARM: dts: imx7-colibri: Add sleep mode to ethernet

2019-08-07 Thread Philippe Schenker 
Add sleep pinmux to the fec so it can properly sleep.

Signed-off-by: Philippe Schenker 
---

Changes in v3: None
Changes in v2: None

 arch/arm/boot/dts/imx7-colibri.dtsi | 19 ++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi 
b/arch/arm/boot/dts/imx7-colibri.dtsi
index 52046085ce6f..a8d992f3e897 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -101,8 +101,9 @@
 };
 
 &fec1 {
-   pinctrl-names = "default";
+   pinctrl-names = "default", "sleep";
pinctrl-0 = <&pinctrl_enet1>;
+   pinctrl-1 = <&pinctrl_enet1_sleep>;
clocks = <&clks IMX7D_ENET_AXI_ROOT_CLK>,
<&clks IMX7D_ENET_AXI_ROOT_CLK>,
<&clks IMX7D_ENET1_TIME_ROOT_CLK>,
@@ -463,6 +464,22 @@
>;
};
 
+   pinctrl_enet1_sleep: enet1sleepgrp {
+   fsl,pins = <
+   MX7D_PAD_ENET1_RGMII_RX_CTL__GPIO7_IO4  0x0
+   MX7D_PAD_ENET1_RGMII_RD0__GPIO7_IO0 0x0
+   MX7D_PAD_ENET1_RGMII_RD1__GPIO7_IO1 0x0
+   MX7D_PAD_ENET1_RGMII_RXC__GPIO7_IO5 0x0
+
+   MX7D_PAD_ENET1_RGMII_TX_CTL__GPIO7_IO10 0x0
+   MX7D_PAD_ENET1_RGMII_TD0__GPIO7_IO6 0x0
+   MX7D_PAD_ENET1_RGMII_TD1__GPIO7_IO7 0x0
+   MX7D_PAD_GPIO1_IO12__GPIO1_IO12 0x0
+   MX7D_PAD_SD2_CD_B__GPIO5_IO90x0
+   MX7D_PAD_SD2_WP__GPIO5_IO10 0x0
+   >;
+   };
+
pinctrl_ecspi3_cs: ecspi3-cs-grp {
fsl,pins = <
MX7D_PAD_I2C2_SDA__GPIO4_IO11   0x14
-- 
2.22.0