Re: [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support

2019-08-09 Thread Marcel Ziswiler 
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote:
> From: Stefan Agner 
> 
> Add pinmuxing and do not specify voltage restrictions for the usdhc
> instance available on the modules edge connector. This allows to use
> SD-cards with higher transfer modes if supported by the carrier
> board.
> 
> Signed-off-by: Stefan Agner 
> Signed-off-by: Philippe Schenker 

Acked-by: Marcel Ziswiler 

> ---
> 
> Changes in v3:
> - Add new commit message from Stefan's proposal on ML
> 
> Changes in v2: None
> 
>  arch/arm/boot/dts/imx7-colibri.dtsi | 23 ++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi
> b/arch/arm/boot/dts/imx7-colibri.dtsi
> index 16d1a1ed1aff..67f5e0c87fdc 100644
> --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> @@ -326,7 +326,6 @@
>   {
>   pinctrl-names = "default";
>   pinctrl-0 = <_usdhc1 _cd_usdhc1>;
> - no-1-8-v;
>   cd-gpios = < 0 GPIO_ACTIVE_LOW>;
>   disable-wp;
>   vqmmc-supply = <_LDO2>;
> @@ -671,6 +670,28 @@
>   >;
>   };
>  
> + pinctrl_usdhc1_100mhz: usdhc1grp_100mhz {
> + fsl,pins = <
> + MX7D_PAD_SD1_CMD__SD1_CMD   0x5a
> + MX7D_PAD_SD1_CLK__SD1_CLK   0x1a
> + MX7D_PAD_SD1_DATA0__SD1_DATA0   0x5a
> + MX7D_PAD_SD1_DATA1__SD1_DATA1   0x5a
> + MX7D_PAD_SD1_DATA2__SD1_DATA2   0x5a
> + MX7D_PAD_SD1_DATA3__SD1_DATA3   0x5a
> + >;
> + };
> +
> + pinctrl_usdhc1_200mhz: usdhc1grp_200mhz {
> + fsl,pins = <
> + MX7D_PAD_SD1_CMD__SD1_CMD   0x5b
> + MX7D_PAD_SD1_CLK__SD1_CLK   0x1b
> + MX7D_PAD_SD1_DATA0__SD1_DATA0   0x5b
> + MX7D_PAD_SD1_DATA1__SD1_DATA1   0x5b
> + MX7D_PAD_SD1_DATA2__SD1_DATA2   0x5b
> + MX7D_PAD_SD1_DATA3__SD1_DATA3   0x5b
> + >;
> + };
> +
>   pinctrl_usdhc3: usdhc3grp {
>   fsl,pins = <
>   MX7D_PAD_SD3_CMD__SD3_CMD   0x59

Re: [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support

2019-08-07 Thread Philippe Schenker 
On Wed, 2019-08-07 at 08:19 -0300, Fabio Estevam wrote:
> Hi Philippe,
> 
> On Wed, Aug 7, 2019 at 5:26 AM Philippe Schenker
>  wrote:
> > From: Stefan Agner 
> > 
> > Add pinmuxing and do not specify voltage restrictions for the usdhc
> > instance available on the modules edge connector. This allows to use
> > SD-cards with higher transfer modes if supported by the carrier
> > board.
> > 
> > Signed-off-by: Stefan Agner 
> > Signed-off-by: Philippe Schenker 
> > 
> > ---
> > 
> > Changes in v3:
> > - Add new commit message from Stefan's proposal on ML
> 
> The commit message has been improved, but there is also another point
> I mentioned earlier:
> 
> > Changes in v2: None
> > 
> >  arch/arm/boot/dts/imx7-colibri.dtsi | 23 ++-
> >  1 file changed, 22 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi
> > b/arch/arm/boot/dts/imx7-colibri.dtsi
> > index 16d1a1ed1aff..67f5e0c87fdc 100644
> > --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> > @@ -326,7 +326,6 @@
> >   {
> > pinctrl-names = "default";
> > pinctrl-0 = <_usdhc1 _cd_usdhc1>;
> > -   no-1-8-v;
> > cd-gpios = < 0 GPIO_ACTIVE_LOW>;
> > disable-wp;
> > vqmmc-supply = <_LDO2>;
> > @@ -671,6 +670,28 @@
> > >;
> > };
> > 
> > +   pinctrl_usdhc1_100mhz: usdhc1grp_100mhz {
> 
> This new entry has been added and it is not referenced.

Sorry, I probably could have mentioned that in this commit. I want, if
possible, to let this commmit as is. That's why I added another on top
of this patchset. Please see patch 21/21 that makes use of this change.
> 
> > +   fsl,pins = <
> > +   MX7D_PAD_SD1_CMD__SD1_CMD   0x5a
> > +   MX7D_PAD_SD1_CLK__SD1_CLK   0x1a
> > +   MX7D_PAD_SD1_DATA0__SD1_DATA0   0x5a
> > +   MX7D_PAD_SD1_DATA1__SD1_DATA1   0x5a
> > +   MX7D_PAD_SD1_DATA2__SD1_DATA2   0x5a
> > +   MX7D_PAD_SD1_DATA3__SD1_DATA3   0x5a
> > +   >;
> > +   };
> > +
> > +   pinctrl_usdhc1_200mhz: usdhc1grp_200mhz {
> 
> Same here.

Re: [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support

2019-08-07 Thread Fabio Estevam 
Hi Philippe,

On Wed, Aug 7, 2019 at 5:26 AM Philippe Schenker
 wrote:
>
> From: Stefan Agner 
>
> Add pinmuxing and do not specify voltage restrictions for the usdhc
> instance available on the modules edge connector. This allows to use
> SD-cards with higher transfer modes if supported by the carrier board.
>
> Signed-off-by: Stefan Agner 
> Signed-off-by: Philippe Schenker 
>
> ---
>
> Changes in v3:
> - Add new commit message from Stefan's proposal on ML

The commit message has been improved, but there is also another point
I mentioned earlier:

>
> Changes in v2: None
>
>  arch/arm/boot/dts/imx7-colibri.dtsi | 23 ++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi 
> b/arch/arm/boot/dts/imx7-colibri.dtsi
> index 16d1a1ed1aff..67f5e0c87fdc 100644
> --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> @@ -326,7 +326,6 @@
>   {
> pinctrl-names = "default";
> pinctrl-0 = <_usdhc1 _cd_usdhc1>;
> -   no-1-8-v;
> cd-gpios = < 0 GPIO_ACTIVE_LOW>;
> disable-wp;
> vqmmc-supply = <_LDO2>;
> @@ -671,6 +670,28 @@
> >;
> };
>
> +   pinctrl_usdhc1_100mhz: usdhc1grp_100mhz {

This new entry has been added and it is not referenced.

> +   fsl,pins = <
> +   MX7D_PAD_SD1_CMD__SD1_CMD   0x5a
> +   MX7D_PAD_SD1_CLK__SD1_CLK   0x1a
> +   MX7D_PAD_SD1_DATA0__SD1_DATA0   0x5a
> +   MX7D_PAD_SD1_DATA1__SD1_DATA1   0x5a
> +   MX7D_PAD_SD1_DATA2__SD1_DATA2   0x5a
> +   MX7D_PAD_SD1_DATA3__SD1_DATA3   0x5a
> +   >;
> +   };
> +
> +   pinctrl_usdhc1_200mhz: usdhc1grp_200mhz {

Same here.

[PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support

2019-08-07 Thread Philippe Schenker 
From: Stefan Agner 

Add pinmuxing and do not specify voltage restrictions for the usdhc
instance available on the modules edge connector. This allows to use
SD-cards with higher transfer modes if supported by the carrier board.

Signed-off-by: Stefan Agner 
Signed-off-by: Philippe Schenker 

---

Changes in v3:
- Add new commit message from Stefan's proposal on ML

Changes in v2: None

 arch/arm/boot/dts/imx7-colibri.dtsi | 23 ++-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi 
b/arch/arm/boot/dts/imx7-colibri.dtsi
index 16d1a1ed1aff..67f5e0c87fdc 100644
--- a/arch/arm/boot/dts/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/imx7-colibri.dtsi
@@ -326,7 +326,6 @@
  {
pinctrl-names = "default";
pinctrl-0 = <_usdhc1 _cd_usdhc1>;
-   no-1-8-v;
cd-gpios = < 0 GPIO_ACTIVE_LOW>;
disable-wp;
vqmmc-supply = <_LDO2>;
@@ -671,6 +670,28 @@
>;
};
 
+   pinctrl_usdhc1_100mhz: usdhc1grp_100mhz {
+   fsl,pins = <
+   MX7D_PAD_SD1_CMD__SD1_CMD   0x5a
+   MX7D_PAD_SD1_CLK__SD1_CLK   0x1a
+   MX7D_PAD_SD1_DATA0__SD1_DATA0   0x5a
+   MX7D_PAD_SD1_DATA1__SD1_DATA1   0x5a
+   MX7D_PAD_SD1_DATA2__SD1_DATA2   0x5a
+   MX7D_PAD_SD1_DATA3__SD1_DATA3   0x5a
+   >;
+   };
+
+   pinctrl_usdhc1_200mhz: usdhc1grp_200mhz {
+   fsl,pins = <
+   MX7D_PAD_SD1_CMD__SD1_CMD   0x5b
+   MX7D_PAD_SD1_CLK__SD1_CLK   0x1b
+   MX7D_PAD_SD1_DATA0__SD1_DATA0   0x5b
+   MX7D_PAD_SD1_DATA1__SD1_DATA1   0x5b
+   MX7D_PAD_SD1_DATA2__SD1_DATA2   0x5b
+   MX7D_PAD_SD1_DATA3__SD1_DATA3   0x5b
+   >;
+   };
+
pinctrl_usdhc3: usdhc3grp {
fsl,pins = <
MX7D_PAD_SD3_CMD__SD3_CMD   0x59
-- 
2.22.0