Re: [PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
On 08/04/2015 12:40 PM, Heiko Stübner wrote: Am Dienstag, 4. August 2015, 12:34:39 schrieb Stephen Boyd: On 08/04/2015 01:54 AM, Heiko Stübner wrote: Hi, Am Dienstag, 4. August 2015, 14:41:26 schrieb Lin Huang: I guess this patch then would need a From: Heiko Stuebner at this point to override the author then. Sounds right. Please resend the patch properly. Also, is there a 2/2? I never got it. Patch 2/2 is a pinctrl change, that actually depends in this patch. Improved clock-handling in the pinctrl driver caused the pd_pmu clock to get deactivated. So, perhaps it might be even better to get an Ack from the clock maintainer and merge both patches through the pinctrl tree? In which case Linus Walleij should also be included as recipient of this patch when resending. Ok that's fine. We can ack it and you can take it through pinctrl if needed. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
Am Dienstag, 4. August 2015, 12:34:39 schrieb Stephen Boyd: > On 08/04/2015 01:54 AM, Heiko Stübner wrote: > > Hi, > > > > Am Dienstag, 4. August 2015, 14:41:26 schrieb Lin Huang: > > > > I guess this patch then would need a > > > > From: Heiko Stuebner > > > > at this point to override the author then. > > Sounds right. Please resend the patch properly. Also, is there a 2/2? I > never got it. Patch 2/2 is a pinctrl change, that actually depends in this patch. Improved clock-handling in the pinctrl driver caused the pd_pmu clock to get deactivated. So, perhaps it might be even better to get an Ack from the clock maintainer and merge both patches through the pinctrl tree? In which case Linus Walleij should also be included as recipient of this patch when resending. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
On 08/04/2015 01:54 AM, Heiko Stübner wrote: Hi, Am Dienstag, 4. August 2015, 14:41:26 schrieb Lin Huang: I guess this patch then would need a From: Heiko Stuebner at this point to override the author then. Sounds right. Please resend the patch properly. Also, is there a 2/2? I never got it. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
Hi,
Am Dienstag, 4. August 2015, 14:41:26 schrieb Lin Huang:
I guess this patch then would need a
From: Heiko Stuebner
at this point to override the author then.
> pclk_pd_pmu needs to keep running and with the upcoming gpio clock
> handling this is not always the case anymore. So add it to the list
> of critical clocks for now.
>
> Signed-off-by: Heiko Stuebner
> Signed-off-by: Lin Huang
> ---
> Changes in v3:
> -match the author and Signed-off-by name
>
> drivers/clk/rockchip/clk-rk3288.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/rockchip/clk-rk3288.c
> b/drivers/clk/rockchip/clk-rk3288.c index 0df5bae..9040878 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -780,6 +780,7 @@ static const char *const rk3288_critical_clocks[]
> __initconst = { "aclk_cpu",
> "aclk_peri",
> "hclk_peri",
> + "pclk_pd_pmu",
> };
>
> #ifdef CONFIG_PM_SLEEP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
pclk_pd_pmu needs to keep running and with the upcoming gpio clock
handling this is not always the case anymore. So add it to the list
of critical clocks for now.
Signed-off-by: Heiko Stuebner
Signed-off-by: Lin Huang
---
Changes in v3:
-match the author and Signed-off-by name
drivers/clk/rockchip/clk-rk3288.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/rockchip/clk-rk3288.c
b/drivers/clk/rockchip/clk-rk3288.c
index 0df5bae..9040878 100644
--- a/drivers/clk/rockchip/clk-rk3288.c
+++ b/drivers/clk/rockchip/clk-rk3288.c
@@ -780,6 +780,7 @@ static const char *const rk3288_critical_clocks[]
__initconst = {
"aclk_cpu",
"aclk_peri",
"hclk_peri",
+ "pclk_pd_pmu",
};
#ifdef CONFIG_PM_SLEEP
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
pclk_pd_pmu needs to keep running and with the upcoming gpio clock
handling this is not always the case anymore. So add it to the list
of critical clocks for now.
Signed-off-by: Heiko Stuebner he...@sntech.de
Signed-off-by: Lin Huang h...@rock-chips.com
---
Changes in v3:
-match the author and Signed-off-by name
drivers/clk/rockchip/clk-rk3288.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/rockchip/clk-rk3288.c
b/drivers/clk/rockchip/clk-rk3288.c
index 0df5bae..9040878 100644
--- a/drivers/clk/rockchip/clk-rk3288.c
+++ b/drivers/clk/rockchip/clk-rk3288.c
@@ -780,6 +780,7 @@ static const char *const rk3288_critical_clocks[]
__initconst = {
aclk_cpu,
aclk_peri,
hclk_peri,
+ pclk_pd_pmu,
};
#ifdef CONFIG_PM_SLEEP
--
1.9.1
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
Hi,
Am Dienstag, 4. August 2015, 14:41:26 schrieb Lin Huang:
I guess this patch then would need a
From: Heiko Stuebner he...@sntech.de
at this point to override the author then.
pclk_pd_pmu needs to keep running and with the upcoming gpio clock
handling this is not always the case anymore. So add it to the list
of critical clocks for now.
Signed-off-by: Heiko Stuebner he...@sntech.de
Signed-off-by: Lin Huang h...@rock-chips.com
---
Changes in v3:
-match the author and Signed-off-by name
drivers/clk/rockchip/clk-rk3288.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/rockchip/clk-rk3288.c
b/drivers/clk/rockchip/clk-rk3288.c index 0df5bae..9040878 100644
--- a/drivers/clk/rockchip/clk-rk3288.c
+++ b/drivers/clk/rockchip/clk-rk3288.c
@@ -780,6 +780,7 @@ static const char *const rk3288_critical_clocks[]
__initconst = { aclk_cpu,
aclk_peri,
hclk_peri,
+ pclk_pd_pmu,
};
#ifdef CONFIG_PM_SLEEP
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
On 08/04/2015 12:40 PM, Heiko Stübner wrote: Am Dienstag, 4. August 2015, 12:34:39 schrieb Stephen Boyd: On 08/04/2015 01:54 AM, Heiko Stübner wrote: Hi, Am Dienstag, 4. August 2015, 14:41:26 schrieb Lin Huang: I guess this patch then would need a From: Heiko Stuebner he...@sntech.de at this point to override the author then. Sounds right. Please resend the patch properly. Also, is there a 2/2? I never got it. Patch 2/2 is a pinctrl change, that actually depends in this patch. Improved clock-handling in the pinctrl driver caused the pd_pmu clock to get deactivated. So, perhaps it might be even better to get an Ack from the clock maintainer and merge both patches through the pinctrl tree? In which case Linus Walleij should also be included as recipient of this patch when resending. Ok that's fine. We can ack it and you can take it through pinctrl if needed. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
Am Dienstag, 4. August 2015, 12:34:39 schrieb Stephen Boyd: On 08/04/2015 01:54 AM, Heiko Stübner wrote: Hi, Am Dienstag, 4. August 2015, 14:41:26 schrieb Lin Huang: I guess this patch then would need a From: Heiko Stuebner he...@sntech.de at this point to override the author then. Sounds right. Please resend the patch properly. Also, is there a 2/2? I never got it. Patch 2/2 is a pinctrl change, that actually depends in this patch. Improved clock-handling in the pinctrl driver caused the pd_pmu clock to get deactivated. So, perhaps it might be even better to get an Ack from the clock maintainer and merge both patches through the pinctrl tree? In which case Linus Walleij should also be included as recipient of this patch when resending. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/2] clk: rockchip: add pclk_pd_pmu to the list of rk3288 critical clocks
On 08/04/2015 01:54 AM, Heiko Stübner wrote: Hi, Am Dienstag, 4. August 2015, 14:41:26 schrieb Lin Huang: I guess this patch then would need a From: Heiko Stuebner he...@sntech.de at this point to override the author then. Sounds right. Please resend the patch properly. Also, is there a 2/2? I never got it. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
