Re: [PATCH v3 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC

[Benjamin Herrenschmidt]

On Wed, 2019-06-05 at 17:59 +0300, Talel Shenhar wrote:
> 

 ../..

> +- compatible: should be "amazon,al-fic"
> +- reg: physical base address and size of the registers
> +- interrupt-controller: identifies the node as an interrupt controller
> +- #interrupt-cells: must be 2.
> +- interrupt-parent: specifies the parent interrupt controller.
> +- interrupts: describes which input line in the interrupt parent, this
> +  fic's output is connected to.
> +
> +Example:
> +
> +amazon_fic: interrupt-controller@0xfd8a8500 {
> + compatible = "amazon,al-fic";
> + interrupt-controller;
> + #interrupt-cells = <1>;
^ should be 2

> + reg = <0x0 0xfd8a8500 0x0 0x1000>;
> + interrupt-parent = <>;
> + interrupts = ;
> +};

[PATCH v3 1/2] dt-bindings: interrupt-controller: Amazon's Annapurna Labs FIC

[Talel Shenhar]

Document Amazon's Annapurna Labs Fabric Interrupt Controller SoC binding.

Signed-off-by: Talel Shenhar 
---
 .../interrupt-controller/amazon,al-fic.txt | 22 ++
 1 file changed, 22 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt

diff --git 
a/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt 
b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt
new file mode 100644
index 000..af3742c
--- /dev/null
+++ b/Documentation/devicetree/bindings/interrupt-controller/amazon,al-fic.txt
@@ -0,0 +1,22 @@
+Amazon's Annapurna Labs Fabric Interrupt Controller
+
+Required properties:
+
+- compatible: should be "amazon,al-fic"
+- reg: physical base address and size of the registers
+- interrupt-controller: identifies the node as an interrupt controller
+- #interrupt-cells: must be 2.
+- interrupt-parent: specifies the parent interrupt controller.
+- interrupts: describes which input line in the interrupt parent, this
+  fic's output is connected to.
+
+Example:
+
+amazon_fic: interrupt-controller@0xfd8a8500 {
+   compatible = "amazon,al-fic";
+   interrupt-controller;
+   #interrupt-cells = <1>;
+   reg = <0x0 0xfd8a8500 0x0 0x1000>;
+   interrupt-parent = <>;
+   interrupts = ;
+};
-- 
2.7.4