Re: [PATCH v3 1/2] dt-bindings: nvmem: mediatek: add support for MediaTek mt8192 SoC

2021-01-31 Thread Matthias Brugger



On 22/01/2021 07:28, mtk23264 wrote:
> On Sun, 2021-01-03 at 09:25 -0700, Rob Herring wrote:
>> On Mon, Dec 21, 2020 at 02:10:19PM +0800, yz...@mediatek.com wrote:
>>> From: Ryan Wu 
>>>
>>> This updates dt-binding documentation for MediaTek mt8192
>>>
>>> Signed-off-by: Ryan Wu 
>>> ---
>>> This patch is based on v5.10-rc7.
>>> ---
>>>  Documentation/devicetree/bindings/nvmem/mtk-efuse.txt | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt 
>>> b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
>>> index 0668c45a156d..e2f0c0f34d10 100644
>>> --- a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
>>> +++ b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
>>> @@ -7,6 +7,7 @@ Required properties:
>>>   "mediatek,mt7622-efuse", "mediatek,efuse": for MT7622
>>>   "mediatek,mt7623-efuse", "mediatek,efuse": for MT7623
>>>   "mediatek,mt8173-efuse" or "mediatek,efuse": for MT8173
>>> + "mediatek,mt8192-efuse" or "mediatek,efuse": for MT8192
>>
>> No, "mediatek,efuse" by itself is only for MT8173.
> Is it should be modify from "mediatek,mt8192-efuse" or "mediatek,efuse"
> to "mediatek,mt8192-efuse", "mediatek,efuse" ?
> 

Yes, as you can see "mediatek,mt8192-efuse" is not defined in the driver (and
should not as long as the HW has no difference from the already implemented 
driver).

Regards,
Matthias

> Regards,
> Yz
>>
>>>  - reg: Should contain registers location and length
>>>  
>>>  = Data cells =
>>> -- 
>>> 2.18.0
>>>
>>
>> ___
>> Linux-mediatek mailing list
>> linux-media...@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 


Re: [PATCH v3 1/2] dt-bindings: nvmem: mediatek: add support for MediaTek mt8192 SoC

2021-01-21 Thread mtk23264
On Sun, 2021-01-03 at 09:25 -0700, Rob Herring wrote:
> On Mon, Dec 21, 2020 at 02:10:19PM +0800, yz...@mediatek.com wrote:
> > From: Ryan Wu 
> > 
> > This updates dt-binding documentation for MediaTek mt8192
> > 
> > Signed-off-by: Ryan Wu 
> > ---
> > This patch is based on v5.10-rc7.
> > ---
> >  Documentation/devicetree/bindings/nvmem/mtk-efuse.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt 
> > b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
> > index 0668c45a156d..e2f0c0f34d10 100644
> > --- a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
> > +++ b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
> > @@ -7,6 +7,7 @@ Required properties:
> >   "mediatek,mt7622-efuse", "mediatek,efuse": for MT7622
> >   "mediatek,mt7623-efuse", "mediatek,efuse": for MT7623
> >   "mediatek,mt8173-efuse" or "mediatek,efuse": for MT8173
> > + "mediatek,mt8192-efuse" or "mediatek,efuse": for MT8192
> 
> No, "mediatek,efuse" by itself is only for MT8173.
Is it should be modify from "mediatek,mt8192-efuse" or "mediatek,efuse"
to "mediatek,mt8192-efuse", "mediatek,efuse" ?

Regards,
Yz
> 
> >  - reg: Should contain registers location and length
> >  
> >  = Data cells =
> > -- 
> > 2.18.0
> > 
> 
> ___
> Linux-mediatek mailing list
> linux-media...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek



Re: [PATCH v3 1/2] dt-bindings: nvmem: mediatek: add support for MediaTek mt8192 SoC

2021-01-03 Thread Rob Herring
On Mon, Dec 21, 2020 at 02:10:19PM +0800, yz...@mediatek.com wrote:
> From: Ryan Wu 
> 
> This updates dt-binding documentation for MediaTek mt8192
> 
> Signed-off-by: Ryan Wu 
> ---
> This patch is based on v5.10-rc7.
> ---
>  Documentation/devicetree/bindings/nvmem/mtk-efuse.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt 
> b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
> index 0668c45a156d..e2f0c0f34d10 100644
> --- a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
> @@ -7,6 +7,7 @@ Required properties:
> "mediatek,mt7622-efuse", "mediatek,efuse": for MT7622
> "mediatek,mt7623-efuse", "mediatek,efuse": for MT7623
> "mediatek,mt8173-efuse" or "mediatek,efuse": for MT8173
> +   "mediatek,mt8192-efuse" or "mediatek,efuse": for MT8192

No, "mediatek,efuse" by itself is only for MT8173.

>  - reg: Should contain registers location and length
>  
>  = Data cells =
> -- 
> 2.18.0
> 


[PATCH v3 1/2] dt-bindings: nvmem: mediatek: add support for MediaTek mt8192 SoC

2020-12-20 Thread Yz.Wu
From: Ryan Wu 

This updates dt-binding documentation for MediaTek mt8192

Signed-off-by: Ryan Wu 
---
This patch is based on v5.10-rc7.
---
 Documentation/devicetree/bindings/nvmem/mtk-efuse.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt 
b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
index 0668c45a156d..e2f0c0f34d10 100644
--- a/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
+++ b/Documentation/devicetree/bindings/nvmem/mtk-efuse.txt
@@ -7,6 +7,7 @@ Required properties:
  "mediatek,mt7622-efuse", "mediatek,efuse": for MT7622
  "mediatek,mt7623-efuse", "mediatek,efuse": for MT7623
  "mediatek,mt8173-efuse" or "mediatek,efuse": for MT8173
+ "mediatek,mt8192-efuse" or "mediatek,efuse": for MT8192
 - reg: Should contain registers location and length
 
 = Data cells =
-- 
2.18.0