Re: [PATCH v3 1/6] mm/migrate: add comment about permanent failure path
On Fri, Dec 13, 2013 at 03:53:26PM +0900, Joonsoo Kim wrote: > From: Naoya Horiguchi > > Let's add a comment about where the failed page goes to, which makes > code more readable. > > Acked-by: Christoph Lameter > Reviewed-by: Wanpeng Li > Signed-off-by: Naoya Horiguchi > Signed-off-by: Joonsoo Kim > > diff --git a/mm/migrate.c b/mm/migrate.c > index 3747fcd..c6ac87a 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1123,7 +1123,12 @@ int migrate_pages(struct list_head *from, new_page_t > get_new_page, > nr_succeeded++; > break; > default: > - /* Permanent failure */ > + /* > + * Permanent failure (-EBUSY, -ENOSYS, etc.): > + * unlike -EAGAIN case, the failed page is > + * removed from migration page list and not > + * retried in the next outer loop. > + */ > nr_failed++; > break; > } Acked-by: Rafael Aquini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v3 1/6] mm/migrate: add comment about permanent failure path
On Fri, Dec 13, 2013 at 03:53:26PM +0900, Joonsoo Kim wrote: From: Naoya Horiguchi n-horigu...@ah.jp.nec.com Let's add a comment about where the failed page goes to, which makes code more readable. Acked-by: Christoph Lameter c...@linux.com Reviewed-by: Wanpeng Li liw...@linux.vnet.ibm.com Signed-off-by: Naoya Horiguchi n-horigu...@ah.jp.nec.com Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/migrate.c b/mm/migrate.c index 3747fcd..c6ac87a 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1123,7 +1123,12 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, nr_succeeded++; break; default: - /* Permanent failure */ + /* + * Permanent failure (-EBUSY, -ENOSYS, etc.): + * unlike -EAGAIN case, the failed page is + * removed from migration page list and not + * retried in the next outer loop. + */ nr_failed++; break; } Acked-by: Rafael Aquini aqu...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 1/6] mm/migrate: add comment about permanent failure path
From: Naoya Horiguchi Let's add a comment about where the failed page goes to, which makes code more readable. Acked-by: Christoph Lameter Reviewed-by: Wanpeng Li Signed-off-by: Naoya Horiguchi Signed-off-by: Joonsoo Kim diff --git a/mm/migrate.c b/mm/migrate.c index 3747fcd..c6ac87a 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1123,7 +1123,12 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, nr_succeeded++; break; default: - /* Permanent failure */ + /* +* Permanent failure (-EBUSY, -ENOSYS, etc.): +* unlike -EAGAIN case, the failed page is +* removed from migration page list and not +* retried in the next outer loop. +*/ nr_failed++; break; } -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 1/6] mm/migrate: add comment about permanent failure path
From: Naoya Horiguchi n-horigu...@ah.jp.nec.com Let's add a comment about where the failed page goes to, which makes code more readable. Acked-by: Christoph Lameter c...@linux.com Reviewed-by: Wanpeng Li liw...@linux.vnet.ibm.com Signed-off-by: Naoya Horiguchi n-horigu...@ah.jp.nec.com Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/migrate.c b/mm/migrate.c index 3747fcd..c6ac87a 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -1123,7 +1123,12 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page, nr_succeeded++; break; default: - /* Permanent failure */ + /* +* Permanent failure (-EBUSY, -ENOSYS, etc.): +* unlike -EAGAIN case, the failed page is +* removed from migration page list and not +* retried in the next outer loop. +*/ nr_failed++; break; } -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
