Re: [PATCH v3 2/3] dt-bindings: input: imagis: Document touch keys

2024-03-07 Thread Krzysztof Kozlowski
On 06/03/2024 15:40, Duje Mihanović wrote:
> IST3032C (and possibly some other models) has touch keys. Document this.
> 
> Signed-off-by: Duje Mihanović 
> ---

Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof




[PATCH v3 2/3] dt-bindings: input: imagis: Document touch keys

2024-03-06 Thread Duje Mihanović
IST3032C (and possibly some other models) has touch keys. Document this.

Signed-off-by: Duje Mihanović 
---
Changes in v3:
- Move allOf under additionalProperties and move if under allOf
- Properly define linux,keycodes
- Fix linux,keycodes constraint
- Change maximum number of keycodes to 5 in accordance with the size of
  the key status field

Changes in v2:
- Allow specifying custom keycodes and document this in binding
---
 .../bindings/input/touchscreen/imagis,ist3038c.yaml   | 19 ---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git 
a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml 
b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
index 2af71cbcc97d..77ba280b3bdc 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
@@ -9,9 +9,6 @@ title: Imagis IST30XXC family touchscreen controller
 maintainers:
   - Markuss Broks 
 
-allOf:
-  - $ref: touchscreen.yaml#
-
 properties:
   $nodename:
 pattern: "^touchscreen@[0-9a-f]+$"
@@ -34,6 +31,10 @@ properties:
   vddio-supply:
 description: Power supply regulator for the I2C bus
 
+  linux,keycodes:
+description: Keycodes for the touch keys
+maxItems: 5
+
   touchscreen-size-x: true
   touchscreen-size-y: true
   touchscreen-fuzz-x: true
@@ -44,6 +45,18 @@ properties:
 
 additionalProperties: false
 
+allOf:
+  - $ref: touchscreen.yaml#
+  - if:
+  not:
+properties:
+  compatible:
+contains:
+  const: imagis,ist3032c
+then:
+  properties:
+linux,keycodes: false
+
 required:
   - compatible
   - reg

-- 
2.44.0