Re: [PATCH v3 2/4] staging: media: atomisp: fix style of open brace

[Rohit K Bharadwaj]

On 26/07/20 3:12 pm, Mauro Carvalho Chehab wrote:
> Em Sun, 26 Jul 2020 14:35:12 +0530
> Rohit K Bharadwaj  escreveu:
> 
>> this patch fixes style of open brace after functions and if statements
>>
>> Signed-off-by: Rohit K Bharadwaj 
> 
>> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct 
>> ia_css_fw_info *bi,
>>  blob = (const unsigned char *)fw + bi->blob.offset;
>>  
>>  /* sanity check */
>> -if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + 
>> bi->blob.data_size + bi->blob.padding_size)
>> -{
>> +if (bi->blob.size !=
>> +bi->blob.text_size + bi->blob.icache_size +
>> +bi->blob.data_size + bi->blob.padding_size) {
> 
> 
> Please adjust the alignments here. I'm pretty sure checkpatch --strict
> will end complaining with the above, as the first line ends with "=".
> 
> I would, instead, code it as:
> 
>   if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size +
>bi->blob.data_size + bi->blob.padding_size) {
> 
> 
> Thanks,
> Mauro
> 
sure sir, do I have to make a v4 of the patch and send all the patches in this 
series again or should I just send this one particular patch again?

Re: [PATCH v3 2/4] staging: media: atomisp: fix style of open brace

[Mauro Carvalho Chehab]

Em Sun, 26 Jul 2020 14:35:12 +0530
Rohit K Bharadwaj  escreveu:

> this patch fixes style of open brace after functions and if statements
> 
> Signed-off-by: Rohit K Bharadwaj 

> @@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct 
> ia_css_fw_info *bi,
>   blob = (const unsigned char *)fw + bi->blob.offset;
>  
>   /* sanity check */
> - if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + 
> bi->blob.data_size + bi->blob.padding_size)
> - {
> + if (bi->blob.size !=
> + bi->blob.text_size + bi->blob.icache_size +
> + bi->blob.data_size + bi->blob.padding_size) {


Please adjust the alignments here. I'm pretty sure checkpatch --strict
will end complaining with the above, as the first line ends with "=".

I would, instead, code it as:

if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size +
 bi->blob.data_size + bi->blob.padding_size) {


Thanks,
Mauro

[PATCH v3 2/4] staging: media: atomisp: fix style of open brace

[Rohit K Bharadwaj]

this patch fixes style of open brace after functions and if statements

Signed-off-by: Rohit K Bharadwaj 
---
v3: change patch subject prefix
v2: split patch into sequence of patches 
v1: fix all coding style issues in single patch

 .../media/atomisp/pci/sh_css_firmware.c   | 29 +--
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c 
b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
index 2907aead98b7..988785ab6c95 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
@@ -81,7 +81,8 @@ char *sh_css_get_fw_version(void)
 /* Setup sp/sp1 binary */
 static int
 setup_binary(struct ia_css_fw_info *fw, const char *fw_data,
-struct ia_css_fw_info *sh_css_fw, unsigned int binary_id) {
+struct ia_css_fw_info *sh_css_fw, unsigned int binary_id)
+{
const char *blob_data;
 
if ((!fw) || (!fw_data))
@@ -105,7 +106,8 @@ setup_binary(struct ia_css_fw_info *fw, const char *fw_data,
 int
 sh_css_load_blob_info(const char *fw, const struct ia_css_fw_info *bi,
  struct ia_css_blob_descr *bd,
- unsigned int index) {
+ unsigned int index)
+{
const char *name;
const unsigned char *blob;
 
@@ -119,8 +121,9 @@ sh_css_load_blob_info(const char *fw, const struct 
ia_css_fw_info *bi,
blob = (const unsigned char *)fw + bi->blob.offset;
 
/* sanity check */
-   if (bi->blob.size != bi->blob.text_size + bi->blob.icache_size + 
bi->blob.data_size + bi->blob.padding_size)
-   {
+   if (bi->blob.size !=
+   bi->blob.text_size + bi->blob.icache_size +
+   bi->blob.data_size + bi->blob.padding_size) {
/* sanity check, note the padding bytes added for section to 
DDR alignment */
return -EINVAL;
}
@@ -131,21 +134,18 @@ sh_css_load_blob_info(const char *fw, const struct 
ia_css_fw_info *bi,
bd->blob = blob;
bd->header = *bi;
 
-   if (bi->type == ia_css_isp_firmware || bi->type == ia_css_sp_firmware)
-   {
+   if (bi->type == ia_css_isp_firmware || bi->type == ia_css_sp_firmware) {
char *namebuffer;
 
namebuffer = kstrdup(name, GFP_KERNEL);
if (!namebuffer)
return -ENOMEM;
bd->name = fw_minibuffer[index].name = namebuffer;
-   } else
-   {
+   } else {
bd->name = name;
}
 
-   if (bi->type == ia_css_isp_firmware)
-   {
+   if (bi->type == ia_css_isp_firmware) {
size_t paramstruct_size = sizeof(struct ia_css_memory_offsets);
size_t configstruct_size = sizeof(struct 
ia_css_config_memory_offsets);
size_t statestruct_size = sizeof(struct 
ia_css_state_memory_offsets);
@@ -226,7 +226,8 @@ static const char * const fw_acc_type_name[] = {
 
 int
 sh_css_load_firmware(struct device *dev, const char *fw_data,
-unsigned int fw_size) {
+unsigned int fw_size)
+{
unsigned int i;
struct ia_css_fw_info *binaries;
struct sh_css_fw_bi_file_h *file_header;
@@ -260,8 +261,7 @@ sh_css_load_firmware(struct device *dev, const char 
*fw_data,
 
sh_css_num_binaries = file_header->binary_nr;
/* Only allocate memory for ISP blob info */
-   if (sh_css_num_binaries > NUM_OF_SPS)
-   {
+   if (sh_css_num_binaries > NUM_OF_SPS) {
sh_css_blob_info = kmalloc(
(sh_css_num_binaries - NUM_OF_SPS) *
sizeof(*sh_css_blob_info), GFP_KERNEL);
@@ -276,8 +276,7 @@ sh_css_load_firmware(struct device *dev, const char 
*fw_data,
if (!fw_minibuffer)
return -ENOMEM;
 
-   for (i = 0; i < sh_css_num_binaries; i++)
-   {
+   for (i = 0; i < sh_css_num_binaries; i++) {
struct ia_css_fw_info *bi = [i];
/*
 * note: the var below is made static as it is quite large;
-- 
2.25.1