Re: [PATCH v3 2/5] dt-bindings: phy-rockchip-inno-usb2: add companion grf quirk

[Frank Wang]

Hi Rob,

On 2017/8/11 1:05, Rob Herring wrote:

On Thu, Aug 03, 2017 at 04:09:10PM +0800, Frank Wang wrote:

Add rockchip,usbgrf and rockchip,companion_grf_quirk to support
the registers of usb-phy that are distributed in grf and usbgrf
on some special Rockchip SoCs (e.g RV1108).

Signed-off-by: Frank Wang 
---
  Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 4 
  1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt 
b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
index 84d59b0..ddf868a 100644
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
@@ -18,6 +18,10 @@ Optional properties:
 usb-phy output 480m and xin24m.
 Refer to clk/clock-bindings.txt for generic clock
 consumer properties.
+ - rockchip,usbgrf : phandle to the syscon managing the "usb general
+register files".
+ - rockchip,companion_grf_quirk : when set driver will request
+"rockchip,usbgrf" phandle as one companion-grf.

Why isn't presence of rockchip,usbgrf or being implied by an SoC
specific compatible string enough?

In any case, use '-' rather than '_'.


All right, thanks for your comments, I will fix it with matching SoC 
specific compatible string.



BR.
Frank

  
  Required nodes : a sub-node is required for each port the phy provides.

 The sub-node name is used to identify host or otg port,
--
2.0.0

Re: [PATCH v3 2/5] dt-bindings: phy-rockchip-inno-usb2: add companion grf quirk

[Frank Wang]

Hi Rob,

On 2017/8/11 1:05, Rob Herring wrote:

On Thu, Aug 03, 2017 at 04:09:10PM +0800, Frank Wang wrote:

Add rockchip,usbgrf and rockchip,companion_grf_quirk to support
the registers of usb-phy that are distributed in grf and usbgrf
on some special Rockchip SoCs (e.g RV1108).

Signed-off-by: Frank Wang 
---
  Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 4 
  1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt 
b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
index 84d59b0..ddf868a 100644
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
@@ -18,6 +18,10 @@ Optional properties:
 usb-phy output 480m and xin24m.
 Refer to clk/clock-bindings.txt for generic clock
 consumer properties.
+ - rockchip,usbgrf : phandle to the syscon managing the "usb general
+register files".
+ - rockchip,companion_grf_quirk : when set driver will request
+"rockchip,usbgrf" phandle as one companion-grf.

Why isn't presence of rockchip,usbgrf or being implied by an SoC
specific compatible string enough?

In any case, use '-' rather than '_'.


All right, thanks for your comments, I will fix it with matching SoC 
specific compatible string.



BR.
Frank

  
  Required nodes : a sub-node is required for each port the phy provides.

 The sub-node name is used to identify host or otg port,
--
2.0.0

Re: [PATCH v3 2/5] dt-bindings: phy-rockchip-inno-usb2: add companion grf quirk

[Rob Herring]

On Thu, Aug 03, 2017 at 04:09:10PM +0800, Frank Wang wrote:
> Add rockchip,usbgrf and rockchip,companion_grf_quirk to support
> the registers of usb-phy that are distributed in grf and usbgrf
> on some special Rockchip SoCs (e.g RV1108).
> 
> Signed-off-by: Frank Wang 
> ---
>  Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt 
> b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> index 84d59b0..ddf868a 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> @@ -18,6 +18,10 @@ Optional properties:
>usb-phy output 480m and xin24m.
>Refer to clk/clock-bindings.txt for generic clock
>consumer properties.
> + - rockchip,usbgrf : phandle to the syscon managing the "usb general
> +  register files".
> + - rockchip,companion_grf_quirk : when set driver will request
> +  "rockchip,usbgrf" phandle as one companion-grf.

Why isn't presence of rockchip,usbgrf or being implied by an SoC 
specific compatible string enough? 

In any case, use '-' rather than '_'.

>  
>  Required nodes : a sub-node is required for each port the phy provides.
>The sub-node name is used to identify host or otg port,
> -- 
> 2.0.0
> 
> 

Re: [PATCH v3 2/5] dt-bindings: phy-rockchip-inno-usb2: add companion grf quirk

[Rob Herring]

On Thu, Aug 03, 2017 at 04:09:10PM +0800, Frank Wang wrote:
> Add rockchip,usbgrf and rockchip,companion_grf_quirk to support
> the registers of usb-phy that are distributed in grf and usbgrf
> on some special Rockchip SoCs (e.g RV1108).
> 
> Signed-off-by: Frank Wang 
> ---
>  Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt 
> b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> index 84d59b0..ddf868a 100644
> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
> @@ -18,6 +18,10 @@ Optional properties:
>usb-phy output 480m and xin24m.
>Refer to clk/clock-bindings.txt for generic clock
>consumer properties.
> + - rockchip,usbgrf : phandle to the syscon managing the "usb general
> +  register files".
> + - rockchip,companion_grf_quirk : when set driver will request
> +  "rockchip,usbgrf" phandle as one companion-grf.

Why isn't presence of rockchip,usbgrf or being implied by an SoC 
specific compatible string enough? 

In any case, use '-' rather than '_'.

>  
>  Required nodes : a sub-node is required for each port the phy provides.
>The sub-node name is used to identify host or otg port,
> -- 
> 2.0.0
> 
> 

[PATCH v3 2/5] dt-bindings: phy-rockchip-inno-usb2: add companion grf quirk

[Frank Wang]

Add rockchip,usbgrf and rockchip,companion_grf_quirk to support
the registers of usb-phy that are distributed in grf and usbgrf
on some special Rockchip SoCs (e.g RV1108).

Signed-off-by: Frank Wang 
---
 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt 
b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
index 84d59b0..ddf868a 100644
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
@@ -18,6 +18,10 @@ Optional properties:
 usb-phy output 480m and xin24m.
 Refer to clk/clock-bindings.txt for generic clock
 consumer properties.
+ - rockchip,usbgrf : phandle to the syscon managing the "usb general
+register files".
+ - rockchip,companion_grf_quirk : when set driver will request
+"rockchip,usbgrf" phandle as one companion-grf.
 
 Required nodes : a sub-node is required for each port the phy provides.
 The sub-node name is used to identify host or otg port,
-- 
2.0.0

[PATCH v3 2/5] dt-bindings: phy-rockchip-inno-usb2: add companion grf quirk

[Frank Wang]

Add rockchip,usbgrf and rockchip,companion_grf_quirk to support
the registers of usb-phy that are distributed in grf and usbgrf
on some special Rockchip SoCs (e.g RV1108).

Signed-off-by: Frank Wang 
---
 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 4 
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt 
b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
index 84d59b0..ddf868a 100644
--- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
+++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
@@ -18,6 +18,10 @@ Optional properties:
 usb-phy output 480m and xin24m.
 Refer to clk/clock-bindings.txt for generic clock
 consumer properties.
+ - rockchip,usbgrf : phandle to the syscon managing the "usb general
+register files".
+ - rockchip,companion_grf_quirk : when set driver will request
+"rockchip,usbgrf" phandle as one companion-grf.
 
 Required nodes : a sub-node is required for each port the phy provides.
 The sub-node name is used to identify host or otg port,
-- 
2.0.0