Re: [PATCH v3 2/6] ACPI: AC: Use string_choices API instead of ternary operator
On Wed, Oct 11, 2023 at 10:34 AM Michal Wilczynski wrote: > > Use modern string_choices API instead of manually determining the > output using ternary operator. > > Suggested-by: Andy Shevchenko > Reviewed-by: Andy Shevchenko > Signed-off-by: Michal Wilczynski > --- > drivers/acpi/ac.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c > index 83d45c681121..f809f6889b4a 100644 > --- a/drivers/acpi/ac.c > +++ b/drivers/acpi/ac.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -243,8 +244,8 @@ static int acpi_ac_add(struct acpi_device *device) > goto err_release_ac; > } > > - pr_info("%s [%s] (%s)\n", acpi_device_name(device), > - acpi_device_bid(device), ac->state ? "on-line" : "off-line"); > + pr_info("%s [%s] (%s-line)\n", acpi_device_name(device), > + acpi_device_bid(device), str_on_off(ac->state)); > > ac->battery_nb.notifier_call = acpi_ac_battery_notify; > register_acpi_notifier(>battery_nb); > -- Applied as 6.7 material, thanks!
[PATCH v3 2/6] ACPI: AC: Use string_choices API instead of ternary operator
Use modern string_choices API instead of manually determining the output using ternary operator. Suggested-by: Andy Shevchenko Reviewed-by: Andy Shevchenko Signed-off-by: Michal Wilczynski --- drivers/acpi/ac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c index 83d45c681121..f809f6889b4a 100644 --- a/drivers/acpi/ac.c +++ b/drivers/acpi/ac.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include @@ -243,8 +244,8 @@ static int acpi_ac_add(struct acpi_device *device) goto err_release_ac; } - pr_info("%s [%s] (%s)\n", acpi_device_name(device), - acpi_device_bid(device), ac->state ? "on-line" : "off-line"); + pr_info("%s [%s] (%s-line)\n", acpi_device_name(device), + acpi_device_bid(device), str_on_off(ac->state)); ac->battery_nb.notifier_call = acpi_ac_battery_notify; register_acpi_notifier(>battery_nb); -- 2.41.0