Re: [PATCH v3 3/8] dt-bindings: regulator: Add document for MT6359 regulator

2020-11-30 Thread Rob Herring
On Mon, 23 Nov 2020 11:48:05 +0800, Hsin-Hsiung Wang wrote:
> add dt-binding document for MediaTek MT6359 PMIC
> 
> Signed-off-by: Hsin-Hsiung Wang 
> ---
>  .../bindings/regulator/mt6359-regulator.yaml  | 145 ++
>  1 file changed, 145 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml:
 'additionalProperties' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml:
 ignoring, error in schema: 
warning: no schema found in file: 
./Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml


See https://patchwork.ozlabs.org/patch/1404625

The base for the patch is generally the last rc1. Any dependencies
should be noted.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.



[PATCH v3 3/8] dt-bindings: regulator: Add document for MT6359 regulator

2020-11-22 Thread Hsin-Hsiung Wang
add dt-binding document for MediaTek MT6359 PMIC

Signed-off-by: Hsin-Hsiung Wang 
---
 .../bindings/regulator/mt6359-regulator.yaml  | 145 ++
 1 file changed, 145 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml

diff --git a/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml 
b/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml
new file mode 100644
index ..bc882b93c86a
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/mt6359-regulator.yaml
@@ -0,0 +1,145 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/mt6359-regulator.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MT6359 Regulator from MediaTek Integrated
+
+maintainers:
+  - Hsin-Hsiung Wang 
+
+description: |
+  List of regulators provided by this controller. It is named
+  according to its regulator type, buck_ and ldo_.
+  MT6359 regulators node should be sub node of the MT6397 MFD node.
+
+properties:
+  $nodename:
+pattern: "^pmic$"
+
+  mt6359regulator:
+type: object
+description: |
+  list of regulators provided by this controller.
+
+patternProperties:
+  "^buck_v(s1|gpu11|modem|pu|core|s2|pa|proc2|proc1|core_sshub)$":
+$ref: "regulator.yaml#"
+
+properties:
+  regulator-name:
+pattern: "^v(s1|gpu11|modem|pu|core|s2|pa|proc2|proc1|core_sshub)$"
+
+  "^ldo_v(ibr|rf12|usb|camio|efuse|xo22)$":
+$ref: "regulator.yaml#"
+
+properties:
+  regulator-name:
+pattern: "^v(ibr|rf12|usb|camio|efuse|xo22)$"
+
+  "^ldo_v(rfck|emc|a12|a09|ufs|bbck)$":
+$ref: "regulator.yaml#"
+
+properties:
+  regulator-name:
+pattern: "^v(rfck|emc|a12|a09|ufs|bbck)$"
+
+  "^ldo_vcn(18|13|33_1_bt|13_1_wifi|33_2_bt|33_2_wifi)$":
+$ref: "regulator.yaml#"
+
+properties:
+  regulator-name:
+pattern: "^vcn(18|13|33_1_bt|13_1_wifi|33_2_bt|33_2_wifi)$"
+
+  "^ldo_vsram_(proc2|others|md|proc1|others_sshub)$":
+$ref: "regulator.yaml#"
+
+properties:
+  regulator-name:
+pattern: "^vsram_(proc2|others|md|proc1|others_sshub)$"
+
+  "^ldo_v(fe|bif|io)28$":
+$ref: "regulator.yaml#"
+
+properties:
+  regulator-name:
+pattern: "^v(fe|bif|io)28$"
+
+  "^ldo_v(aud|io|aux|rf|m)18$":
+$ref: "regulator.yaml#"
+
+properties:
+  regulator-name:
+pattern: "^v(aud|io|aux|rf|m)18$"
+
+  "^ldo_vsim[12]$":
+$ref: "regulator.yaml#"
+
+properties:
+  regulator-name:
+pattern: "^vsim[12]$"
+
+additionalProperties: false
+
+required:
+  - regulator-name
+
+examples:
+  - |
+pmic {
+  mt6359regulator {
+mt6359_vgpu11_buck_reg: buck_vgpu11 {
+  regulator-name = "vgpu11";
+  regulator-min-microvolt = <40>;
+  regulator-max-microvolt = <1193750>;
+  regulator-enable-ramp-delay = <200>;
+  regulator-always-on;
+  regulator-allowed-modes = <0 1 2>;
+};
+
+mt6359_vcamio_ldo_reg: ldo_vcamio {
+  regulator-name = "vcamio";
+  regulator-min-microvolt = <170>;
+  regulator-max-microvolt = <190>;
+};
+
+mt6359_vcn18_ldo_reg: ldo_vcn18 {
+  regulator-name = "vcn18";
+  regulator-min-microvolt = <180>;
+  regulator-max-microvolt = <180>;
+  regulator-enable-ramp-delay = <240>;
+};
+
+mt6359_vsram_proc2_ldo_reg: ldo_vsram_proc2 {
+  regulator-name = "vsram_proc2";
+  regulator-min-microvolt = <50>;
+  regulator-max-microvolt = <1293750>;
+  regulator-ramp-delay = <7500>;
+  regulator-enable-ramp-delay = <240>;
+  regulator-always-on;
+};
+
+mt6359_vfe28_ldo_reg: ldo_vfe28 {
+  regulator-name = "vfe28";
+  regulator-min-microvolt = <280>;
+  regulator-max-microvolt = <280>;
+  regulator-enable-ramp-delay = <120>;
+};
+
+mt6359_vaud18_ldo_reg: ldo_vaud18 {
+  regulator-name = "vaud18";
+  regulator-min-microvolt = <180>;
+  regulator-max-microvolt = <180>;
+  regulator-enable-ramp-delay = <240>;
+};
+
+mt6359_vsim1_ldo_reg: ldo_vsim1 {
+  regulator-name = "vsim1";
+  regulator-min-microvolt = <170>;
+  regulator-max-microvolt = <310>;
+  regulator-enable-ramp-delay = <480>;
+};
+  };
+};
+...
-- 
2.18.0