subject:"\[PATCH v3 45\/77\] ncr5380\: Cleanup #include directives"

Re: [PATCH v3 45/77] ncr5380: Cleanup #include directives

2015-12-21 Thread Hannes Reinecke


On 12/22/2015 02:18 AM, Finn Thain wrote:

Remove unused includes (stat.h, signal.h, proc_fs.h) and move includes
needed by the core drivers into the common header (delay.h etc).

Signed-off-by: Finn Thain 

---
  drivers/scsi/NCR5380.c   |2 --
  drivers/scsi/NCR5380.h   |4 
  drivers/scsi/arm/cumana_1.c  |4 
  drivers/scsi/arm/oak.c   |2 --
  drivers/scsi/atari_NCR5380.c |5 -
  drivers/scsi/atari_scsi.c|1 -
  drivers/scsi/dmx3191d.c  |5 -
  drivers/scsi/dtc.c   |4 +---
  drivers/scsi/g_NCR5380.c |6 ++
  drivers/scsi/mac_scsi.c  |1 -
  drivers/scsi/pas16.c |4 
  drivers/scsi/t128.c  |3 ---
  12 files changed, 7 insertions(+), 34 deletions(-)


Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
--
Dr. Hannes Reinecke   zSeries & Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v3 45/77] ncr5380: Cleanup #include directives

2015-12-21 Thread Finn Thain

Remove unused includes (stat.h, signal.h, proc_fs.h) and move includes
needed by the core drivers into the common header (delay.h etc).

Signed-off-by: Finn Thain 

---
 drivers/scsi/NCR5380.c   |2 --
 drivers/scsi/NCR5380.h   |4 
 drivers/scsi/arm/cumana_1.c  |4 
 drivers/scsi/arm/oak.c   |2 --
 drivers/scsi/atari_NCR5380.c |5 -
 drivers/scsi/atari_scsi.c|1 -
 drivers/scsi/dmx3191d.c  |5 -
 drivers/scsi/dtc.c   |4 +---
 drivers/scsi/g_NCR5380.c |6 ++
 drivers/scsi/mac_scsi.c  |1 -
 drivers/scsi/pas16.c |4 
 drivers/scsi/t128.c  |3 ---
 12 files changed, 7 insertions(+), 34 deletions(-)

Index: linux/drivers/scsi/NCR5380.c
===
--- linux.orig/drivers/scsi/NCR5380.c   2015-12-22 12:16:36.0 +1100
+++ linux/drivers/scsi/NCR5380.c2015-12-22 12:16:37.0 +1100
@@ -79,8 +79,6 @@
  * 4.  Test SCSI-II tagged queueing (I have no devices which support 
  *  tagged queueing)
  */
-#include 
-#include 
 
 #if (NDEBUG & NDEBUG_LISTS)
 #define LIST(x,y) {printk("LINE:%d   Adding %p to %p\n", __LINE__, (void*)(x), 
(void*)(y)); if ((x)==(y)) udelay(5); }
Index: linux/drivers/scsi/NCR5380.h
===
--- linux.orig/drivers/scsi/NCR5380.h   2015-12-22 12:16:32.0 +1100
+++ linux/drivers/scsi/NCR5380.h2015-12-22 12:16:37.0 +1100
@@ -22,8 +22,12 @@
 #ifndef NCR5380_H
 #define NCR5380_H
 
+#include 
 #include 
+#include 
+#include 
 #include 
+#include 
 
 #define NDEBUG_ARBITRATION 0x1
 #define NDEBUG_AUTOSENSE   0x2
Index: linux/drivers/scsi/arm/cumana_1.c
===
--- linux.orig/drivers/scsi/arm/cumana_1.c  2015-12-22 12:16:07.0 
+1100
+++ linux/drivers/scsi/arm/cumana_1.c   2015-12-22 12:16:37.0 +1100
@@ -4,9 +4,7 @@
  * Copyright 1995-2002, Russell King
  */
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 
@@ -15,8 +13,6 @@
 
 #include 
 
-#include 
-
 #define PSEUDO_DMA
 
 #define priv(host) ((struct NCR5380_hostdata 
*)(host)->hostdata)
Index: linux/drivers/scsi/arm/oak.c
===
--- linux.orig/drivers/scsi/arm/oak.c   2015-12-22 12:16:07.0 +1100
+++ linux/drivers/scsi/arm/oak.c2015-12-22 12:16:37.0 +1100
@@ -5,9 +5,7 @@
  */
 
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 
Index: linux/drivers/scsi/atari_NCR5380.c
===
--- linux.orig/drivers/scsi/atari_NCR5380.c 2015-12-22 12:16:36.0 
+1100
+++ linux/drivers/scsi/atari_NCR5380.c  2015-12-22 12:16:37.0 +1100
@@ -68,9 +68,6 @@
 
 /* Adapted for the sun3 by Sam Creasey. */
 
-#include 
-#include 
-
 #if (NDEBUG & NDEBUG_LISTS)
 #define LIST(x, y) \
do {\
@@ -517,8 +514,6 @@ static inline int NCR5380_poll_politely(
reg, bit, val, wait);
 }
 
-#include 
-
 #if NDEBUG
 static struct {
unsigned char mask;
Index: linux/drivers/scsi/atari_scsi.c
===
--- linux.orig/drivers/scsi/atari_scsi.c2015-12-22 12:15:56.0 
+1100
+++ linux/drivers/scsi/atari_scsi.c 2015-12-22 12:16:37.0 +1100
@@ -66,7 +66,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
Index: linux/drivers/scsi/dmx3191d.c
===
--- linux.orig/drivers/scsi/dmx3191d.c  2015-12-22 12:15:56.0 +1100
+++ linux/drivers/scsi/dmx3191d.c   2015-12-22 12:16:37.0 +1100
@@ -41,11 +41,6 @@
 
 #define NCR5380_implementation_fields  /* none */
 
-/*
- * Includes needed for NCR5380.[ch] (XXX: Move them to NCR5380.h)
- */
-#include 
-
 #include "NCR5380.h"
 #include "NCR5380.c"
 
Index: linux/drivers/scsi/dtc.c
===
--- linux.orig/drivers/scsi/dtc.c   2015-12-22 12:16:32.0 +1100
+++ linux/drivers/scsi/dtc.c2015-12-22 12:16:37.0 +1100
@@ -46,15 +46,13 @@
 
 
 #include 
-#include 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
 #include 
 #include 
+
 #include "dtc.h"
 #define AUTOPROBE_IRQ
 #include "NCR5380.h"
Index: linux/drivers/scsi/g_NCR5380.c
===
--- linux.orig/drivers/scsi/g_NCR5380.c 2015-12-22 12:16:32.0 +1100
+++ linux/drivers/scsi/g_NCR5380.c  2015-12-22 12:16:37.0 +1100
@@ -63,16 +63,14 @@
 #endif
 
 #include 
-#include 
 #include 
+#include 
 #include 
 #include "g_NCR5380.h"
 #include

[PATCH v3 45/77] ncr5380: Cleanup #include directives

2015-12-21 Thread Finn Thain

Remove unused includes (stat.h, signal.h, proc_fs.h) and move includes
needed by the core drivers into the common header (delay.h etc).

Signed-off-by: Finn Thain 

---
 drivers/scsi/NCR5380.c   |2 --
 drivers/scsi/NCR5380.h   |4 
 drivers/scsi/arm/cumana_1.c  |4 
 drivers/scsi/arm/oak.c   |2 --
 drivers/scsi/atari_NCR5380.c |5 -
 drivers/scsi/atari_scsi.c|1 -
 drivers/scsi/dmx3191d.c  |5 -
 drivers/scsi/dtc.c   |4 +---
 drivers/scsi/g_NCR5380.c |6 ++
 drivers/scsi/mac_scsi.c  |1 -
 drivers/scsi/pas16.c |4 
 drivers/scsi/t128.c  |3 ---
 12 files changed, 7 insertions(+), 34 deletions(-)

Index: linux/drivers/scsi/NCR5380.c
===
--- linux.orig/drivers/scsi/NCR5380.c   2015-12-22 12:16:36.0 +1100
+++ linux/drivers/scsi/NCR5380.c2015-12-22 12:16:37.0 +1100
@@ -79,8 +79,6 @@
  * 4.  Test SCSI-II tagged queueing (I have no devices which support 
  *  tagged queueing)
  */
-#include 
-#include 
 
 #if (NDEBUG & NDEBUG_LISTS)
 #define LIST(x,y) {printk("LINE:%d   Adding %p to %p\n", __LINE__, (void*)(x), 
(void*)(y)); if ((x)==(y)) udelay(5); }
Index: linux/drivers/scsi/NCR5380.h
===
--- linux.orig/drivers/scsi/NCR5380.h   2015-12-22 12:16:32.0 +1100
+++ linux/drivers/scsi/NCR5380.h2015-12-22 12:16:37.0 +1100
@@ -22,8 +22,12 @@
 #ifndef NCR5380_H
 #define NCR5380_H
 
+#include 
 #include 
+#include 
+#include 
 #include 
+#include 
 
 #define NDEBUG_ARBITRATION 0x1
 #define NDEBUG_AUTOSENSE   0x2
Index: linux/drivers/scsi/arm/cumana_1.c
===
--- linux.orig/drivers/scsi/arm/cumana_1.c  2015-12-22 12:16:07.0 
+1100
+++ linux/drivers/scsi/arm/cumana_1.c   2015-12-22 12:16:37.0 +1100
@@ -4,9 +4,7 @@
  * Copyright 1995-2002, Russell King
  */
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 
@@ -15,8 +13,6 @@
 
 #include 
 
-#include 
-
 #define PSEUDO_DMA
 
 #define priv(host) ((struct NCR5380_hostdata 
*)(host)->hostdata)
Index: linux/drivers/scsi/arm/oak.c
===
--- linux.orig/drivers/scsi/arm/oak.c   2015-12-22 12:16:07.0 +1100
+++ linux/drivers/scsi/arm/oak.c2015-12-22 12:16:37.0 +1100
@@ -5,9 +5,7 @@
  */
 
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 
Index: linux/drivers/scsi/atari_NCR5380.c
===
--- linux.orig/drivers/scsi/atari_NCR5380.c 2015-12-22 12:16:36.0 
+1100
+++ linux/drivers/scsi/atari_NCR5380.c  2015-12-22 12:16:37.0 +1100
@@ -68,9 +68,6 @@
 
 /* Adapted for the sun3 by Sam Creasey. */
 
-#include 
-#include 
-
 #if (NDEBUG & NDEBUG_LISTS)
 #define LIST(x, y) \
do {\
@@ -517,8 +514,6 @@ static inline int NCR5380_poll_politely(
reg, bit, val, wait);
 }
 
-#include 
-
 #if NDEBUG
 static struct {
unsigned char mask;
Index: linux/drivers/scsi/atari_scsi.c
===
--- linux.orig/drivers/scsi/atari_scsi.c2015-12-22 12:15:56.0 
+1100
+++ linux/drivers/scsi/atari_scsi.c 2015-12-22 12:16:37.0 +1100
@@ -66,7 +66,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
Index: linux/drivers/scsi/dmx3191d.c
===
--- linux.orig/drivers/scsi/dmx3191d.c  2015-12-22 12:15:56.0 +1100
+++ linux/drivers/scsi/dmx3191d.c   2015-12-22 12:16:37.0 +1100
@@ -41,11 +41,6 @@
 
 #define NCR5380_implementation_fields  /* none */
 
-/*
- * Includes needed for NCR5380.[ch] (XXX: Move them to NCR5380.h)
- */
-#include 
-
 #include "NCR5380.h"
 #include "NCR5380.c"
 
Index: linux/drivers/scsi/dtc.c
===
--- linux.orig/drivers/scsi/dtc.c   2015-12-22 12:16:32.0 +1100
+++ linux/drivers/scsi/dtc.c2015-12-22 12:16:37.0 +1100
@@ -46,15 +46,13 @@
 
 
 #include 
-#include 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
 #include 
 #include 
+
 #include "dtc.h"
 #define AUTOPROBE_IRQ
 #include "NCR5380.h"
Index: linux/drivers/scsi/g_NCR5380.c
===
--- linux.orig/drivers/scsi/g_NCR5380.c 2015-12-22 12:16:32.0 +1100
+++ linux/drivers/scsi/g_NCR5380.c  2015-12-22 12:16:37.0 +1100
@@ -63,16 +63,14 @@
 #endif
 
 #include 
-#include 
 #include 
+#include 
 #include 
 #include

Re: [PATCH v3 45/77] ncr5380: Cleanup #include directives

2015-12-21 Thread Hannes Reinecke


On 12/22/2015 02:18 AM, Finn Thain wrote:

Remove unused includes (stat.h, signal.h, proc_fs.h) and move includes
needed by the core drivers into the common header (delay.h etc).

Signed-off-by: Finn Thain 

---
  drivers/scsi/NCR5380.c   |2 --
  drivers/scsi/NCR5380.h   |4 
  drivers/scsi/arm/cumana_1.c  |4 
  drivers/scsi/arm/oak.c   |2 --
  drivers/scsi/atari_NCR5380.c |5 -
  drivers/scsi/atari_scsi.c|1 -
  drivers/scsi/dmx3191d.c  |5 -
  drivers/scsi/dtc.c   |4 +---
  drivers/scsi/g_NCR5380.c |6 ++
  drivers/scsi/mac_scsi.c  |1 -
  drivers/scsi/pas16.c |4 
  drivers/scsi/t128.c  |3 ---
  12 files changed, 7 insertions(+), 34 deletions(-)


Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
--
Dr. Hannes Reinecke   zSeries & Storage
h...@suse.de  +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v3 45/77] ncr5380: Cleanup #include directives

[PATCH v3 45/77] ncr5380: Cleanup #include directives

[PATCH v3 45/77] ncr5380: Cleanup #include directives

Re: [PATCH v3 45/77] ncr5380: Cleanup #include directives

4 matches

Site Navigation

Mail list logo

Footer information