Re: [PATCH v3 5/8] IB/hfi1: convert to debugfs_file_get() and -put()

[Dennis Dalessandro]

On 10/30/2017 7:15 PM, Nicolai Stange wrote:

Convert all calls to the now obsolete debugfs_use_file_start() and
debugfs_use_file_finish() to the new debugfs_file_get() and
debugfs_file_put() API.

Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private
   data")
Signed-off-by: Nicolai Stange 


Looks OK to me.

Reviewed-by: Dennis Dalessandro 

Re: [PATCH v3 5/8] IB/hfi1: convert to debugfs_file_get() and -put()

[Dennis Dalessandro]

On 10/30/2017 7:15 PM, Nicolai Stange wrote:

Convert all calls to the now obsolete debugfs_use_file_start() and
debugfs_use_file_finish() to the new debugfs_file_get() and
debugfs_file_put() API.

Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private
   data")
Signed-off-by: Nicolai Stange 


Looks OK to me.

Reviewed-by: Dennis Dalessandro 

[PATCH v3 5/8] IB/hfi1: convert to debugfs_file_get() and -put()

[Nicolai Stange]

Convert all calls to the now obsolete debugfs_use_file_start() and
debugfs_use_file_finish() to the new debugfs_file_get() and
debugfs_file_put() API.

Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private
  data")
Signed-off-by: Nicolai Stange 
---
 drivers/infiniband/hw/hfi1/debugfs.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/debugfs.c 
b/drivers/infiniband/hw/hfi1/debugfs.c
index 24128f4e5748..ca03d8b23851 100644
--- a/drivers/infiniband/hw/hfi1/debugfs.c
+++ b/drivers/infiniband/hw/hfi1/debugfs.c
@@ -71,13 +71,13 @@ static ssize_t hfi1_seq_read(
loff_t *ppos)
 {
struct dentry *d = file->f_path.dentry;
-   int srcu_idx;
ssize_t r;
 
-   r = debugfs_use_file_start(d, _idx);
-   if (likely(!r))
-   r = seq_read(file, buf, size, ppos);
-   debugfs_use_file_finish(srcu_idx);
+   r = debugfs_file_get(d);
+   if (unlikely(r))
+   return r;
+   r = seq_read(file, buf, size, ppos);
+   debugfs_file_put(d);
return r;
 }
 
@@ -87,13 +87,13 @@ static loff_t hfi1_seq_lseek(
int whence)
 {
struct dentry *d = file->f_path.dentry;
-   int srcu_idx;
loff_t r;
 
-   r = debugfs_use_file_start(d, _idx);
-   if (likely(!r))
-   r = seq_lseek(file, offset, whence);
-   debugfs_use_file_finish(srcu_idx);
+   r = debugfs_file_get(d);
+   if (unlikely(r))
+   return r;
+   r = seq_lseek(file, offset, whence);
+   debugfs_file_put(d);
return r;
 }
 
-- 
2.13.6

[PATCH v3 5/8] IB/hfi1: convert to debugfs_file_get() and -put()

[Nicolai Stange]

Convert all calls to the now obsolete debugfs_use_file_start() and
debugfs_use_file_finish() to the new debugfs_file_get() and
debugfs_file_put() API.

Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private
  data")
Signed-off-by: Nicolai Stange 
---
 drivers/infiniband/hw/hfi1/debugfs.c | 20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/debugfs.c 
b/drivers/infiniband/hw/hfi1/debugfs.c
index 24128f4e5748..ca03d8b23851 100644
--- a/drivers/infiniband/hw/hfi1/debugfs.c
+++ b/drivers/infiniband/hw/hfi1/debugfs.c
@@ -71,13 +71,13 @@ static ssize_t hfi1_seq_read(
loff_t *ppos)
 {
struct dentry *d = file->f_path.dentry;
-   int srcu_idx;
ssize_t r;
 
-   r = debugfs_use_file_start(d, _idx);
-   if (likely(!r))
-   r = seq_read(file, buf, size, ppos);
-   debugfs_use_file_finish(srcu_idx);
+   r = debugfs_file_get(d);
+   if (unlikely(r))
+   return r;
+   r = seq_read(file, buf, size, ppos);
+   debugfs_file_put(d);
return r;
 }
 
@@ -87,13 +87,13 @@ static loff_t hfi1_seq_lseek(
int whence)
 {
struct dentry *d = file->f_path.dentry;
-   int srcu_idx;
loff_t r;
 
-   r = debugfs_use_file_start(d, _idx);
-   if (likely(!r))
-   r = seq_lseek(file, offset, whence);
-   debugfs_use_file_finish(srcu_idx);
+   r = debugfs_file_get(d);
+   if (unlikely(r))
+   return r;
+   r = seq_lseek(file, offset, whence);
+   debugfs_file_put(d);
return r;
 }
 
-- 
2.13.6