Re: [PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion
On Thu, Aug 27, 2020 at 08:16:54AM +0100, Christoph Hellwig wrote: > On Tue, Aug 25, 2020 at 08:52:29AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Aug 25, 2020 at 07:47:29AM +0100, Christoph Hellwig wrote: > > > On Fri, Aug 21, 2020 at 06:27:04PM +0300, Tomer Samara wrote: > > > > Remove BUG/BUG_ON from androind/ion > > > > > > Please just remove ion. It has been rejected and we have developed > > > proper kernel subsystens to replace it. Don't waste your time on it. > > > > It is going to be removed at the end of this year. Why we keep it > > around until then, I really don't know, but John and Laura have this as > > the plan. > > It keeps getting in the way of various projects and has no path > going upstream properly. Seems weird to keep this dead and not all > that great code around. In looking at the mess of ion changes that are currently in the AOSP kernel tree (where android devices are pulled from), it looks almost nothing like what we currently have here in the mainline kernel tree. So if what we have here, today, is not of use to anyone who actually wants to use this interface, why are we keeping it around? John, why can't we just drop all of this code from the kernel today, and then Android will keep their own copy for their next LTS release anyway. It doesn't look like what we have here, and the merge issues it causes is a pain (as I know from having to do them...) So keeping this around in-tree any longer feels pointless to me, and actively causes me, and others, more work for no gain. I'll go make a patch set to just drop this code now... thanks, greg k-h
Re: [PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion
On Tue, Aug 25, 2020 at 08:52:29AM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 25, 2020 at 07:47:29AM +0100, Christoph Hellwig wrote: > > On Fri, Aug 21, 2020 at 06:27:04PM +0300, Tomer Samara wrote: > > > Remove BUG/BUG_ON from androind/ion > > > > Please just remove ion. It has been rejected and we have developed > > proper kernel subsystens to replace it. Don't waste your time on it. > > It is going to be removed at the end of this year. Why we keep it > around until then, I really don't know, but John and Laura have this as > the plan. It keeps getting in the way of various projects and has no path going upstream properly. Seems weird to keep this dead and not all that great code around.
Re: [PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion
On Tue, Aug 25, 2020 at 07:47:29AM +0100, Christoph Hellwig wrote: > On Fri, Aug 21, 2020 at 06:27:04PM +0300, Tomer Samara wrote: > > Remove BUG/BUG_ON from androind/ion > > Please just remove ion. It has been rejected and we have developed > proper kernel subsystens to replace it. Don't waste your time on it. It is going to be removed at the end of this year. Why we keep it around until then, I really don't know, but John and Laura have this as the plan. thanks, greg k-h
Re: [PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion
On Fri, Aug 21, 2020 at 06:27:04PM +0300, Tomer Samara wrote: > Remove BUG/BUG_ON from androind/ion Please just remove ion. It has been rejected and we have developed proper kernel subsystens to replace it. Don't waste your time on it.
[PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion
Remove BUG/BUG_ON from androind/ion -v4: some changes based on Dan Carpenter review: - Remove error check at ion_page_pool_remove (conditions are impossible) - Remove error check at opn_page_pool_alloc - restore WARN_ON at ion_page_pool_free - Remove unnecessary error check at ion_page_pool_shrink - Add /* This is impossible. */ comment at order_to_index - Remove error handling of order_to_index -v3: remove WARN/WARN_ON as Gerg KH suggests -v2: add error check to order_to_index callers Tomer Samara (2): staging: android: Remove BUG_ON from ion_page_pool.c staging: android: Remove BUG from ion_system_heap.c drivers/staging/android/ion/ion_page_pool.c | 6 +- drivers/staging/android/ion/ion_system_heap.c | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) -- 2.25.1
