Re: [PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver

2017-10-31 Thread Sakari Ailus
On Tue, Oct 31, 2017 at 09:11:42AM +0800, Wenyou Yang wrote:
> Add a Video4Linux2 sensor-level driver for the OmniVision OV7740
> VGA camera image sensor.

Oh, and please wait until the patches have been reviewed, no need to send
v5 before that.

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi


Re: [PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver

2017-10-31 Thread Sakari Ailus
On Tue, Oct 31, 2017 at 09:11:42AM +0800, Wenyou Yang wrote:
> Add a Video4Linux2 sensor-level driver for the OmniVision OV7740
> VGA camera image sensor.

Oh, and please wait until the patches have been reviewed, no need to send
v5 before that.

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi


Re: [PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver

2017-10-31 Thread Sakari Ailus
Hi Wenyou,

On Tue, Oct 31, 2017 at 09:11:42AM +0800, Wenyou Yang wrote:
> Add a Video4Linux2 sensor-level driver for the OmniVision OV7740
> VGA camera image sensor.

For the next version, could you rearrange your patches a bit as follows:

1. DT bindings
2. The driver and MAINTAINERS entry

Putting the MAINTAINERS entry separately from the driver emits a warning
from checkpatch.pl. Bindings are naturally separate from driver and should
precede the driver as the driver musn't use undocumented bindings.

Thanks.

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi


Re: [PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver

2017-10-31 Thread Sakari Ailus
Hi Wenyou,

On Tue, Oct 31, 2017 at 09:11:42AM +0800, Wenyou Yang wrote:
> Add a Video4Linux2 sensor-level driver for the OmniVision OV7740
> VGA camera image sensor.

For the next version, could you rearrange your patches a bit as follows:

1. DT bindings
2. The driver and MAINTAINERS entry

Putting the MAINTAINERS entry separately from the driver emits a warning
from checkpatch.pl. Bindings are naturally separate from driver and should
precede the driver as the driver musn't use undocumented bindings.

Thanks.

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi


[PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver

2017-10-30 Thread Wenyou Yang
Add a Video4Linux2 sensor-level driver for the OmniVision OV7740
VGA camera image sensor.

Changes in v4:
 - Assign 'val' a initial value to avoid warning: 'val' may be
   used uninitialized.
 - Rename REG_REG15 to avoid warning: "REG_REG15" redefined.

Changes in v3:
 - Explicitly document the "remote-endpoint" property.
 - Put the MAINTAINERS change to a separate patch.

Changes in v2:
 - Split off the bindings into a separate patch.
 - Add a new entry to the MAINTAINERS file.

Wenyou Yang (3):
  media: i2c: Add the ov7740 image sensor driver
  media: ov7740: Document device tree bindings
  MAINTAINERS: Add a new entry of the ov7740 driver

 .../devicetree/bindings/media/i2c/ov7740.txt   |   47 +
 MAINTAINERS|8 +
 drivers/media/i2c/Kconfig  |8 +
 drivers/media/i2c/Makefile |1 +
 drivers/media/i2c/ov7740.c | 1220 
 5 files changed, 1284 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov7740.txt
 create mode 100644 drivers/media/i2c/ov7740.c

-- 
2.13.0



[PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver

2017-10-30 Thread Wenyou Yang
Add a Video4Linux2 sensor-level driver for the OmniVision OV7740
VGA camera image sensor.

Changes in v4:
 - Assign 'val' a initial value to avoid warning: 'val' may be
   used uninitialized.
 - Rename REG_REG15 to avoid warning: "REG_REG15" redefined.

Changes in v3:
 - Explicitly document the "remote-endpoint" property.
 - Put the MAINTAINERS change to a separate patch.

Changes in v2:
 - Split off the bindings into a separate patch.
 - Add a new entry to the MAINTAINERS file.

Wenyou Yang (3):
  media: i2c: Add the ov7740 image sensor driver
  media: ov7740: Document device tree bindings
  MAINTAINERS: Add a new entry of the ov7740 driver

 .../devicetree/bindings/media/i2c/ov7740.txt   |   47 +
 MAINTAINERS|8 +
 drivers/media/i2c/Kconfig  |8 +
 drivers/media/i2c/Makefile |1 +
 drivers/media/i2c/ov7740.c | 1220 
 5 files changed, 1284 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ov7740.txt
 create mode 100644 drivers/media/i2c/ov7740.c

-- 
2.13.0