Re: [PATCH v4 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes
On Tue, Aug 21, 2018 at 01:43:18PM -0700, Andrew Morton wrote: > On Tue, 21 Aug 2018 18:21:22 +0200 Oscar Salvador > wrote: > > > On Fri, Aug 17, 2018 at 11:00:13AM +0200, Oscar Salvador wrote: > > > From: Oscar Salvador > > > > > > v3 -> v4: > > > - Make nodemask_t a stack variable > > > - Added Reviewed-by from David and Pavel > > > > > > v2 -> v3: > > > - NODEMASK_FREE can deal with NULL pointers, so do not > > > make it conditional (by David). > > > - Split up node_online's check patch (David's suggestion) > > > - Added Reviewed-by from Andrew and David > > > - Fix checkpath.pl warnings > > > > Andrew, will you pick up this patchset? > > I saw that v3 was removed from the -mm tree because it was about > > to be updated with a new version (this one), but I am not sure if > > anything wrong happened. > > Yes, things are still changing and we're late in the merge window. I > decided to park it and shall take it up again after 4.19-rc1. Hi Andrew, I just got the Reviewed-by from Pavel for patch3. So you may consider it for -mm when you got some time. Thanks -- Oscar Salvador SUSE L3
Re: [PATCH v4 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes
On Tue, 21 Aug 2018 18:21:22 +0200 Oscar Salvador wrote: > On Fri, Aug 17, 2018 at 11:00:13AM +0200, Oscar Salvador wrote: > > From: Oscar Salvador > > > > v3 -> v4: > > - Make nodemask_t a stack variable > > - Added Reviewed-by from David and Pavel > > > > v2 -> v3: > > - NODEMASK_FREE can deal with NULL pointers, so do not > > make it conditional (by David). > > - Split up node_online's check patch (David's suggestion) > > - Added Reviewed-by from Andrew and David > > - Fix checkpath.pl warnings > > Andrew, will you pick up this patchset? > I saw that v3 was removed from the -mm tree because it was about > to be updated with a new version (this one), but I am not sure if > anything wrong happened. Yes, things are still changing and we're late in the merge window. I decided to park it and shall take it up again after 4.19-rc1.
Re: [PATCH v4 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes
On Fri, Aug 17, 2018 at 11:00:13AM +0200, Oscar Salvador wrote: > From: Oscar Salvador > > v3 -> v4: > - Make nodemask_t a stack variable > - Added Reviewed-by from David and Pavel > > v2 -> v3: > - NODEMASK_FREE can deal with NULL pointers, so do not > make it conditional (by David). > - Split up node_online's check patch (David's suggestion) > - Added Reviewed-by from Andrew and David > - Fix checkpath.pl warnings Andrew, will you pick up this patchset? I saw that v3 was removed from the -mm tree because it was about to be updated with a new version (this one), but I am not sure if anything wrong happened. Thanks -- Oscar Salvador SUSE L3
[PATCH v4 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes
From: Oscar Salvador v3 -> v4: - Make nodemask_t a stack variable - Added Reviewed-by from David and Pavel v2 -> v3: - NODEMASK_FREE can deal with NULL pointers, so do not make it conditional (by David). - Split up node_online's check patch (David's suggestion) - Added Reviewed-by from Andrew and David - Fix checkpath.pl warnings This patchset does some cleanups and refactoring in the memory-hotplug code. The first and the second patch are pretty straightforward, as they only remove unused arguments/checks. The third patch refactors unregister_mem_sect_under_nodes a bit by re-defining nodemask_t as a stack variable. (More details in Patch3's changelog) The fourth patch removes a node_online check. (More details in Patch4's changelog) Since this change has a patch for itself, we could quickly revert it if we notice that something is wrong with it, or drop it if people are concerned about it. Oscar Salvador (4): mm/memory-hotplug: Drop unused args from remove_memory_section mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes mm/memory_hotplug: Define nodemask_t as a stack variable mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes drivers/base/memory.c | 5 ++--- drivers/base/node.c | 22 ++ include/linux/node.h | 5 ++--- 3 files changed, 10 insertions(+), 22 deletions(-) -- 2.13.6
