Re: [PATCH v4 0/4] ata: libahci: Allow using a regulator for each port

2015-01-19 Thread Andrew Lunn
On Mon, Jan 19, 2015 at 09:54:13AM -0500, Tejun Heo wrote:
> On Fri, Jan 16, 2015 at 08:58:18AM +0100, Hans de Goede wrote:
> > Hi,
> > 
> > On 15-01-15 15:09, Gregory CLEMENT wrote:
> > >The current implementation of the libahci allows using one PHY per
> > >port but we still have one single regulator for the whole
> > >controller. This series adds the support of multiple regulators.
> > >
> > >This is the forth version of the series.
> > >
> > >The improvement of this version is the use of
> > >ahci_platform_put_resources to put the reference to the regulators.
> > >
> > >Thanks,
> > >
> > >Grégory
> > 
> > Thanks, patches 1 - 3 look good and are:
> > 
> > Acked-by: Hans de Goede 
> > 
> > Tejun, can you please queue up 1 - 3 ?
> 
> Applied 1-3 to libata/for-3.20.

Thanks

I will add 4/4 to mvebu/dt.

  Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v4 0/4] ata: libahci: Allow using a regulator for each port

2015-01-19 Thread Tejun Heo
On Fri, Jan 16, 2015 at 08:58:18AM +0100, Hans de Goede wrote:
> Hi,
> 
> On 15-01-15 15:09, Gregory CLEMENT wrote:
> >The current implementation of the libahci allows using one PHY per
> >port but we still have one single regulator for the whole
> >controller. This series adds the support of multiple regulators.
> >
> >This is the forth version of the series.
> >
> >The improvement of this version is the use of
> >ahci_platform_put_resources to put the reference to the regulators.
> >
> >Thanks,
> >
> >Grégory
> 
> Thanks, patches 1 - 3 look good and are:
> 
> Acked-by: Hans de Goede 
> 
> Tejun, can you please queue up 1 - 3 ?

Applied 1-3 to libata/for-3.20.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v4 0/4] ata: libahci: Allow using a regulator for each port

2015-01-19 Thread Andrew Lunn
On Mon, Jan 19, 2015 at 09:54:13AM -0500, Tejun Heo wrote:
 On Fri, Jan 16, 2015 at 08:58:18AM +0100, Hans de Goede wrote:
  Hi,
  
  On 15-01-15 15:09, Gregory CLEMENT wrote:
  The current implementation of the libahci allows using one PHY per
  port but we still have one single regulator for the whole
  controller. This series adds the support of multiple regulators.
  
  This is the forth version of the series.
  
  The improvement of this version is the use of
  ahci_platform_put_resources to put the reference to the regulators.
  
  Thanks,
  
  Grégory
  
  Thanks, patches 1 - 3 look good and are:
  
  Acked-by: Hans de Goede hdego...@redhat.com
  
  Tejun, can you please queue up 1 - 3 ?
 
 Applied 1-3 to libata/for-3.20.

Thanks

I will add 4/4 to mvebu/dt.

  Andrew
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v4 0/4] ata: libahci: Allow using a regulator for each port

2015-01-19 Thread Tejun Heo
On Fri, Jan 16, 2015 at 08:58:18AM +0100, Hans de Goede wrote:
 Hi,
 
 On 15-01-15 15:09, Gregory CLEMENT wrote:
 The current implementation of the libahci allows using one PHY per
 port but we still have one single regulator for the whole
 controller. This series adds the support of multiple regulators.
 
 This is the forth version of the series.
 
 The improvement of this version is the use of
 ahci_platform_put_resources to put the reference to the regulators.
 
 Thanks,
 
 Grégory
 
 Thanks, patches 1 - 3 look good and are:
 
 Acked-by: Hans de Goede hdego...@redhat.com
 
 Tejun, can you please queue up 1 - 3 ?

Applied 1-3 to libata/for-3.20.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v4 0/4] ata: libahci: Allow using a regulator for each port

2015-01-16 Thread Hans de Goede

Hi,

On 15-01-15 15:09, Gregory CLEMENT wrote:

The current implementation of the libahci allows using one PHY per
port but we still have one single regulator for the whole
controller. This series adds the support of multiple regulators.

This is the forth version of the series.

The improvement of this version is the use of
ahci_platform_put_resources to put the reference to the regulators.

Thanks,

Grégory


Thanks, patches 1 - 3 look good and are:

Acked-by: Hans de Goede 

Tejun, can you please queue up 1 - 3 ?

I still have some remarks wrt patch 4 (*), and it should probably go
upstream through another tree anyways.

Regards,

Hans


*) I didn't look closely at patch 4 as it seemed trivial, until now
that is ...





Changelog:

  v3 -> v4
- Moved putting the reference to the regulators into the
   ahci_platform_put_resources function.
- Tested the port_dev pointer before dereferencing.

  v2 -> v3:
- put back the regulator inside the sub-node ports
- made the ports platform devices when the device tree is used
- released the regulator in case of error in the probe function

  v1 -> v2:
- Kept the case when no child node are present under the ahci node
- Fix the test done under the label disable_target_pwrs
- No more use an of_ version of the regulator framework and instead
   associate each regulator of a port with an unique name.
- Added the acked-by on the clean-up patch

Gregory CLEMENT (4):
   ata: libahci: Clean-up the ahci_platform_en/disable_phys functions
   Documentation: bindings: Add the regulator property to the sub-nodes
 AHCI bindings
   ata: libahci: Allow using multiple regulators
   ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

  .../devicetree/bindings/ata/ahci-platform.txt  |   9 +-
  arch/arm/boot/dts/armada-388-gp.dts| 126 +++
  drivers/ata/ahci.h |   2 +-
  drivers/ata/ahci_imx.c |  14 +-
  drivers/ata/libahci_platform.c | 236 ++---
  include/linux/ahci_platform.h  |   2 +
  6 files changed, 305 insertions(+), 84 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH v4 0/4] ata: libahci: Allow using a regulator for each port

2015-01-16 Thread Hans de Goede

Hi,

On 15-01-15 15:09, Gregory CLEMENT wrote:

The current implementation of the libahci allows using one PHY per
port but we still have one single regulator for the whole
controller. This series adds the support of multiple regulators.

This is the forth version of the series.

The improvement of this version is the use of
ahci_platform_put_resources to put the reference to the regulators.

Thanks,

Grégory


Thanks, patches 1 - 3 look good and are:

Acked-by: Hans de Goede hdego...@redhat.com

Tejun, can you please queue up 1 - 3 ?

I still have some remarks wrt patch 4 (*), and it should probably go
upstream through another tree anyways.

Regards,

Hans


*) I didn't look closely at patch 4 as it seemed trivial, until now
that is ...





Changelog:

  v3 - v4
- Moved putting the reference to the regulators into the
   ahci_platform_put_resources function.
- Tested the port_dev pointer before dereferencing.

  v2 - v3:
- put back the regulator inside the sub-node ports
- made the ports platform devices when the device tree is used
- released the regulator in case of error in the probe function

  v1 - v2:
- Kept the case when no child node are present under the ahci node
- Fix the test done under the label disable_target_pwrs
- No more use an of_ version of the regulator framework and instead
   associate each regulator of a port with an unique name.
- Added the acked-by on the clean-up patch

Gregory CLEMENT (4):
   ata: libahci: Clean-up the ahci_platform_en/disable_phys functions
   Documentation: bindings: Add the regulator property to the sub-nodes
 AHCI bindings
   ata: libahci: Allow using multiple regulators
   ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

  .../devicetree/bindings/ata/ahci-platform.txt  |   9 +-
  arch/arm/boot/dts/armada-388-gp.dts| 126 +++
  drivers/ata/ahci.h |   2 +-
  drivers/ata/ahci_imx.c |  14 +-
  drivers/ata/libahci_platform.c | 236 ++---
  include/linux/ahci_platform.h  |   2 +
  6 files changed, 305 insertions(+), 84 deletions(-)


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH v4 0/4] ata: libahci: Allow using a regulator for each port

2015-01-15 Thread Gregory CLEMENT
The current implementation of the libahci allows using one PHY per
port but we still have one single regulator for the whole
controller. This series adds the support of multiple regulators.

This is the forth version of the series.

The improvement of this version is the use of
ahci_platform_put_resources to put the reference to the regulators.

Thanks,

Gr??gory

Changelog:

 v3 -> v4
- Moved putting the reference to the regulators into the
  ahci_platform_put_resources function.
- Tested the port_dev pointer before dereferencing.

 v2 -> v3:
- put back the regulator inside the sub-node ports
- made the ports platform devices when the device tree is used
- released the regulator in case of error in the probe function

 v1 -> v2:
- Kept the case when no child node are present under the ahci node
- Fix the test done under the label disable_target_pwrs
- No more use an of_ version of the regulator framework and instead
  associate each regulator of a port with an unique name.
- Added the acked-by on the clean-up patch

Gregory CLEMENT (4):
  ata: libahci: Clean-up the ahci_platform_en/disable_phys functions
  Documentation: bindings: Add the regulator property to the sub-nodes
AHCI bindings
  ata: libahci: Allow using multiple regulators
  ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

 .../devicetree/bindings/ata/ahci-platform.txt  |   9 +-
 arch/arm/boot/dts/armada-388-gp.dts| 126 +++
 drivers/ata/ahci.h |   2 +-
 drivers/ata/ahci_imx.c |  14 +-
 drivers/ata/libahci_platform.c | 236 ++---
 include/linux/ahci_platform.h  |   2 +
 6 files changed, 305 insertions(+), 84 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH v4 0/4] ata: libahci: Allow using a regulator for each port

2015-01-15 Thread Gregory CLEMENT
The current implementation of the libahci allows using one PHY per
port but we still have one single regulator for the whole
controller. This series adds the support of multiple regulators.

This is the forth version of the series.

The improvement of this version is the use of
ahci_platform_put_resources to put the reference to the regulators.

Thanks,

Gr??gory

Changelog:

 v3 - v4
- Moved putting the reference to the regulators into the
  ahci_platform_put_resources function.
- Tested the port_dev pointer before dereferencing.

 v2 - v3:
- put back the regulator inside the sub-node ports
- made the ports platform devices when the device tree is used
- released the regulator in case of error in the probe function

 v1 - v2:
- Kept the case when no child node are present under the ahci node
- Fix the test done under the label disable_target_pwrs
- No more use an of_ version of the regulator framework and instead
  associate each regulator of a port with an unique name.
- Added the acked-by on the clean-up patch

Gregory CLEMENT (4):
  ata: libahci: Clean-up the ahci_platform_en/disable_phys functions
  Documentation: bindings: Add the regulator property to the sub-nodes
AHCI bindings
  ata: libahci: Allow using multiple regulators
  ARM: mvebu: Armada 385 GP: Add regulators to the SATA port

 .../devicetree/bindings/ata/ahci-platform.txt  |   9 +-
 arch/arm/boot/dts/armada-388-gp.dts| 126 +++
 drivers/ata/ahci.h |   2 +-
 drivers/ata/ahci_imx.c |  14 +-
 drivers/ata/libahci_platform.c | 236 ++---
 include/linux/ahci_platform.h  |   2 +
 6 files changed, 305 insertions(+), 84 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/