Re: [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
On 09/03/2013 08:31 PM, Alex Courbot wrote: > On 09/04/2013 03:42 AM, Stephen Warren wrote: >> On 08/29/2013 03:57 AM, Alexandre Courbot wrote: >>> New version revised according to comments received for v3. Hopefully >>> it will be good enough to be merged. >> >> Aside from the small issue in patch 1/5, the series, >> Reviewed-by: Stephen Warren > > Thanks! I have adressed the issues you mentioned and will submit v5 > soon. Despite the fact this adds some non-Tegra stuff, will you be able > to take it into your tree, or should I ask someone else? I would like to see an ack from the core ARM maintainer (Russell) on patch 1/5 (also CC'ing arm-soc maintainers for their opinion). If I get that, I think it makes sense to take the series through the Tegra tree. I can always create a stable branch for patch 1/5 if needed to resolve conflicts elsewhere (e.g. Russell's trees or arm-soc) and/or allow other people to build on top of that patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
On 09/03/2013 08:31 PM, Alex Courbot wrote: On 09/04/2013 03:42 AM, Stephen Warren wrote: On 08/29/2013 03:57 AM, Alexandre Courbot wrote: New version revised according to comments received for v3. Hopefully it will be good enough to be merged. Aside from the small issue in patch 1/5, the series, Reviewed-by: Stephen Warren swar...@nvidia.com Thanks! I have adressed the issues you mentioned and will submit v5 soon. Despite the fact this adds some non-Tegra stuff, will you be able to take it into your tree, or should I ask someone else? I would like to see an ack from the core ARM maintainer (Russell) on patch 1/5 (also CC'ing arm-soc maintainers for their opinion). If I get that, I think it makes sense to take the series through the Tegra tree. I can always create a stable branch for patch 1/5 if needed to resolve conflicts elsewhere (e.g. Russell's trees or arm-soc) and/or allow other people to build on top of that patch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
On 09/04/2013 03:42 AM, Stephen Warren wrote: On 08/29/2013 03:57 AM, Alexandre Courbot wrote: New version revised according to comments received for v3. Hopefully it will be good enough to be merged. Aside from the small issue in patch 1/5, the series, Reviewed-by: Stephen Warren Thanks! I have adressed the issues you mentioned and will submit v5 soon. Despite the fact this adds some non-Tegra stuff, will you be able to take it into your tree, or should I ask someone else? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
On 08/29/2013 03:57 AM, Alexandre Courbot wrote: > New version revised according to comments received for v3. Hopefully > it will be good enough to be merged. Aside from the small issue in patch 1/5, the series, Reviewed-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
On 08/29/2013 03:57 AM, Alexandre Courbot wrote: New version revised according to comments received for v3. Hopefully it will be good enough to be merged. Aside from the small issue in patch 1/5, the series, Reviewed-by: Stephen Warren swar...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
On 09/04/2013 03:42 AM, Stephen Warren wrote: On 08/29/2013 03:57 AM, Alexandre Courbot wrote: New version revised according to comments received for v3. Hopefully it will be good enough to be merged. Aside from the small issue in patch 1/5, the series, Reviewed-by: Stephen Warren swar...@nvidia.com Thanks! I have adressed the issues you mentioned and will submit v5 soon. Despite the fact this adds some non-Tegra stuff, will you be able to take it into your tree, or should I ask someone else? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
Hi Alexandre, On Thursday 29 of August 2013 18:57:43 Alexandre Courbot wrote: > New version revised according to comments received for v3. Hopefully > it will be good enough to be merged. > > Changes since v3: > - Added of_register_trusted_foundations() function to avoid duplicate > device tree parsing code in arch files > - Added ability to initialize Trusted Foundations through platform data > - Changed TF version number to integers > - Refactored Kconfig menu for more clarity Except some minor comments to patch 1/5, the series looks good to me. Reviewed-by: Tomasz Figa Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
Hi Alexandre, On Thursday 29 of August 2013 18:57:43 Alexandre Courbot wrote: New version revised according to comments received for v3. Hopefully it will be good enough to be merged. Changes since v3: - Added of_register_trusted_foundations() function to avoid duplicate device tree parsing code in arch files - Added ability to initialize Trusted Foundations through platform data - Changed TF version number to integers - Refactored Kconfig menu for more clarity Except some minor comments to patch 1/5, the series looks good to me. Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
New version revised according to comments received for v3. Hopefully it will be good enough to be merged. Changes since v3: - Added of_register_trusted_foundations() function to avoid duplicate device tree parsing code in arch files - Added ability to initialize Trusted Foundations through platform data - Changed TF version number to integers - Refactored Kconfig menu for more clarity A few requests could not reasonably be implemented: TF version probing at runtime (requested by Dave) seems impossible unfortunately. TF just does not provide an interface that allows such queries. In the downstream Tegra kernel the TF version is even hardcoded into the kernel. Use of a firmware_op instance for non-firmware behavior (requested by Stephen) would make it necessary to have a dedicated non-firmware registration function that takes implementations from various different files and would require these implementations to be exported. Checking the return code of call_firmware_op() at call sites seems to be easier to handle and is how current users of firmware_ops do. Alexandre Courbot (5): ARM: add basic Trusted Foundations support ARM: tegra: add support for Trusted Foundations ARM: tegra: split setting of CPU reset handler ARM: tegra: set CPU reset handler with firmware op ARM: tegra: support Trusted Foundations by default .../arm/firmware/tl,trusted-foundations.txt| 17 + Documentation/devicetree/bindings/arm/tegra.txt| 5 ++ .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/arm/Kconfig | 2 + arch/arm/Makefile | 1 + arch/arm/configs/tegra_defconfig | 1 + arch/arm/firmware/Kconfig | 26 +++ arch/arm/firmware/Makefile | 1 + arch/arm/firmware/trusted_foundations.c| 83 ++ arch/arm/include/asm/trusted_foundations.h | 48 + arch/arm/mach-tegra/Kconfig| 1 + arch/arm/mach-tegra/common.c | 2 + arch/arm/mach-tegra/reset.c| 40 --- 13 files changed, 217 insertions(+), 11 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/firmware/tl,trusted-foundations.txt create mode 100644 arch/arm/firmware/Kconfig create mode 100644 arch/arm/firmware/Makefile create mode 100644 arch/arm/firmware/trusted_foundations.c create mode 100644 arch/arm/include/asm/trusted_foundations.h -- 1.8.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4 0/5] ARM: tegra: support for Trusted Foundations
New version revised according to comments received for v3. Hopefully it will be good enough to be merged. Changes since v3: - Added of_register_trusted_foundations() function to avoid duplicate device tree parsing code in arch files - Added ability to initialize Trusted Foundations through platform data - Changed TF version number to integers - Refactored Kconfig menu for more clarity A few requests could not reasonably be implemented: TF version probing at runtime (requested by Dave) seems impossible unfortunately. TF just does not provide an interface that allows such queries. In the downstream Tegra kernel the TF version is even hardcoded into the kernel. Use of a firmware_op instance for non-firmware behavior (requested by Stephen) would make it necessary to have a dedicated non-firmware registration function that takes implementations from various different files and would require these implementations to be exported. Checking the return code of call_firmware_op() at call sites seems to be easier to handle and is how current users of firmware_ops do. Alexandre Courbot (5): ARM: add basic Trusted Foundations support ARM: tegra: add support for Trusted Foundations ARM: tegra: split setting of CPU reset handler ARM: tegra: set CPU reset handler with firmware op ARM: tegra: support Trusted Foundations by default .../arm/firmware/tl,trusted-foundations.txt| 17 + Documentation/devicetree/bindings/arm/tegra.txt| 5 ++ .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/arm/Kconfig | 2 + arch/arm/Makefile | 1 + arch/arm/configs/tegra_defconfig | 1 + arch/arm/firmware/Kconfig | 26 +++ arch/arm/firmware/Makefile | 1 + arch/arm/firmware/trusted_foundations.c| 83 ++ arch/arm/include/asm/trusted_foundations.h | 48 + arch/arm/mach-tegra/Kconfig| 1 + arch/arm/mach-tegra/common.c | 2 + arch/arm/mach-tegra/reset.c| 40 --- 13 files changed, 217 insertions(+), 11 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm/firmware/tl,trusted-foundations.txt create mode 100644 arch/arm/firmware/Kconfig create mode 100644 arch/arm/firmware/Makefile create mode 100644 arch/arm/firmware/trusted_foundations.c create mode 100644 arch/arm/include/asm/trusted_foundations.h -- 1.8.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
