Re: [PATCH v4 0/7] clean up redundant 'kvm_run' parameters
On 23/06/20 12:00, Tianjia Zhang wrote: > > > On 2020/6/23 17:42, Paolo Bonzini wrote: >> On 27/04/20 06:35, Tianjia Zhang wrote: >>> In the current kvm version, 'kvm_run' has been included in the >>> 'kvm_vcpu' >>> structure. For historical reasons, many kvm-related function parameters >>> retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This >>> patch does a unified cleanup of these remaining redundant parameters. >>> >>> This series of patches has completely cleaned the architecture of >>> arm64, mips, ppc, and s390 (no such redundant code on x86). Due to >>> the large number of modified codes, a separate patch is made for each >>> platform. On the ppc platform, there is also a redundant structure >>> pointer of 'kvm_run' in 'vcpu_arch', which has also been cleaned >>> separately. >> >> Tianjia, can you please refresh the patches so that each architecture >> maintainer can pick them up? Thanks very much for this work! >> >> Paolo >> > > No problem, this is what I should do. > After I update, do I submit separately for each architecture or submit > them together in a patchset? You can send them together. Paolo
Re: [PATCH v4 0/7] clean up redundant 'kvm_run' parameters
On 2020/6/23 17:42, Paolo Bonzini wrote: On 27/04/20 06:35, Tianjia Zhang wrote: In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This patch does a unified cleanup of these remaining redundant parameters. This series of patches has completely cleaned the architecture of arm64, mips, ppc, and s390 (no such redundant code on x86). Due to the large number of modified codes, a separate patch is made for each platform. On the ppc platform, there is also a redundant structure pointer of 'kvm_run' in 'vcpu_arch', which has also been cleaned separately. Tianjia, can you please refresh the patches so that each architecture maintainer can pick them up? Thanks very much for this work! Paolo No problem, this is what I should do. After I update, do I submit separately for each architecture or submit them together in a patchset? Thanks, Tianjia
Re: [PATCH v4 0/7] clean up redundant 'kvm_run' parameters
On 27/04/20 06:35, Tianjia Zhang wrote: > In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' > structure. For historical reasons, many kvm-related function parameters > retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This > patch does a unified cleanup of these remaining redundant parameters. > > This series of patches has completely cleaned the architecture of > arm64, mips, ppc, and s390 (no such redundant code on x86). Due to > the large number of modified codes, a separate patch is made for each > platform. On the ppc platform, there is also a redundant structure > pointer of 'kvm_run' in 'vcpu_arch', which has also been cleaned > separately. Tianjia, can you please refresh the patches so that each architecture maintainer can pick them up? Thanks very much for this work! Paolo > > --- > v4 change: > mips: fixes two errors in entry.c. > > v3 change: > Keep the existing `vcpu->run` in the function body unchanged. > > v2 change: > s390 retains the original variable name and minimizes modification. > > Tianjia Zhang (7): > KVM: s390: clean up redundant 'kvm_run' parameters > KVM: arm64: clean up redundant 'kvm_run' parameters > KVM: PPC: Remove redundant kvm_run from vcpu_arch > KVM: PPC: clean up redundant 'kvm_run' parameters > KVM: PPC: clean up redundant kvm_run parameters in assembly > KVM: MIPS: clean up redundant 'kvm_run' parameters > KVM: MIPS: clean up redundant kvm_run parameters in assembly > > arch/arm64/include/asm/kvm_coproc.h | 12 +-- > arch/arm64/include/asm/kvm_host.h| 11 +-- > arch/arm64/include/asm/kvm_mmu.h | 2 +- > arch/arm64/kvm/handle_exit.c | 36 +++ > arch/arm64/kvm/sys_regs.c| 13 ++- > arch/mips/include/asm/kvm_host.h | 32 +-- > arch/mips/kvm/emulate.c | 59 > arch/mips/kvm/entry.c| 21 ++--- > arch/mips/kvm/mips.c | 14 +-- > arch/mips/kvm/trap_emul.c| 114 ++- > arch/mips/kvm/vz.c | 26 ++ > arch/powerpc/include/asm/kvm_book3s.h| 16 ++-- > arch/powerpc/include/asm/kvm_host.h | 1 - > arch/powerpc/include/asm/kvm_ppc.h | 27 +++--- > arch/powerpc/kvm/book3s.c| 4 +- > arch/powerpc/kvm/book3s.h| 2 +- > arch/powerpc/kvm/book3s_64_mmu_hv.c | 12 +-- > arch/powerpc/kvm/book3s_64_mmu_radix.c | 4 +- > arch/powerpc/kvm/book3s_emulate.c| 10 +- > arch/powerpc/kvm/book3s_hv.c | 64 ++--- > arch/powerpc/kvm/book3s_hv_nested.c | 12 +-- > arch/powerpc/kvm/book3s_interrupts.S | 17 ++-- > arch/powerpc/kvm/book3s_paired_singles.c | 72 +++--- > arch/powerpc/kvm/book3s_pr.c | 33 --- > arch/powerpc/kvm/booke.c | 39 > arch/powerpc/kvm/booke.h | 8 +- > arch/powerpc/kvm/booke_emulate.c | 2 +- > arch/powerpc/kvm/booke_interrupts.S | 9 +- > arch/powerpc/kvm/bookehv_interrupts.S| 10 +- > arch/powerpc/kvm/e500_emulate.c | 15 ++- > arch/powerpc/kvm/emulate.c | 10 +- > arch/powerpc/kvm/emulate_loadstore.c | 32 +++ > arch/powerpc/kvm/powerpc.c | 72 +++--- > arch/powerpc/kvm/trace_hv.h | 6 +- > arch/s390/kvm/kvm-s390.c | 23 +++-- > virt/kvm/arm/arm.c | 6 +- > virt/kvm/arm/mmio.c | 11 ++- > virt/kvm/arm/mmu.c | 5 +- > 38 files changed, 392 insertions(+), 470 deletions(-) >
Re: [PATCH v4 0/7] clean up redundant 'kvm_run' parameters
Paolo Bonzini, any opinion on this? Thanks and best, Tianjia On 2020/4/27 12:35, Tianjia Zhang wrote: In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This patch does a unified cleanup of these remaining redundant parameters. This series of patches has completely cleaned the architecture of arm64, mips, ppc, and s390 (no such redundant code on x86). Due to the large number of modified codes, a separate patch is made for each platform. On the ppc platform, there is also a redundant structure pointer of 'kvm_run' in 'vcpu_arch', which has also been cleaned separately. --- v4 change: mips: fixes two errors in entry.c. v3 change: Keep the existing `vcpu->run` in the function body unchanged. v2 change: s390 retains the original variable name and minimizes modification. Tianjia Zhang (7): KVM: s390: clean up redundant 'kvm_run' parameters KVM: arm64: clean up redundant 'kvm_run' parameters KVM: PPC: Remove redundant kvm_run from vcpu_arch KVM: PPC: clean up redundant 'kvm_run' parameters KVM: PPC: clean up redundant kvm_run parameters in assembly KVM: MIPS: clean up redundant 'kvm_run' parameters KVM: MIPS: clean up redundant kvm_run parameters in assembly arch/arm64/include/asm/kvm_coproc.h | 12 +-- arch/arm64/include/asm/kvm_host.h| 11 +-- arch/arm64/include/asm/kvm_mmu.h | 2 +- arch/arm64/kvm/handle_exit.c | 36 +++ arch/arm64/kvm/sys_regs.c| 13 ++- arch/mips/include/asm/kvm_host.h | 32 +-- arch/mips/kvm/emulate.c | 59 arch/mips/kvm/entry.c| 21 ++--- arch/mips/kvm/mips.c | 14 +-- arch/mips/kvm/trap_emul.c| 114 ++- arch/mips/kvm/vz.c | 26 ++ arch/powerpc/include/asm/kvm_book3s.h| 16 ++-- arch/powerpc/include/asm/kvm_host.h | 1 - arch/powerpc/include/asm/kvm_ppc.h | 27 +++--- arch/powerpc/kvm/book3s.c| 4 +- arch/powerpc/kvm/book3s.h| 2 +- arch/powerpc/kvm/book3s_64_mmu_hv.c | 12 +-- arch/powerpc/kvm/book3s_64_mmu_radix.c | 4 +- arch/powerpc/kvm/book3s_emulate.c| 10 +- arch/powerpc/kvm/book3s_hv.c | 64 ++--- arch/powerpc/kvm/book3s_hv_nested.c | 12 +-- arch/powerpc/kvm/book3s_interrupts.S | 17 ++-- arch/powerpc/kvm/book3s_paired_singles.c | 72 +++--- arch/powerpc/kvm/book3s_pr.c | 33 --- arch/powerpc/kvm/booke.c | 39 arch/powerpc/kvm/booke.h | 8 +- arch/powerpc/kvm/booke_emulate.c | 2 +- arch/powerpc/kvm/booke_interrupts.S | 9 +- arch/powerpc/kvm/bookehv_interrupts.S| 10 +- arch/powerpc/kvm/e500_emulate.c | 15 ++- arch/powerpc/kvm/emulate.c | 10 +- arch/powerpc/kvm/emulate_loadstore.c | 32 +++ arch/powerpc/kvm/powerpc.c | 72 +++--- arch/powerpc/kvm/trace_hv.h | 6 +- arch/s390/kvm/kvm-s390.c | 23 +++-- virt/kvm/arm/arm.c | 6 +- virt/kvm/arm/mmio.c | 11 ++- virt/kvm/arm/mmu.c | 5 +- 38 files changed, 392 insertions(+), 470 deletions(-)
