[PATCH v4 04/10] net/macb: remove macb_get_drvinfo()

2012-10-31 Thread Nicolas Ferre
This function has little meaning so remove it altogether and
let ethtool core fill in the fields automatically.

Signed-off-by: Nicolas Ferre 
Reviewed-by: Ben Hutchings 
Tested-by: Joachim Eastwood 
---
 drivers/net/ethernet/cadence/macb.c | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb.c 
b/drivers/net/ethernet/cadence/macb.c
index b161d73..4db52f3 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1225,20 +1225,9 @@ static int macb_set_settings(struct net_device *dev, 
struct ethtool_cmd *cmd)
return phy_ethtool_sset(phydev, cmd);
 }
 
-static void macb_get_drvinfo(struct net_device *dev,
-struct ethtool_drvinfo *info)
-{
-   struct macb *bp = netdev_priv(dev);
-
-   strcpy(info->driver, bp->pdev->dev.driver->name);
-   strcpy(info->version, "$Revision: 1.14 $");
-   strcpy(info->bus_info, dev_name(>pdev->dev));
-}
-
 const struct ethtool_ops macb_ethtool_ops = {
.get_settings   = macb_get_settings,
.set_settings   = macb_set_settings,
-   .get_drvinfo= macb_get_drvinfo,
.get_link   = ethtool_op_get_link,
.get_ts_info= ethtool_op_get_ts_info,
 };
-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH v4 04/10] net/macb: remove macb_get_drvinfo()

2012-10-31 Thread Nicolas Ferre
This function has little meaning so remove it altogether and
let ethtool core fill in the fields automatically.

Signed-off-by: Nicolas Ferre nicolas.fe...@atmel.com
Reviewed-by: Ben Hutchings bhutchi...@solarflare.com
Tested-by: Joachim Eastwood manab...@gmail.com
---
 drivers/net/ethernet/cadence/macb.c | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/drivers/net/ethernet/cadence/macb.c 
b/drivers/net/ethernet/cadence/macb.c
index b161d73..4db52f3 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1225,20 +1225,9 @@ static int macb_set_settings(struct net_device *dev, 
struct ethtool_cmd *cmd)
return phy_ethtool_sset(phydev, cmd);
 }
 
-static void macb_get_drvinfo(struct net_device *dev,
-struct ethtool_drvinfo *info)
-{
-   struct macb *bp = netdev_priv(dev);
-
-   strcpy(info-driver, bp-pdev-dev.driver-name);
-   strcpy(info-version, $Revision: 1.14 $);
-   strcpy(info-bus_info, dev_name(bp-pdev-dev));
-}
-
 const struct ethtool_ops macb_ethtool_ops = {
.get_settings   = macb_get_settings,
.set_settings   = macb_set_settings,
-   .get_drvinfo= macb_get_drvinfo,
.get_link   = ethtool_op_get_link,
.get_ts_info= ethtool_op_get_ts_info,
 };
-- 
1.8.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/