[PATCH v4 1/4] ata: libahci: Clean-up the ahci_platform_en/disable_phys functions

2015-01-15 Thread Gregory CLEMENT 
The phy_ functions handle the NULL pointer case, so there is no need
to skip them if there is a NULL pointer. Moreover, after the error
label there is already no check on the pointer. This patch removes the
unnecessary tests and brings some consistency.

Signed-off-by: Gregory CLEMENT 
Acked-by: Hans de Goede 
---
 drivers/ata/libahci_platform.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index 0b03f9056692..a147aaadca85 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -54,9 +54,6 @@ static int ahci_platform_enable_phys(struct ahci_host_priv 
*hpriv)
int rc, i;
 
for (i = 0; i < hpriv->nports; i++) {
-   if (!hpriv->phys[i])
-   continue;
-
rc = phy_init(hpriv->phys[i]);
if (rc)
goto disable_phys;
@@ -89,9 +86,6 @@ static void ahci_platform_disable_phys(struct ahci_host_priv 
*hpriv)
int i;
 
for (i = 0; i < hpriv->nports; i++) {
-   if (!hpriv->phys[i])
-   continue;
-
phy_power_off(hpriv->phys[i]);
phy_exit(hpriv->phys[i]);
}
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v4 1/4] ata: libahci: Clean-up the ahci_platform_en/disable_phys functions

2015-01-15 Thread Gregory CLEMENT 
The phy_ functions handle the NULL pointer case, so there is no need
to skip them if there is a NULL pointer. Moreover, after the error
label there is already no check on the pointer. This patch removes the
unnecessary tests and brings some consistency.

Signed-off-by: Gregory CLEMENT gregory.clem...@free-electrons.com
Acked-by: Hans de Goede hdego...@redhat.com
---
 drivers/ata/libahci_platform.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index 0b03f9056692..a147aaadca85 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -54,9 +54,6 @@ static int ahci_platform_enable_phys(struct ahci_host_priv 
*hpriv)
int rc, i;
 
for (i = 0; i  hpriv-nports; i++) {
-   if (!hpriv-phys[i])
-   continue;
-
rc = phy_init(hpriv-phys[i]);
if (rc)
goto disable_phys;
@@ -89,9 +86,6 @@ static void ahci_platform_disable_phys(struct ahci_host_priv 
*hpriv)
int i;
 
for (i = 0; i  hpriv-nports; i++) {
-   if (!hpriv-phys[i])
-   continue;
-
phy_power_off(hpriv-phys[i]);
phy_exit(hpriv-phys[i]);
}
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/