Re: [PATCH v4 1/4] dt-bindings: pinctrl: mt8195: add pinctrl file and binding document

2021-04-13 Thread Rob Herring
On Tue, 13 Apr 2021 13:56:59 +0800, Zhiyong Tao wrote:
> 1. This patch adds pinctrl file for mt8195.
> 2. This patch adds mt8195 compatible node in binding document.
> 
> Signed-off-by: Zhiyong Tao 
> ---
>  .../bindings/pinctrl/pinctrl-mt8195.yaml  | 151 +++
>  include/dt-bindings/pinctrl/mt8195-pinfunc.h  | 962 ++
>  2 files changed, 1113 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
>  create mode 100644 include/dt-bindings/pinctrl/mt8195-pinfunc.h
> 

Reviewed-by: Rob Herring 


[PATCH v4 1/4] dt-bindings: pinctrl: mt8195: add pinctrl file and binding document

2021-04-12 Thread Zhiyong Tao
1. This patch adds pinctrl file for mt8195.
2. This patch adds mt8195 compatible node in binding document.

Signed-off-by: Zhiyong Tao 
---
 .../bindings/pinctrl/pinctrl-mt8195.yaml  | 151 +++
 include/dt-bindings/pinctrl/mt8195-pinfunc.h  | 962 ++
 2 files changed, 1113 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
 create mode 100644 include/dt-bindings/pinctrl/mt8195-pinfunc.h

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml 
b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
new file mode 100644
index ..2f12ec59eee5
--- /dev/null
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8195.yaml
@@ -0,0 +1,151 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pinctrl/pinctrl-mt8195.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT8195 Pin Controller
+
+maintainers:
+  - Sean Wang 
+
+description: |
+  The Mediatek's Pin controller is used to control SoC pins.
+
+properties:
+  compatible:
+const: mediatek,mt8195-pinctrl
+
+  gpio-controller: true
+
+  '#gpio-cells':
+description: |
+  Number of cells in GPIO specifier. Since the generic GPIO binding is 
used,
+  the amount of cells must be specified as 2. See the below
+  mentioned gpio binding representation for description of particular 
cells.
+const: 2
+
+  gpio-ranges:
+description: gpio valid number range.
+maxItems: 1
+
+  reg:
+description: |
+  Physical address base for gpio base registers. There are 8 GPIO
+  physical address base in mt8195.
+maxItems: 8
+
+  reg-names:
+description: |
+  Gpio base register names.
+maxItems: 8
+
+  interrupt-controller: true
+
+  '#interrupt-cells':
+const: 2
+
+  interrupts:
+description: The interrupt outputs to sysirq.
+maxItems: 1
+
+#PIN CONFIGURATION NODES
+patternProperties:
+  '-pins$':
+type: object
+description: |
+  A pinctrl node should contain at least one subnodes representing the
+  pinctrl groups available on the machine. Each subnode will list the
+  pins it needs, and how they should be configured, with regard to muxer
+  configuration, pullups, drive strength, input enable/disable and
+  input schmitt.
+  An example of using macro:
+  pincontroller {
+/* GPIO0 set as multifunction GPIO0 */
+gpio_pin {
+  pinmux = ;
+};
+/* GPIO8 set as multifunction SDA0 */
+i2c0_pin {
+  pinmux = ;
+};
+  };
+$ref: "pinmux-node.yaml"
+
+properties:
+  pinmux:
+description: |
+  Integer array, represents gpio pin number and mux setting.
+  Supported pin number and mux varies for different SoCs, and are 
defined
+  as macros in dt-bindings/pinctrl/-pinfunc.h directly.
+
+  drive-strength:
+description: |
+  It can support some arguments which is from 0 to 7. It can only 
support
+  2/4/6/8/10/12/14/16mA in mt8195.
+enum: [0, 1, 2, 3, 4, 5, 6, 7]
+
+  bias-pull-down: true
+
+  bias-pull-up: true
+
+  bias-disable: true
+
+  output-high: true
+
+  output-low: true
+
+  input-enable: true
+
+  input-disable: true
+
+  input-schmitt-enable: true
+
+  input-schmitt-disable: true
+
+required:
+  - pinmux
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - interrupt-controller
+  - '#interrupt-cells'
+  - gpio-controller
+  - '#gpio-cells'
+  - gpio-ranges
+
+additionalProperties: false
+
+examples:
+  - |
+#include 
+#include 
+pio: pinctrl@10005000 {
+compatible = "mediatek,mt8195-pinctrl";
+reg = <0x10005000 0x1000>,
+  <0x11d1 0x1000>,
+  <0x11d3 0x1000>,
+  <0x11d4 0x1000>,
+  <0x11e2 0x1000>,
+  <0x11eb 0x1000>,
+  <0x11f4 0x1000>,
+  <0x1000b000 0x1000>;
+reg-names = "iocfg0", "iocfg_bm", "iocfg_bl",
+  "iocfg_br", "iocfg_lm", "iocfg_rb",
+  "iocfg_tl", "eint";
+gpio-controller;
+#gpio-cells = <2>;
+gpio-ranges = < 0 0 144>;
+interrupt-controller;
+interrupts = ;
+#interrupt-cells = <2>;
+
+pio-pins {
+  pinmux = ;
+  output-low;
+};
+};
diff --git a/include/dt-bindings/pinctrl/mt8195-pinfunc.h 
b/include/dt-bindings/pinctrl/mt8195-pinfunc.h
new file mode 100644
index ..666331bb9b40
--- /dev/null
+++