Re: [PATCH v4 2/2] ARM: dts: cros-ec-keyboard: Use keymap marcos

2021-01-13 Thread Philip Chen
On Mon, Jan 11, 2021 at 6:07 PM Stephen Boyd  wrote:
>
> BTW, subject says 'marcos' when it should say 'macros'
Thanks - I fixed it in v5.
>
> Quoting Philip Chen (2021-01-08 17:23:32)
> > The common cros-ec keymap has been defined as macros. This patch uses
> > the macros to simply linux,keymap in cros-ec-keyboard.dtsi file.
> >
> > This patch also creates an alias for keyboard-controller to make it
> > easier to override the keymap in board-specific dts later.
> >
> > Signed-off-by: Philip Chen 
> > ---
> >


Re: [PATCH v4 2/2] ARM: dts: cros-ec-keyboard: Use keymap marcos

2021-01-11 Thread Stephen Boyd
BTW, subject says 'marcos' when it should say 'macros'

Quoting Philip Chen (2021-01-08 17:23:32)
> The common cros-ec keymap has been defined as macros. This patch uses
> the macros to simply linux,keymap in cros-ec-keyboard.dtsi file.
> 
> This patch also creates an alias for keyboard-controller to make it
> easier to override the keymap in board-specific dts later.
> 
> Signed-off-by: Philip Chen 
> ---
>


Re: [PATCH v4 2/2] ARM: dts: cros-ec-keyboard: Use keymap marcos

2021-01-11 Thread Stephen Boyd
Quoting Philip Chen (2021-01-08 17:23:32)
> The common cros-ec keymap has been defined as macros. This patch uses
> the macros to simply linux,keymap in cros-ec-keyboard.dtsi file.
> 
> This patch also creates an alias for keyboard-controller to make it
> easier to override the keymap in board-specific dts later.
> 
> Signed-off-by: Philip Chen 
> ---

Reviewed-by: Stephen Boyd 


[PATCH v4 2/2] ARM: dts: cros-ec-keyboard: Use keymap marcos

2021-01-08 Thread Philip Chen
The common cros-ec keymap has been defined as macros. This patch uses
the macros to simply linux,keymap in cros-ec-keyboard.dtsi file.

This patch also creates an alias for keyboard-controller to make it
easier to override the keymap in board-specific dts later.

Signed-off-by: Philip Chen 
---

Changes in v4:
- Fix a typo

Changes in v3:
- Create an alias for keyboard-controller

Changes in v2:
- Replace CROS_STD_NON_TOP_ROW_KEYMAP with CROS_STD_MAIN_KEYMAP

 arch/arm/boot/dts/cros-ec-keyboard.dtsi | 93 ++---
 1 file changed, 4 insertions(+), 89 deletions(-)

diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi 
b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
index 165c5bcd510e5..55c4744fa7e7a 100644
--- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
+++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
@@ -6,103 +6,18 @@
 */
 
 #include 
+#include 
 
 _ec {
-   keyboard-controller {
+   keyboard_controller: keyboard-controller {
compatible = "google,cros-ec-keyb";
keypad,num-rows = <8>;
keypad,num-columns = <13>;
google,needs-ghost-filter;
 
linux,keymap = <
-   MATRIX_KEY(0x00, 0x01, KEY_LEFTMETA)
-   MATRIX_KEY(0x00, 0x02, KEY_F1)
-   MATRIX_KEY(0x00, 0x03, KEY_B)
-   MATRIX_KEY(0x00, 0x04, KEY_F10)
-   MATRIX_KEY(0x00, 0x05, KEY_RO)
-   MATRIX_KEY(0x00, 0x06, KEY_N)
-   MATRIX_KEY(0x00, 0x08, KEY_EQUAL)
-   MATRIX_KEY(0x00, 0x0a, KEY_RIGHTALT)
-
-   MATRIX_KEY(0x01, 0x01, KEY_ESC)
-   MATRIX_KEY(0x01, 0x02, KEY_F4)
-   MATRIX_KEY(0x01, 0x03, KEY_G)
-   MATRIX_KEY(0x01, 0x04, KEY_F7)
-   MATRIX_KEY(0x01, 0x06, KEY_H)
-   MATRIX_KEY(0x01, 0x08, KEY_APOSTROPHE)
-   MATRIX_KEY(0x01, 0x09, KEY_F9)
-   MATRIX_KEY(0x01, 0x0b, KEY_BACKSPACE)
-   MATRIX_KEY(0x01, 0x0c, KEY_HENKAN)
-
-   MATRIX_KEY(0x02, 0x00, KEY_LEFTCTRL)
-   MATRIX_KEY(0x02, 0x01, KEY_TAB)
-   MATRIX_KEY(0x02, 0x02, KEY_F3)
-   MATRIX_KEY(0x02, 0x03, KEY_T)
-   MATRIX_KEY(0x02, 0x04, KEY_F6)
-   MATRIX_KEY(0x02, 0x05, KEY_RIGHTBRACE)
-   MATRIX_KEY(0x02, 0x06, KEY_Y)
-   MATRIX_KEY(0x02, 0x07, KEY_102ND)
-   MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
-   MATRIX_KEY(0x02, 0x09, KEY_F8)
-   MATRIX_KEY(0x02, 0x0a, KEY_YEN)
-
-   MATRIX_KEY(0x03, 0x00, KEY_LEFTMETA)
-   MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
-   MATRIX_KEY(0x03, 0x02, KEY_F2)
-   MATRIX_KEY(0x03, 0x03, KEY_5)
-   MATRIX_KEY(0x03, 0x04, KEY_F5)
-   MATRIX_KEY(0x03, 0x06, KEY_6)
-   MATRIX_KEY(0x03, 0x08, KEY_MINUS)
-   MATRIX_KEY(0x03, 0x09, KEY_F13)
-   MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
-   MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
-
-   MATRIX_KEY(0x04, 0x00, KEY_RIGHTCTRL)
-   MATRIX_KEY(0x04, 0x01, KEY_A)
-   MATRIX_KEY(0x04, 0x02, KEY_D)
-   MATRIX_KEY(0x04, 0x03, KEY_F)
-   MATRIX_KEY(0x04, 0x04, KEY_S)
-   MATRIX_KEY(0x04, 0x05, KEY_K)
-   MATRIX_KEY(0x04, 0x06, KEY_J)
-   MATRIX_KEY(0x04, 0x08, KEY_SEMICOLON)
-   MATRIX_KEY(0x04, 0x09, KEY_L)
-   MATRIX_KEY(0x04, 0x0a, KEY_BACKSLASH)
-   MATRIX_KEY(0x04, 0x0b, KEY_ENTER)
-
-   MATRIX_KEY(0x05, 0x01, KEY_Z)
-   MATRIX_KEY(0x05, 0x02, KEY_C)
-   MATRIX_KEY(0x05, 0x03, KEY_V)
-   MATRIX_KEY(0x05, 0x04, KEY_X)
-   MATRIX_KEY(0x05, 0x05, KEY_COMMA)
-   MATRIX_KEY(0x05, 0x06, KEY_M)
-   MATRIX_KEY(0x05, 0x07, KEY_LEFTSHIFT)
-   MATRIX_KEY(0x05, 0x08, KEY_SLASH)
-   MATRIX_KEY(0x05, 0x09, KEY_DOT)
-   MATRIX_KEY(0x05, 0x0b, KEY_SPACE)
-
-   MATRIX_KEY(0x06, 0x01, KEY_1)
-   MATRIX_KEY(0x06, 0x02, KEY_3)
-   MATRIX_KEY(0x06, 0x03, KEY_4)
-   MATRIX_KEY(0x06, 0x04, KEY_2)
-   MATRIX_KEY(0x06, 0x05, KEY_8)
-   MATRIX_KEY(0x06, 0x06, KEY_7)
-   MATRIX_KEY(0x06, 0x08, KEY_0)
-   MATRIX_KEY(0x06, 0x09, KEY_9)
-