Re: [PATCH v4 2/8] hugetlb: no need to drop hugetlb_lock to call cma_release

[David Hildenbrand]

On 06.04.21 01:00, Mike Kravetz wrote:

Now that cma_release is non-blocking and irq safe, there is no need to
drop hugetlb_lock before calling.

Signed-off-by: Mike Kravetz 
Acked-by: Roman Gushchin 
Acked-by: Michal Hocko 
---
  mm/hugetlb.c | 6 --
  1 file changed, 6 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 3c3e4baa4156..1d62f0492e7b 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1353,14 +1353,8 @@ static void update_and_free_page(struct hstate *h, 
struct page *page)
set_compound_page_dtor(page, NULL_COMPOUND_DTOR);
set_page_refcounted(page);
if (hstate_is_gigantic(h)) {
-   /*
-* Temporarily drop the hugetlb_lock, because
-* we might block in free_gigantic_page().
-*/
-   spin_unlock(_lock);
destroy_compound_gigantic_page(page, huge_page_order(h));
free_gigantic_page(page, huge_page_order(h));
-   spin_lock(_lock);
} else {
__free_pages(page, huge_page_order(h));
}



Reviewed-by: David Hildenbrand 

--
Thanks,

David / dhildenb

Re: [PATCH v4 2/8] hugetlb: no need to drop hugetlb_lock to call cma_release

[Oscar Salvador]

On Mon, Apr 05, 2021 at 04:00:37PM -0700, Mike Kravetz wrote:
> Now that cma_release is non-blocking and irq safe, there is no need to
> drop hugetlb_lock before calling.
> 
> Signed-off-by: Mike Kravetz 
> Acked-by: Roman Gushchin 
> Acked-by: Michal Hocko 

Reviewed-by: Oscar Salvador 

> ---
>  mm/hugetlb.c | 6 --
>  1 file changed, 6 deletions(-)
> 
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 3c3e4baa4156..1d62f0492e7b 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -1353,14 +1353,8 @@ static void update_and_free_page(struct hstate *h, 
> struct page *page)
>   set_compound_page_dtor(page, NULL_COMPOUND_DTOR);
>   set_page_refcounted(page);
>   if (hstate_is_gigantic(h)) {
> - /*
> -  * Temporarily drop the hugetlb_lock, because
> -  * we might block in free_gigantic_page().
> -  */
> - spin_unlock(_lock);
>   destroy_compound_gigantic_page(page, huge_page_order(h));
>   free_gigantic_page(page, huge_page_order(h));
> - spin_lock(_lock);
>   } else {
>   __free_pages(page, huge_page_order(h));
>   }
> -- 
> 2.30.2
> 

-- 
Oscar Salvador
SUSE L3

[PATCH v4 2/8] hugetlb: no need to drop hugetlb_lock to call cma_release

[Mike Kravetz]

Now that cma_release is non-blocking and irq safe, there is no need to
drop hugetlb_lock before calling.

Signed-off-by: Mike Kravetz 
Acked-by: Roman Gushchin 
Acked-by: Michal Hocko 
---
 mm/hugetlb.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 3c3e4baa4156..1d62f0492e7b 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1353,14 +1353,8 @@ static void update_and_free_page(struct hstate *h, 
struct page *page)
set_compound_page_dtor(page, NULL_COMPOUND_DTOR);
set_page_refcounted(page);
if (hstate_is_gigantic(h)) {
-   /*
-* Temporarily drop the hugetlb_lock, because
-* we might block in free_gigantic_page().
-*/
-   spin_unlock(_lock);
destroy_compound_gigantic_page(page, huge_page_order(h));
free_gigantic_page(page, huge_page_order(h));
-   spin_lock(_lock);
} else {
__free_pages(page, huge_page_order(h));
}
-- 
2.30.2