Re: [PATCH v4 4/5] ARM: sunxi: dts: Add A10/A20 PS2 pin muxing options

[Maxime Ripard]

On Fri, Jan 16, 2015 at 07:33:40PM +0530, Vishnu Patekar wrote:
> Signed-off-by: VishnuPatekar 
> ---
>  arch/arm/boot/dts/sun4i-a10.dtsi |   14 ++
>  arch/arm/boot/dts/sun7i-a20.dtsi |   14 ++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi 
> b/arch/arm/boot/dts/sun4i-a10.dtsi
> index 2c31242..8fade3e 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -629,6 +629,20 @@
>   allwinner,drive = <0>;
>   allwinner,pull = <0>;
>   };
> +
> + ps20_pins_a: ps20@0 {
> + allwinner,pins = "PI20", "PI21";
> + allwinner,function = "ps2";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> + ps21_pins_a: ps21@0 {
> + allwinner,pins = "PH12", "PH13";
> + allwinner,function = "ps2";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
>   };
>  
>   timer@01c20c00 {
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi 
> b/arch/arm/boot/dts/sun7i-a20.dtsi
> index f35c691..f9dd274 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -866,6 +866,20 @@
>   allwinner,drive = <0>;
>   allwinner,pull = <0>;
>   };
> +
> + ps20_pins_a: ps20@0 {
> + allwinner,pins = "PI20", "PI21";
> + allwinner,function = "ps2";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> + ps21_pins_a: ps21@0 {
> + allwinner,pins = "PH12", "PH13";
> + allwinner,function = "ps2";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
>   };

Same thing here, we're using defines now for the values in ,drive and
,pull, please use them.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


signature.asc
Description: Digital signature

[PATCH v4 4/5] ARM: sunxi: dts: Add A10/A20 PS2 pin muxing options

[Vishnu Patekar]

Signed-off-by: VishnuPatekar 
---
 arch/arm/boot/dts/sun4i-a10.dtsi |   14 ++
 arch/arm/boot/dts/sun7i-a20.dtsi |   14 ++
 2 files changed, 28 insertions(+)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 2c31242..8fade3e 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -629,6 +629,20 @@
allwinner,drive = <0>;
allwinner,pull = <0>;
};
+
+   ps20_pins_a: ps20@0 {
+   allwinner,pins = "PI20", "PI21";
+   allwinner,function = "ps2";
+   allwinner,drive = <0>;
+   allwinner,pull = <0>;
+   };
+
+   ps21_pins_a: ps21@0 {
+   allwinner,pins = "PH12", "PH13";
+   allwinner,function = "ps2";
+   allwinner,drive = <0>;
+   allwinner,pull = <0>;
+   };
};
 
timer@01c20c00 {
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index f35c691..f9dd274 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -866,6 +866,20 @@
allwinner,drive = <0>;
allwinner,pull = <0>;
};
+
+   ps20_pins_a: ps20@0 {
+   allwinner,pins = "PI20", "PI21";
+   allwinner,function = "ps2";
+   allwinner,drive = <0>;
+   allwinner,pull = <0>;
+   };
+
+   ps21_pins_a: ps21@0 {
+   allwinner,pins = "PH12", "PH13";
+   allwinner,function = "ps2";
+   allwinner,drive = <0>;
+   allwinner,pull = <0>;
+   };
};
 
timer@01c20c00 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/