Re: [PATCH v4 4/7] arm64: dts: renesas: r8a77970: Add csi40 port@0
On Thu, Apr 15, 2021 at 06:47:48PM +0200, Geert Uytterhoeven wrote:
> On Thu, Apr 15, 2021 at 4:47 PM Laurent Pinchart wrote:
> > On Thu, Apr 15, 2021 at 02:25:59PM +0200, Jacopo Mondi wrote:
> > > Declare port@0 in the csi40 device node and leave it un-connected.
> > > Each board .dts file will connect the port as it requires.
> > >
> > > Signed-off-by: Jacopo Mondi
> >
> > The port exists at the hardware level, so including it here sounds good.
> > The DT binding even makes the port mandatory :-)
>
> But the latter is subject to change?
>
> [PATCH] media: dt-bindings: media: renesas,csi2: Node port@0 is not mandatory
> https://lore.kernel.org/linux-devicetree/20210413155346.2471776-1-niklas.soderlund+rene...@ragnatech.se/
I've replied to that patch, it's not a good idea.
> > > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > > @@ -1106,6 +1106,10 @@ ports {
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > >
> > > + port@0 {
> > > + reg = <0>;
> > > + };
> > > +
> > > port@1 {
> > > #address-cells = <1>;
> > > #size-cells = <0>;
--
Regards,
Laurent Pinchart
Re: [PATCH v4 4/7] arm64: dts: renesas: r8a77970: Add csi40 port@0
Hi Laurent,
On Thu, Apr 15, 2021 at 4:47 PM Laurent Pinchart
wrote:
> On Thu, Apr 15, 2021 at 02:25:59PM +0200, Jacopo Mondi wrote:
> > Declare port@0 in the csi40 device node and leave it un-connected.
> > Each board .dts file will connect the port as it requires.
> >
> > Signed-off-by: Jacopo Mondi
>
> The port exists at the hardware level, so including it here sounds good.
> The DT binding even makes the port mandatory :-)
But the latter is subject to change?
[PATCH] media: dt-bindings: media: renesas,csi2: Node port@0 is not mandatory
https://lore.kernel.org/linux-devicetree/20210413155346.2471776-1-niklas.soderlund+rene...@ragnatech.se/
> > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > @@ -1106,6 +1106,10 @@ ports {
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > + port@0 {
> > + reg = <0>;
> > + };
> > +
> > port@1 {
> > #address-cells = <1>;
> > #size-cells = <0>;
\
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH v4 4/7] arm64: dts: renesas: r8a77970: Add csi40 port@0
Hi Jacopo,
Thank you for the patch.
On Thu, Apr 15, 2021 at 02:25:59PM +0200, Jacopo Mondi wrote:
> Declare port@0 in the csi40 device node and leave it un-connected.
> Each board .dts file will connect the port as it requires.
>
> Signed-off-by: Jacopo Mondi
The port exists at the hardware level, so including it here sounds good.
The DT binding even makes the port mandatory :-)
Reviewed-by: Laurent Pinchart
> ---
> arch/arm64/boot/dts/renesas/r8a77970.dtsi | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index 5a5d5649332a..e8f6352c3665 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -1106,6 +1106,10 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
> + };
> +
> port@1 {
> #address-cells = <1>;
> #size-cells = <0>;
--
Regards,
Laurent Pinchart
[PATCH v4 4/7] arm64: dts: renesas: r8a77970: Add csi40 port@0
Declare port@0 in the csi40 device node and leave it un-connected.
Each board .dts file will connect the port as it requires.
Signed-off-by: Jacopo Mondi
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index 5a5d5649332a..e8f6352c3665 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -1106,6 +1106,10 @@ ports {
#address-cells = <1>;
#size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ };
+
port@1 {
#address-cells = <1>;
#size-cells = <0>;
--
2.31.1
