Re: [PATCH v5 0/6] Add support for additional bq27xxx devices
[updated receiver list] Hi, On Wed, Sep 23, 2015 at 01:41:01PM -0500, Andrew F. Davis wrote: > On 09/23/2015 11:42 AM, Sebastian Reichel wrote: > >On Tue, Sep 22, 2015 at 02:35:05PM -0500, Andrew F. Davis wrote: > >>This series adds support for several additional bq27xxx devices and > >>makes a few related fixes. > > > >Thanks, I queued all remaining patches. I wonder if this driver > >should be converted to regmap. It supports lots of chips now and > >it might be useful to get register dumps from debugfs. > > > > I was thinking the same thing, but this driver can also communicate > over the w1 bus which doesn't look like it has the regmap hooks yet. > So I never really found a clean way, outside of bringing up regmap > on w1, to convert this driver over. Right, I assumed there was regmap support for w1 :( Evgeniy, are there plans to add 1-wire regmap support? -- Sebastian signature.asc Description: Digital signature
Re: [PATCH v5 0/6] Add support for additional bq27xxx devices
On 09/23/2015 11:42 AM, Sebastian Reichel wrote: Hi Andrew, On Tue, Sep 22, 2015 at 02:35:05PM -0500, Andrew F. Davis wrote: This series adds support for several additional bq27xxx devices and makes a few related fixes. Thanks, I queued all remaining patches. I wonder if this driver should be converted to regmap. It supports lots of chips now and it might be useful to get register dumps from debugfs. I was thinking the same thing, but this driver can also communicate over the w1 bus which doesn't look like it has the regmap hooks yet. So I never really found a clean way, outside of bringing up regmap on w1, to convert this driver over. Thanks for the queue, Andrew -- Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v5 0/6] Add support for additional bq27xxx devices
Hi Andrew, On Tue, Sep 22, 2015 at 02:35:05PM -0500, Andrew F. Davis wrote: > This series adds support for several additional bq27xxx devices and > makes a few related fixes. Thanks, I queued all remaining patches. I wonder if this driver should be converted to regmap. It supports lots of chips now and it might be useful to get register dumps from debugfs. -- Sebastian signature.asc Description: Digital signature
Re: [PATCH v5 0/6] Add support for additional bq27xxx devices
Hi Andrew, On Tue, Sep 22, 2015 at 02:35:05PM -0500, Andrew F. Davis wrote: > This series adds support for several additional bq27xxx devices and > makes a few related fixes. Thanks, I queued all remaining patches. I wonder if this driver should be converted to regmap. It supports lots of chips now and it might be useful to get register dumps from debugfs. -- Sebastian signature.asc Description: Digital signature
Re: [PATCH v5 0/6] Add support for additional bq27xxx devices
On 09/23/2015 11:42 AM, Sebastian Reichel wrote: Hi Andrew, On Tue, Sep 22, 2015 at 02:35:05PM -0500, Andrew F. Davis wrote: This series adds support for several additional bq27xxx devices and makes a few related fixes. Thanks, I queued all remaining patches. I wonder if this driver should be converted to regmap. It supports lots of chips now and it might be useful to get register dumps from debugfs. I was thinking the same thing, but this driver can also communicate over the w1 bus which doesn't look like it has the regmap hooks yet. So I never really found a clean way, outside of bringing up regmap on w1, to convert this driver over. Thanks for the queue, Andrew -- Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v5 0/6] Add support for additional bq27xxx devices
[updated receiver list] Hi, On Wed, Sep 23, 2015 at 01:41:01PM -0500, Andrew F. Davis wrote: > On 09/23/2015 11:42 AM, Sebastian Reichel wrote: > >On Tue, Sep 22, 2015 at 02:35:05PM -0500, Andrew F. Davis wrote: > >>This series adds support for several additional bq27xxx devices and > >>makes a few related fixes. > > > >Thanks, I queued all remaining patches. I wonder if this driver > >should be converted to regmap. It supports lots of chips now and > >it might be useful to get register dumps from debugfs. > > > > I was thinking the same thing, but this driver can also communicate > over the w1 bus which doesn't look like it has the regmap hooks yet. > So I never really found a clean way, outside of bringing up regmap > on w1, to convert this driver over. Right, I assumed there was regmap support for w1 :( Evgeniy, are there plans to add 1-wire regmap support? -- Sebastian signature.asc Description: Digital signature
[PATCH v5 0/6] Add support for additional bq27xxx devices
This series adds support for several additional bq27xxx devices and makes a few related fixes. v1 can be found here: [1] v2: [2] v3: [3] v4: [4] Changes from v4: - Changed if-then chains into lookups - Rebased onto git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git (branch "next") Changes from v3: - Added interrupt handling patch to series - Rebased on v4.3-rc1 Changes from v2: - Fix alignment issue - Fix commit message typo - Use INVALID_REG_ADDR in register mappings Changes from v1: - Drop first four patches from series as they have been queued at git://git.infradead.org/battery-2.6.git - Remove MODULE_ALIAS - Add comment about State-of-Charge - Add additional links to documentation - Add device names to id table - Add unlikely to if statement - Change return types to bool for status check functions [1] http://www.spinics.net/lists/kernel/msg2039278.html [2] http://www.spinics.net/lists/kernel/msg2043759.html [3] http://www.spinics.net/lists/kernel/msg2050196.html [4] http://www.spinics.net/lists/kernel/msg2074530.html Andrew F. Davis (6): power: bq27x00_battery: Renaming for consistency power: bq27xxx_battery: Platform initialization must declare a device power: bq27xxx_battery: Fix typos and change naming for state of charge functions power: bq27xxx_battery: Add support for additional bq27xxx family devices power: bq27xxx_battery: Cleanup health checking power: bq27xxx_battery: Add interrupt handling support MAINTAINERS |4 +- arch/arm/configs/omap2plus_defconfig |2 +- arch/unicore32/Kconfig|2 +- drivers/power/Kconfig | 22 +- drivers/power/Makefile|2 +- drivers/power/bq27x00_battery.c | 1125 --- drivers/power/bq27xxx_battery.c | 1374 + drivers/w1/slaves/w1_bq27000.c|5 +- include/linux/power/bq27x00_battery.h | 19 - include/linux/power/bq27xxx_battery.h | 31 + 10 files changed, 1424 insertions(+), 1162 deletions(-) delete mode 100644 drivers/power/bq27x00_battery.c create mode 100644 drivers/power/bq27xxx_battery.c delete mode 100644 include/linux/power/bq27x00_battery.h create mode 100644 include/linux/power/bq27xxx_battery.h -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v5 0/6] Add support for additional bq27xxx devices
This series adds support for several additional bq27xxx devices and makes a few related fixes. v1 can be found here: [1] v2: [2] v3: [3] v4: [4] Changes from v4: - Changed if-then chains into lookups - Rebased onto git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git (branch "next") Changes from v3: - Added interrupt handling patch to series - Rebased on v4.3-rc1 Changes from v2: - Fix alignment issue - Fix commit message typo - Use INVALID_REG_ADDR in register mappings Changes from v1: - Drop first four patches from series as they have been queued at git://git.infradead.org/battery-2.6.git - Remove MODULE_ALIAS - Add comment about State-of-Charge - Add additional links to documentation - Add device names to id table - Add unlikely to if statement - Change return types to bool for status check functions [1] http://www.spinics.net/lists/kernel/msg2039278.html [2] http://www.spinics.net/lists/kernel/msg2043759.html [3] http://www.spinics.net/lists/kernel/msg2050196.html [4] http://www.spinics.net/lists/kernel/msg2074530.html Andrew F. Davis (6): power: bq27x00_battery: Renaming for consistency power: bq27xxx_battery: Platform initialization must declare a device power: bq27xxx_battery: Fix typos and change naming for state of charge functions power: bq27xxx_battery: Add support for additional bq27xxx family devices power: bq27xxx_battery: Cleanup health checking power: bq27xxx_battery: Add interrupt handling support MAINTAINERS |4 +- arch/arm/configs/omap2plus_defconfig |2 +- arch/unicore32/Kconfig|2 +- drivers/power/Kconfig | 22 +- drivers/power/Makefile|2 +- drivers/power/bq27x00_battery.c | 1125 --- drivers/power/bq27xxx_battery.c | 1374 + drivers/w1/slaves/w1_bq27000.c|5 +- include/linux/power/bq27x00_battery.h | 19 - include/linux/power/bq27xxx_battery.h | 31 + 10 files changed, 1424 insertions(+), 1162 deletions(-) delete mode 100644 drivers/power/bq27x00_battery.c create mode 100644 drivers/power/bq27xxx_battery.c delete mode 100644 include/linux/power/bq27x00_battery.h create mode 100644 include/linux/power/bq27xxx_battery.h -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
